commit af44014f7b42697be072a7bde111c432b313d684
author Steven Moreland <smoreland@google.com> Wed Sep 07 10:09:11 2016 -0700
committer Iliyan Malchev <malchev@google.com> Thu Sep 08 22:04:31 2016 -0700
tree 639841564ee4951b832cfcbeb0d74b966be985e7
parent 9c38761b9650ff98b326c130807b0c1733de881d

Added StringHelper class

Change-Id: I1b9c7bff7127410619f0753d3aa2a52229d2fc85

generateJava.cpp

diff --git a/generateJava.cpp b/generateJava.cpp
index bc75547..90fb101 100644
--- a/generateJava.cpp
+++ b/generateJava.cpp
@@ -21,21 +21,12 @@
 #include "Interface.h"
 #include "Method.h"
 #include "Scope.h"
+#include "StringHelper.h"
 
 #include <android-base/logging.h>
 
 namespace android {
 
-static std::string upcase(const std::string in) {
-    std::string out{in};
-
-    for (auto &ch : out) {
-        ch = toupper(ch);
-    }
-
-    return out;
-}
-
 void AST::emitJavaReaderWriter(
         Formatter &out,
         const std::string &parcelObj,
@@ -235,7 +226,7 @@
     size_t index = 0;
     for (const auto &method : iface->methods()) {
         out << "public static final int kOp_"
-            << upcase(method->name())
+            << StringHelper::Upcase(method->name())
             << " = "
             << base;
 
@@ -374,7 +365,7 @@
 
             out << "\nHwParcel reply = new HwParcel();\n"
                 << "mRemote.transact(kOp_"
-                << upcase(method->name())
+                << StringHelper::Upcase(method->name())
                 << ", request, reply, ";
 
             if (method->isOneway()) {
@@ -479,7 +470,7 @@
                 << superInterface->fullJavaName()
                 << ".kOp_"
                 <<
-                upcase(method->name())
+                StringHelper::Upcase(method->name())
                 << ":\n{\n";
 
             out.indent();