Remove use of LOG(*) from HIDL.
This has been a long time complaint since it makes the error
output of HIDL look inconsistent and include unnecessary data.
Also fixed a couple of bugs around logging:
- VTS printing an error message but not erroring
- Places logging instead of CHECKing
- Updating LOG(VERBOSE) logs to follow the '-v' flag
Also replaced LOG(FATAL) with CHECK(false) for consistency.
Test: ./test/run_all_host_tests.sh
Test: manual test for verbose
Change-Id: I1c29f8561aec8fc75c8d3db4d264778cec736d07
diff --git a/ConstantExpression.cpp b/ConstantExpression.cpp
index b6857a7..5186566 100644
--- a/ConstantExpression.cpp
+++ b/ConstantExpression.cpp
@@ -87,8 +87,7 @@
// Although there is such rule to return "the unsigned counterpart of
// the signed operand", it should not reach here in our HIDL grammar.
- LOG(FATAL) << "Could not do usual arithmetic conversion for type "
- << lft << "and" << rgt;
+ CHECK(false) << "Could not do usual arithmetic conversion for type " << lft << "and" << rgt;
switch(signedRank) {
case SK(INT8): return SK(UINT8);
case SK(INT16): return SK(UINT16);