commit d9d6dcbb14081aea0dd461346ed3cd5b74424d4b
author Steven Moreland <smoreland@google.com> Wed Sep 20 15:55:39 2017 -0700
committer Steven Moreland <smoreland@google.com> Thu Sep 21 15:07:05 2017 -0700
tree ba2fd0e2a4976751bed19ec2423c795a556c3a34
parent 8f52c8a4d941cf360b1292de8addd92c16a245b6

Don't CHECK on too large literal.

If a literal is too large to parse, show correct user error.

Test: manual, run_all_host_tests.sh
Change-Id: Ic1b8f0cfcba8754050373e9846e51950ae284a57
Fixes: 64616572

hidl-gen_y.yy

diff --git a/hidl-gen_y.yy b/hidl-gen_y.yy
index e1d472f..b034951 100644
--- a/hidl-gen_y.yy
+++ b/hidl-gen_y.yy
@@ -693,7 +693,15 @@
     ;
 
 const_expr
-    : INTEGER                   { $$ = new LiteralConstantExpression($1); }
+    : INTEGER                   {
+          $$ = LiteralConstantExpression::tryParse($1);
+
+          if ($$ == nullptr) {
+              std::cerr << "ERROR: Could not parse literal: "
+                        << $1 << " at " << @1 << ".\n";
+              YYERROR;
+          }
+      }
     | fqname
       {
           if(!$1->isValidValueName()) {