commit dd583845b6e06a098583265d80f55e23ea9c7bcc
author Steven Moreland <smoreland@google.com> Wed Apr 19 13:09:57 2017 -0700
committer Steven Moreland <smoreland@google.com> Thu Apr 20 16:22:09 2017 +0000
tree 47b71c2f7490eb1ff185b961de50bc8a2d6007ec
parent e0586b0e450deaf81cc732896bced28c63de714e

hidl-gen: friendlier error messages

I've seen a ton of emails/bugs/hangouts messages because these weren't
easy to understand. Hopefully this will make hidl-gen easier to use.

Test: hidl-gen shows better error messages when -L is missing,
  unnavailable, or duplicated.
Bug: 35181507

Change-Id: I571cd978cd0dc57e9876eb2e6571a95c2d82f82f

main.cpp

diff --git a/main.cpp b/main.cpp
index 62d97c3..545d26a 100644
--- a/main.cpp
+++ b/main.cpp
@@ -44,6 +44,7 @@
         PASS_PACKAGE,
         PASS_FULL
     };
+    const std::string& name() { return mKey; }
     ValRes (*validate)(const FQName &, const std::string &language);
     status_t (*generate)(const FQName &fqName,
                          const char *hidl_gen,
@@ -1242,7 +1243,7 @@
 
     fprintf(stderr, "         -L <language> (one of");
     for (auto &e : formats) {
-        fprintf(stderr, " %s", e.mKey.c_str());
+        fprintf(stderr, " %s", e.name().c_str());
     }
     fprintf(stderr, ")\n");
 
@@ -1283,14 +1284,24 @@
 
             case 'L':
             {
-                CHECK(outputFormat == nullptr) << "Only one -L option allowed.";
+                if (outputFormat != nullptr) {
+                    fprintf(stderr,
+                            "ERROR: only one -L option allowed. \"%s\" already specified.\n",
+                            outputFormat->name().c_str());
+                    exit(1);
+                }
                 for (auto &e : formats) {
-                    if (e.mKey == optarg) {
+                    if (e.name() == optarg) {
                         outputFormat = &e;
                         break;
                     }
                 }
-                CHECK(outputFormat != nullptr) << "Output format not recognized.";
+                if (outputFormat == nullptr) {
+                    fprintf(stderr,
+                            "ERROR: unrecognized -L option: \"%s\".\n",
+                            optarg);
+                    exit(1);
+                }
                 break;
             }
 
@@ -1306,7 +1317,8 @@
     }
 
     if (outputFormat == nullptr) {
-        usage(me);
+        fprintf(stderr,
+            "ERROR: no -L option provided.\n");
         exit(1);
     }
 
@@ -1369,7 +1381,7 @@
         }
 
         OutputHandler::ValRes valid =
-            outputFormat->validate(fqName, outputFormat->mKey);
+            outputFormat->validate(fqName, outputFormat->name());
 
         if (valid == OutputHandler::FAILED) {
             fprintf(stderr,