commit 44666f97392f1f0f8be292fe6a4edcf9237540df
author Alex Deymo <deymo@chromium.org> Tue Jul 22 20:29:24 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Fri Jul 25 03:42:22 2014 +0000
tree c61f94af42afcd2b7ceed58580fb7439360bff72
parent 44cab30e0ee04b277e8463785ab069e9885a9f2d

update_engine: Remove dependency on libupdate_engine from the client.

The update_engine_client is a very small DBus client that only
depends on a single utils:: function from the update_engine daemon
codebase. Because of this, it was forced to be linked against many
libraries that it didn't use.

This patch factors out this glib helper function to a new
glib_utils.{cc,h} file and includes only that in the
update_engine_client binary.

BUG=chromium:396440
TEST=FEATURES=test emerge-link update_engine

Change-Id: Icf8d8b3c6ebd22cdb39e6674fb3d9071071ec941
Reviewed-on: https://chromium-review.googlesource.com/209472
Reviewed-by: David Zeuthen <zeuthen@chromium.org>
Tested-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>

update_engine_client.cc

diff --git a/update_engine_client.cc b/update_engine_client.cc
index 516895a..eb092b5 100644
--- a/update_engine_client.cc
+++ b/update_engine_client.cc
@@ -4,24 +4,24 @@
 
 #include <string>
 
+#include <base/logging.h>
 #include <chromeos/dbus/service_constants.h>
 #include <dbus/dbus.h>
 #include <gflags/gflags.h>
 #include <glib.h>
 
 #include "update_engine/dbus_constants.h"
-#include "update_engine/subprocess.h"
-#include "update_engine/utils.h"
+#include "update_engine/glib_utils.h"
 
 extern "C" {
 #include "update_engine/update_engine.dbusclient.h"
 }
 
-using chromeos_update_engine::kUpdateEngineServiceName;
-using chromeos_update_engine::kUpdateEngineServicePath;
-using chromeos_update_engine::kUpdateEngineServiceInterface;
 using chromeos_update_engine::AttemptUpdateFlags;
 using chromeos_update_engine::kAttemptUpdateFlagNonInteractive;
+using chromeos_update_engine::kUpdateEngineServiceInterface;
+using chromeos_update_engine::kUpdateEngineServiceName;
+using chromeos_update_engine::kUpdateEngineServicePath;
 using chromeos_update_engine::utils::GetAndFreeGError;
 using std::string;
 
@@ -535,7 +535,6 @@
   // Boilerplate init commands.
   g_type_init();
   dbus_threads_init_default();
-  chromeos_update_engine::Subprocess::Init();
   google::ParseCommandLineFlags(&argc, &argv, true);
 
   // Update the status if requested.