update_engine: Include direction="in" in all method args missing it.
The instrospect.dtd specifies:
<!-- Method arguments SHOULD include "direction",
while signal and error arguments SHOULD not (since there's no point).
The DTD format can't express that subtlety. -->
<!ATTLIST arg direction (in|out) "in">
This make the direction="in" the default for args that are part of
method tags. Nevertheless, these args SHOULD include the direction.
This patch adds direction="in" to all the method args, and fixes the
indent.
BUG=None
TEST=`generate-chromeos-dbus-bindings --input=update_engine/update_engine.xml` now works.
Change-Id: I96c86b05395d51a7697790f627464c3e568d9c12
Reviewed-on: https://chromium-review.googlesource.com/220133
Tested-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: David Zeuthen <zeuthen@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>
diff --git a/update_engine.xml b/update_engine.xml
index b99f345..80fe128 100644
--- a/update_engine.xml
+++ b/update_engine.xml
@@ -6,25 +6,25 @@
<node name="/org/chromium">
<interface name="org.chromium.UpdateEngineInterface">
<annotation name="org.freedesktop.DBus.GLib.CSymbol"
- value="update_engine_service"/>
+ value="update_engine_service" />
<annotation name="org.freedesktop.DBus.GLib.ClientCSymbol"
- value="update_engine_client"/>
+ value="update_engine_client" />
<method name="AttemptUpdate">
- <arg type="s" name="app_version" />
- <arg type="s" name="omaha_url" />
+ <arg type="s" name="app_version" direction="in" />
+ <arg type="s" name="omaha_url" direction="in" />
</method>
<!-- TODO(zeuthen,chromium:286399): Rename to AttemptUpdate and
update Chrome and other users of the AttemptUpdate() method
in lockstep.
-->
<method name="AttemptUpdateWithFlags">
- <arg type="s" name="app_version" />
- <arg type="s" name="omaha_url" />
+ <arg type="s" name="app_version" direction="in" />
+ <arg type="s" name="omaha_url" direction="in" />
<!-- See AttemptUpdateFlags enum in dbus_constants.h. -->
- <arg type="i" name="flags" />
+ <arg type="i" name="flags" direction="in" />
</method>
<method name="AttemptRollback">
- <arg type="b" name="powerwash" />
+ <arg type="b" name="powerwash" direction="in" />
</method>
<method name="CanRollback">
<arg type="b" name="can_rollback" direction="out" />
@@ -41,29 +41,29 @@
<method name="RebootIfNeeded">
</method>
<method name="SetChannel">
- <arg type="s" name="target_channel" />
- <arg type="b" name="is_powerwash_allowed" />
+ <arg type="s" name="target_channel" direction="in" />
+ <arg type="b" name="is_powerwash_allowed" direction="in" />
</method>
<method name="GetChannel">
- <arg type="b" name="get_current_channel" />
+ <arg type="b" name="get_current_channel" direction="in" />
<arg type="s" name="channel" direction="out" />
</method>
<method name="SetP2PUpdatePermission">
<annotation name="org.freedesktop.DBus.GLib.CSymbol"
- value="update_engine_service_set_p2p_update_permission"/>
+ value="update_engine_service_set_p2p_update_permission" />
<annotation name="org.freedesktop.DBus.GLib.ClientCSymbol"
- value="update_engine_client_set_p2p_update_permission"/>
- <arg type="b" name="enabled" />
+ value="update_engine_client_set_p2p_update_permission" />
+ <arg type="b" name="enabled" direction="in" />
</method>
<method name="GetP2PUpdatePermission">
<annotation name="org.freedesktop.DBus.GLib.CSymbol"
- value="update_engine_service_get_p2p_update_permission"/>
+ value="update_engine_service_get_p2p_update_permission" />
<annotation name="org.freedesktop.DBus.GLib.ClientCSymbol"
- value="update_engine_client_get_p2p_update_permission"/>
+ value="update_engine_client_get_p2p_update_permission" />
<arg type="b" name="enabled" direction="out" />
</method>
<method name="SetUpdateOverCellularPermission">
- <arg type="b" name="allowed" />
+ <arg type="b" name="allowed" direction="in" />
</method>
<method name="GetUpdateOverCellularPermission">
<arg type="b" name="allowed" direction="out" />