Segregate UMA metrics for production scenarios from test scenarios.
Currently we separate the UMA metrics only by one category: whether the
device is in dev mode or not. In addition, we need to exclude the noise
from these two categories:
1. Most of our testing on MP-signed images which are performed
with autest.
2. All our hwlab tests run in non-dev mode but they use dev-signed images
with dev-firmware keys.
So this CL defines additional bit fields to represent these states and
if any of these three flags are set, the UMA metric is sent to a
DevModeErrorCodes bucket. Thus the NormalErrorCodes bucket will have only
the production errors and thus we can monitor more effectively.
BUG=chromium-os:37613
TEST=Updated unit tests, ran on ZGB for all scenarios.
Change-Id: Id9cce33f09d1cc50cb15e67c731f7548940cbc24
Reviewed-on: https://gerrit.chromium.org/gerrit/41103
Reviewed-by: Chris Sosa <sosa@chromium.org>
Commit-Queue: Jay Srinivasan <jaysri@chromium.org>
Tested-by: Jay Srinivasan <jaysri@chromium.org>
diff --git a/system_state.cc b/system_state.cc
index fc3ba57..42737bb 100644
--- a/system_state.cc
+++ b/system_state.cc
@@ -4,7 +4,7 @@
#include <base/file_util.h>
-#include "update_engine/system_state.h"
+#include "update_engine/real_system_state.h"
namespace chromeos_update_engine {
@@ -42,6 +42,9 @@
gpio_handler_.reset(new NoopGpioHandler(false));
}
+ // Create the update attempter.
+ update_attempter_.reset(new UpdateAttempter(this, &dbus_));
+
// All is well. Initialization successful.
return true;
}