update_engine: Mock out UpdateAttempter and OmahaRequestParams.
These classes are used by other classes so we need to have a way to
unit test those. This patch converts some public methods on these
classes to virtual methods so they can be mocked. It implements a
new MockOmahaRequestParams with all the public methods behaving like
the real object by default. This is now the default class used by the
FakeSystemState. Finally, the UpdateAttempterMock is renamed to
MockUpdateAttempter to be more consistent with other classes in
the project.
BUG=None
TEST=Unittest pass. Follow up CL using these classes also passes.
Change-Id: Iacb7e19d10c1526cea9659c27ab798cad126816f
Reviewed-on: https://chromium-review.googlesource.com/225855
Reviewed-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>
Tested-by: Alex Deymo <deymo@chromium.org>
diff --git a/fake_system_state.cc b/fake_system_state.cc
index 8c5ffc9..8dec9f5 100644
--- a/fake_system_state.cc
+++ b/fake_system_state.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "update_engine/fake_system_state.h"
+
#include "update_engine/update_manager/fake_state.h"
using chromeos_update_manager::FakeState;
@@ -14,7 +15,7 @@
FakeSystemState::FakeSystemState()
: mock_connection_manager_(this),
mock_update_attempter_(this, &dbus_),
- default_request_params_(this),
+ mock_request_params_(this),
fake_update_manager_(&fake_clock_),
clock_(&fake_clock_),
connection_manager_(&mock_connection_manager_),
@@ -24,7 +25,7 @@
powerwash_safe_prefs_(&mock_powerwash_safe_prefs_),
payload_state_(&mock_payload_state_),
update_attempter_(&mock_update_attempter_),
- request_params_(&default_request_params_),
+ request_params_(&mock_request_params_),
p2p_manager_(&mock_p2p_manager_),
update_manager_(&fake_update_manager_),
device_policy_(nullptr),