update_engine: Add override when possible.
Google Style Guide requires to include the "override" keyword
when overriding a method on a derived class, so the compiler will
catch errors if the method is not overriding a member of the base
class.
This patch introduces the "override" keyword when possible.
BUG=None
TEST=FEATURES=test emerge-link update_engine
Change-Id: Ie83d115c5730f3b35b3d95859a54bc1a48e0be7b
Reviewed-on: https://chromium-review.googlesource.com/228928
Tested-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>
diff --git a/omaha_request_action.h b/omaha_request_action.h
index 0b93109..d086a24 100644
--- a/omaha_request_action.h
+++ b/omaha_request_action.h
@@ -124,24 +124,25 @@
OmahaEvent* event,
HttpFetcher* http_fetcher,
bool ping_only);
- virtual ~OmahaRequestAction();
+ ~OmahaRequestAction() override;
typedef ActionTraits<OmahaRequestAction>::InputObjectType InputObjectType;
typedef ActionTraits<OmahaRequestAction>::OutputObjectType OutputObjectType;
- void PerformAction();
- void TerminateProcessing();
- void ActionCompleted(ErrorCode code);
+ void PerformAction() override;
+ void TerminateProcessing() override;
+ void ActionCompleted(ErrorCode code) override;
int GetHTTPResponseCode() { return http_fetcher_->http_response_code(); }
// Debugging/logging
static std::string StaticType() { return "OmahaRequestAction"; }
- std::string Type() const { return StaticType(); }
+ std::string Type() const override { return StaticType(); }
// Delegate methods (see http_fetcher.h)
- virtual void ReceivedBytes(HttpFetcher *fetcher,
- const char* bytes, int length);
+ void ReceivedBytes(HttpFetcher *fetcher,
+ const char* bytes, int length) override;
- virtual void TransferComplete(HttpFetcher *fetcher, bool successful);
+ void TransferComplete(HttpFetcher *fetcher, bool successful) override;
+
// Returns true if this is an Event request, false if it's an UpdateCheck.
bool IsEvent() const { return event_.get() != nullptr; }