commit 6ee50b9814f101b5b5c0ae60af1dedf059ad2106
author Casey Dahlin <sadmac@google.com> Mon Feb 01 13:40:21 2016 -0800
committer Casey Dahlin <sadmac@google.com> Mon Feb 01 22:56:41 2016 +0000
tree 16b0afb330fe09f53f2068e1e8b5887b9e0fbcc8
parent a715f7b8a211b5c4b74206539e9aa7ddacf4b243

Handle interactive bool correctly from binder interface

We inverted the meaning of at_user_request from binder, due to the fact
that the flag the back end takes is inverted.

TEST=Verified --update sends correct commands
Bug: 26896505

Change-Id: I480376a4da47d007e7914b6673309417a93315ab

client_library/client_binder.cc

diff --git a/client_library/client_binder.cc b/client_library/client_binder.cc
index 6993be1..6f9b7b6 100644
--- a/client_library/client_binder.cc
+++ b/client_library/client_binder.cc
@@ -21,6 +21,7 @@
 #include <base/message_loop/message_loop.h>
 #include <utils/String8.h>
 
+#include "update_engine/common_service.h"
 #include "update_engine/parcelable_update_engine_status.h"
 #include "update_engine/update_status_utils.h"
 
@@ -31,6 +32,7 @@
 using android::binder::Status;
 using android::getService;
 using chromeos_update_engine::StringToUpdateStatus;
+using chromeos_update_engine::UpdateEngineService;
 using std::string;
 
 namespace update_engine {
@@ -47,8 +49,9 @@
                                              const string& in_omaha_url,
                                              bool at_user_request) {
   return service_->AttemptUpdate(String16{in_app_version.c_str()},
-                                 String16{in_omaha_url.c_str()},
-                                 at_user_request ? 1 : 0).isOk();
+      String16{in_omaha_url.c_str()},
+      at_user_request ? 0 :
+          UpdateEngineService::kAttemptUpdateFlagNonInteractive).isOk();
 }
 
 bool BinderUpdateEngineClient::GetStatus(int64_t* out_last_checked_time,