commit 7067445ffbfb87e7b6b07c0a84528f915141e147
author Alex Vakulenko <avakulenko@google.com> Sat Jan 23 21:09:11 2016 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Sat Jan 23 21:09:23 2016 +0000
tree 136e7775b36bc94861a9b580a2b55e3cc5719b4c
parent bdd765e3157a2b04265dcdab0d7a55e747924555

Revert "Compile libupdate_engine_client even when dbus is disabled."

This reverts commit e66cb48c5f2d141e22d9b5942e85cc35e7b0c636.

Change-Id: I2d9d8b98b8af68016fb7b5383dd71cbb285096a2

Android.mk

diff --git a/Android.mk b/Android.mk
index c8f310c..aa63dd1 100644
--- a/Android.mk
+++ b/Android.mk
@@ -569,6 +569,8 @@
 LOCAL_SRC_FILES := $(ue_delta_generator_src_files)
 include $(BUILD_EXECUTABLE)
 
+ifeq ($(local_use_dbus),1)
+
 # libupdate_engine_client
 # ========================================================
 include $(CLEAR_VARS)
@@ -577,11 +579,9 @@
     -Wall \
     -Werror \
     -Wno-unused-parameter \
-    -DUSE_DBUS=$(local_use_dbus) \
     -DUSE_BINDER=$(local_use_binder)
 LOCAL_CLANG := true
 LOCAL_CPP_EXTENSION := .cc
-# TODO(deymo): Remove "external/cros/system_api/dbus" when dbus is not used.
 LOCAL_C_INCLUDES := \
     $(LOCAL_PATH)/client_library/include \
     external/cros/system_api/dbus \
@@ -590,35 +590,33 @@
 LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/client_library/include
 LOCAL_SHARED_LIBRARIES := \
     libchrome \
-    libbrillo
+    libchrome-dbus \
+    libbrillo \
+    libbrillo-dbus
+LOCAL_STATIC_LIBRARIES := \
+    update_engine_client-dbus-proxies
 LOCAL_SRC_FILES := \
     client_library/client.cc \
     update_status_utils.cc
 
-# We can only compile support for one IPC mechanism. If both "binder" and "dbus"
-# are defined, we prefer binder.
 ifeq ($(local_use_binder),1)
 LOCAL_AIDL_INCLUDES := $(LOCAL_PATH)/binder_bindings
+LOCAL_SRC_FILES += \
+    client_library/client_binder.cc \
+    parcelable_update_engine_status.cc \
+    binder_bindings/android/brillo/IUpdateEngine.aidl \
+    binder_bindings/android/brillo/IUpdateEngineStatusCallback.aidl
 LOCAL_SHARED_LIBRARIES += \
     libbinder \
     libutils
-LOCAL_SRC_FILES += \
-    binder_bindings/android/brillo/IUpdateEngine.aidl \
-    binder_bindings/android/brillo/IUpdateEngineStatusCallback.aidl \
-    client_library/client_binder.cc \
-    parcelable_update_engine_status.cc
 else  # local_use_binder != 1
-LOCAL_STATIC_LIBRARIES := \
-    update_engine_client-dbus-proxies
-LOCAL_SHARED_LIBRARIES += \
-    libchrome-dbus \
-    libbrillo-dbus
-LOCAL_SRC_FILES += \
-    client_library/client_dbus.cc
+LOCAL_SRC_FILES += client_library/client_dbus.cc
 endif  # local_use_binder == 1
 
 include $(BUILD_SHARED_LIBRARY)
 
+endif  # local_use_dbus == 1
+
 # Weave schema files
 # ========================================================
 include $(CLEAR_VARS)