update_engine: update to libbase 242728
Made update_engine link with libchrome-242728 and fixed compile
issues due to changes in namespaces and include file layout.
Also removed some of suppressed compiler warnings and fixed the
issues masked by them (e.g. mismatched printf-like specifiers).
Added -Wextra compiler option to enable additional useful warnings
to ensure more strict checking... Had to disable "unused-parameter"
though since we have a lot of functions (mainly in fakes) that do
not use all of their parameters.
BUG=chromium:351593
TEST=Unit tests passed.
CQ-DEPEND=CL:191721
Change-Id: I1aa63a48d5f1f4ea75ba6b00aec7aa5f3bad15c4
Reviewed-on: https://chromium-review.googlesource.com/191510
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
diff --git a/http_fetcher_unittest.cc b/http_fetcher_unittest.cc
index 82aef7f..f09bf52 100644
--- a/http_fetcher_unittest.cc
+++ b/http_fetcher_unittest.cc
@@ -13,9 +13,9 @@
#include <base/logging.h>
#include <base/memory/scoped_ptr.h>
-#include <base/string_util.h>
-#include <base/stringprintf.h>
-#include <base/time.h>
+#include <base/strings/string_util.h>
+#include <base/strings/stringprintf.h>
+#include <base/time/time.h>
#include <chromeos/dbus/service_constants.h>
#include <glib.h>
#include <gtest/gtest.h>
@@ -56,7 +56,7 @@
static inline string LocalServerUrlForPath(in_port_t port,
const string& path) {
- string port_str = (port ? StringPrintf(":%hu", port) : "");
+ string port_str = (port ? base::StringPrintf(":%hu", port) : "");
return base::StringPrintf("http://127.0.0.1%s%s", port_str.c_str(),
path.c_str());
}
@@ -736,10 +736,10 @@
StartTransferArgs start_xfer_args = {
fetcher.get(),
LocalServerUrlForPath(server->GetPort(),
- StringPrintf("/flaky/%d/%d/%d/%d", kBigLength,
- kFlakyTruncateLength,
- kFlakySleepEvery,
- kFlakySleepSecs))
+ base::StringPrintf("/flaky/%d/%d/%d/%d", kBigLength,
+ kFlakyTruncateLength,
+ kFlakySleepEvery,
+ kFlakySleepSecs))
};
g_timeout_add(0, StartTransfer, &start_xfer_args);
@@ -853,10 +853,10 @@
StartTransferArgs start_xfer_args = {
fetcher.get(),
LocalServerUrlForPath(0,
- StringPrintf("/flaky/%d/%d/%d/%d", kBigLength,
- kFlakyTruncateLength,
- kFlakySleepEvery,
- kFlakySleepSecs))
+ base::StringPrintf("/flaky/%d/%d/%d/%d", kBigLength,
+ kFlakyTruncateLength,
+ kFlakySleepEvery,
+ kFlakySleepSecs))
};
g_timeout_add(0, StartTransfer, &start_xfer_args);
g_main_loop_run(loop);
@@ -1047,7 +1047,7 @@
multi_fetcher->ClearRanges();
for (vector<pair<off_t, off_t> >::const_iterator it = ranges.begin(),
e = ranges.end(); it != e; ++it) {
- std::string tmp_str = StringPrintf("%jd+", it->first);
+ std::string tmp_str = base::StringPrintf("%jd+", it->first);
if (it->second > 0) {
base::StringAppendF(&tmp_str, "%jd", it->second);
multi_fetcher->AddRange(it->first, it->second);