Make unit tests less timing sensitive when unmounting busy loop devices.
This CL modifies utils::UnmountFilesystem() to retry when umount()
fails to unmount a busy loop device and replaces several unit tests to
use the modified utils::UnmountFilesystem() instead of calling
System("umount").
BUG=chromium-os:35112
TEST=Run unit tests repeatedly.
Change-Id: I42978f02b4797c68acbec6c351ea2663b9ec7b59
Reviewed-on: https://gerrit.chromium.org/gerrit/34862
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Ready: Ben Chan <benchan@chromium.org>
diff --git a/test_utils.cc b/test_utils.cc
index fddd2d1..5379979 100644
--- a/test_utils.cc
+++ b/test_utils.cc
@@ -217,7 +217,7 @@
kMountPath, kMountPath)));
EXPECT_EQ(0, System(StringPrintf("ln -s bogus %s/boguslink",
kMountPath)));
- EXPECT_EQ(0, System(StringPrintf("umount %s", kMountPath)));
+ EXPECT_TRUE(utils::UnmountFilesystem(kMountPath));
if (out_paths) {
out_paths->clear();