Correctly report firmware update failure if RO needs update.
If the RO Firmware needs updating but can't be because it's
really RO, then report a new erro code (43) back to Omaha.
This normally only happens during board bringup when the RO
firmware is locked prematurely. We want to know these devices
exist so we can replace them.
BUG=chromium:218555
TEST=Build/unittests. Did NOT test on hardware with bug.
Change-Id: I383a999f1b175c378bef936c55d87565d8113336
Reviewed-on: https://gerrit.chromium.org/gerrit/63841
Commit-Queue: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
diff --git a/payload_state_unittest.cc b/payload_state_unittest.cc
index eb66628..0eb1875 100644
--- a/payload_state_unittest.cc
+++ b/payload_state_unittest.cc
@@ -86,7 +86,7 @@
class PayloadStateTest : public ::testing::Test { };
TEST(PayloadStateTest, DidYouAddANewErrorCode) {
- if (kErrorCodeUmaReportedMax != 43) {
+ if (kErrorCodeUmaReportedMax != 44) {
LOG(ERROR) << "The following failure is intentional. If you added a new "
<< "ErrorCode enum value, make sure to add it to the "
<< "PayloadState::UpdateFailed method and then update this test "