Never defer updates on interactive checks.
Looks like we had a bug when adding the deferred logic. We should never
defer on interactive checks as it's really confusing to a user who's
doing an interactive check. This change is simple enough but I've changed
all unittests that tested deferred behavior to also make sure they allow
an update if interactive is set.
BUG=chromium:274056
TEST=Unittests
Change-Id: Ib63dbd20e64bed2da84e68c96291335e00e944a2
Reviewed-on: https://gerrit.chromium.org/gerrit/66864
Reviewed-by: Chris Sosa <sosa@chromium.org>
Tested-by: Chris Sosa <sosa@chromium.org>
Commit-Queue: Chris Sosa <sosa@chromium.org>
diff --git a/omaha_request_params.h b/omaha_request_params.h
index 1a65c75..19a1900 100644
--- a/omaha_request_params.h
+++ b/omaha_request_params.h
@@ -118,6 +118,7 @@
inline bool delta_okay() const { return delta_okay_; }
// True if this is a user-initiated update check.
+ inline void set_interactive(bool interactive) { interactive_ = interactive; }
inline bool interactive() const { return interactive_; }
inline void set_update_url(const std::string& url) { update_url_ = url; }