commit c0dd0210d01406df4b88086ea1349a75b8fe0584
author David Zeuthen <zeuthen@chromium.org> Fri Apr 04 14:49:49 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Sun Apr 06 04:17:37 2014 +0000
tree c688481d9a3b5013915bf26a2f0531e88bc20155
parent 76b2b4822d57360d0c77f070bd8fc25bc08fd93e

metrics: Use sparse histogram for metrics::DownloadErrorCode values

This was pointed out by asvitkine@ when reviewing the histograms.xml
change. Thanks!

BUG=chromium:355745
TEST=Unit tests pass.

Change-Id: I3bb49210d0e9bc443546d05f3597590ec7814841
Reviewed-on: https://chromium-review.googlesource.com/193274
Reviewed-by: David Zeuthen <zeuthen@chromium.org>
Commit-Queue: David Zeuthen <zeuthen@chromium.org>
Tested-by: David Zeuthen <zeuthen@chromium.org>

omaha_request_action_unittest.cc

diff --git a/omaha_request_action_unittest.cc b/omaha_request_action_unittest.cc
index 0bc5538..b73209c 100644
--- a/omaha_request_action_unittest.cc
+++ b/omaha_request_action_unittest.cc
@@ -279,9 +279,8 @@
           static_cast<int>(metrics::CheckReaction::kNumConstants) - 1))
       .Times(expected_check_reaction == metrics::CheckReaction::kUnset ? 0 : 1);
   EXPECT_CALL(*mock_system_state.mock_metrics_lib(),
-      SendEnumToUMA(metrics::kMetricCheckDownloadErrorCode,
-          static_cast<int>(expected_download_error_code),
-          static_cast<int>(metrics::DownloadErrorCode::kNumConstants) - 1))
+      SendSparseToUMA(metrics::kMetricCheckDownloadErrorCode,
+          static_cast<int>(expected_download_error_code)))
       .Times(expected_download_error_code == metrics::DownloadErrorCode::kUnset
              ? 0 : 1);