commit c1972483fa3446852b42ce97d1ea43b9caaaf56f
author Chris Sosa <sosa@chromium.org> Tue Apr 30 22:31:10 2013 -0700
committer ChromeBot <chrome-bot@google.com> Mon Jun 03 16:25:55 2013 -0700
tree e3f4d16e96f466796487c51a7151f9f2fc8c656b
parent 5cac5917e9872d52e4c06fb82f04e118a1dd53de

Add EC and Firmware Versions to the Omaha Response.

This CL adds 2 additional utils methods to get the version for both the
fw and ec versions. I've added a unittest to verify these work and piped
in the values into the omaha response.

BUG=chromium:219871
TEST=Unittests + on device

Change-Id: Iadf70fff858988f52797d94bcdb062bb2482bbf3
Reviewed-on: https://gerrit.chromium.org/gerrit/49713
Commit-Queue: Chris Sosa <sosa@chromium.org>
Reviewed-by: Chris Sosa <sosa@chromium.org>
Tested-by: Chris Sosa <sosa@chromium.org>

omaha_request_action_unittest.cc

diff --git a/omaha_request_action_unittest.cc b/omaha_request_action_unittest.cc
index 8ae951e..de5f49f 100644
--- a/omaha_request_action_unittest.cc
+++ b/omaha_request_action_unittest.cc
@@ -53,6 +53,8 @@
     "en-US",
     "unittest",
     "OEM MODEL 09235 7471",
+    "ChromeOSFirmware.1.0",
+    "0X0A1",
     false,  // delta okay
     false,  // interactive
     "http://url",
@@ -827,6 +829,8 @@
                             "en-US",
                             "unittest_track<",
                             "<OEM MODEL>",
+                            "ChromeOSFirmware.1.0",
+                            "EC100",
                             false,  // delta okay
                             false,  // interactive
                             "http://url",
@@ -927,6 +931,10 @@
       string::npos);
   EXPECT_NE(post_str.find("hardware_class=\"OEM MODEL 09235 7471\""),
             string::npos);
+  EXPECT_NE(post_str.find("fw_version=\"ChromeOSFirmware.1.0\""),
+            string::npos);
+  EXPECT_NE(post_str.find("ec_version=\"0X0A1\""),
+            string::npos);
 }
 
 
@@ -954,6 +962,10 @@
       string::npos);
   EXPECT_NE(post_str.find("hardware_class=\"OEM MODEL 09235 7471\""),
             string::npos);
+  EXPECT_NE(post_str.find("fw_version=\"ChromeOSFirmware.1.0\""),
+            string::npos);
+  EXPECT_NE(post_str.find("ec_version=\"0X0A1\""),
+            string::npos);
 }
 
 TEST(OmahaRequestActionTest, FormatSuccessEventOutputTest) {
@@ -1035,6 +1047,8 @@
                               "en-US",
                               "unittest_track",
                               "OEM MODEL REV 1234",
+                              "ChromeOSFirmware.1.0",
+                              "EC100",
                               delta_okay,
                               false,  // interactive
                               "http://url",
@@ -1072,6 +1086,8 @@
                               "en-US",
                               "unittest_track",
                               "OEM MODEL REV 1234",
+                              "ChromeOSFirmware.1.0",
+                              "EC100",
                               true,  // delta_okay
                               interactive,
                               "http://url",