For actions, switch bool success into an exit code.
This way we can signal specific error conditions and then
send appropriate events to Omaha from the UpdateAttempter.
BUG=560
TEST=unit tests, gmerged and looked at logs
Review URL: http://codereview.chromium.org/3022008
diff --git a/omaha_response_handler_action_unittest.cc b/omaha_response_handler_action_unittest.cc
index f751bbe..90cbed9 100644
--- a/omaha_response_handler_action_unittest.cc
+++ b/omaha_response_handler_action_unittest.cc
@@ -25,18 +25,18 @@
: public ActionProcessorDelegate {
public:
OmahaResponseHandlerActionProcessorDelegate()
- : success_(false),
- success_set_(false) {}
+ : code_(kActionCodeError),
+ code_set_(false) {}
void ActionCompleted(ActionProcessor* processor,
AbstractAction* action,
- bool success) {
+ ActionExitCode code) {
if (action->Type() == OmahaResponseHandlerAction::StaticType()) {
- success_ = success;
- success_set_ = true;
+ code_ = code;
+ code_set_ = true;
}
}
- bool success_;
- bool success_set_;
+ ActionExitCode code_;
+ bool code_set_;
};
namespace {
@@ -73,8 +73,8 @@
<< "Update test to handle non-asynch actions";
if (out)
*out = collector_action.object();
- EXPECT_TRUE(delegate.success_set_);
- return delegate.success_;
+ EXPECT_TRUE(delegate.code_set_);
+ return delegate.code_ == kActionCodeSuccess;
}
TEST_F(OmahaResponseHandlerActionTest, SimpleTest) {