Switch FileWriter::Write to boolean result code.
FileWriter::Write returned either the number of bytes written, or a negative
error code. No clients were doing anything with the result other than checking
for success or failure, and many clients were considering any non-zero result
success.
So, I changed the API to return less information, but just the information the
clients needed. Success or failure.
BUG=chromium-os:8521
TEST=Unittests
Change-Id: I51513d6aa7b704dc27fb90d5fae4dc7118a3f86c
Reviewed-on: https://gerrit.chromium.org/gerrit/11532
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Commit-Ready: Don Garrett <dgarrett@chromium.org>
diff --git a/utils.cc b/utils.cc
index 5273347..1c9425a 100644
--- a/utils.cc
+++ b/utils.cc
@@ -89,7 +89,7 @@
O_WRONLY | O_CREAT | O_TRUNC,
0600));
ScopedFileWriterCloser closer(&writer);
- TEST_AND_RETURN_FALSE_ERRNO(data_len == writer.Write(data, data_len));
+ TEST_AND_RETURN_FALSE_ERRNO(writer.Write(data, data_len));
return true;
}