AU: Minor fixes to get it to do full update on real device
- Link w/ gtest only for unittests.
- filesystem_copier_action: always send install plan on the output pipe
on success, even if no copy was performed.
- omaha_response_handler: properly choose install partition based on
new GPT partition spec.
- More useful logging to match memento_updater (which update URL is
used, dump of the request/response for the update check).
- Fixed a bug where I wasn't bonding the proper actions together in update_attempter.
BUG=None
TEST=attached unittests/did full update on Eee PC
Review URL: http://codereview.chromium.org/2044001
diff --git a/update_attempter.cc b/update_attempter.cc
index e12fed9..ad3bd9e 100644
--- a/update_attempter.cc
+++ b/update_attempter.cc
@@ -70,14 +70,18 @@
// Bond them together. We have to use the leaf-types when calling
// BondActions().
- BondActions(request_prep_action.get(), update_check_action.get());
- BondActions(update_check_action.get(), response_handler_action.get());
- BondActions(response_handler_action.get(), filesystem_copier_action.get());
+ BondActions(request_prep_action.get(),
+ update_check_action.get());
+ BondActions(update_check_action.get(),
+ response_handler_action.get());
BondActions(response_handler_action.get(),
+ filesystem_copier_action.get());
+ BondActions(filesystem_copier_action.get(),
kernel_filesystem_copier_action.get());
BondActions(kernel_filesystem_copier_action.get(),
download_action.get());
- BondActions(download_action.get(), postinstall_runner_action_precommit.get());
+ BondActions(download_action.get(),
+ postinstall_runner_action_precommit.get());
BondActions(postinstall_runner_action_precommit.get(),
set_bootable_flag_action.get());
BondActions(set_bootable_flag_action.get(),
@@ -96,15 +100,7 @@
return;
}
if (!success) {
- if (!full_update_) {
- LOG(ERROR) << "Update failed. Attempting full update";
- actions_.clear();
- response_handler_action_.reset();
- Update(true);
- return;
- } else {
- LOG(ERROR) << "Full update failed. Aborting";
- }
+ LOG(INFO) << "Update failed.";
}
g_main_loop_quit(loop_);
}