blob: f22c137efc3b202360759a7ba94674bc3f64bc50 [file] [log] [blame]
Alex Deymoaea4c1c2015-08-19 20:24:43 -07001//
2// Copyright (C) 2012 The Android Open Source Project
3//
4// Licensed under the Apache License, Version 2.0 (the "License");
5// you may not use this file except in compliance with the License.
6// You may obtain a copy of the License at
7//
8// http://www.apache.org/licenses/LICENSE-2.0
9//
10// Unless required by applicable law or agreed to in writing, software
11// distributed under the License is distributed on an "AS IS" BASIS,
12// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13// See the License for the specific language governing permissions and
14// limitations under the License.
15//
Darin Petkov6a5b3222010-07-13 14:55:28 -070016
Alex Deymo8427b4a2014-11-05 14:00:32 -080017#include "update_engine/omaha_request_action.h"
18
Ben Chan9abb7632014-08-07 00:10:53 -070019#include <stdint.h>
20
Darin Petkov6a5b3222010-07-13 14:55:28 -070021#include <string>
22#include <vector>
Darin Petkov0dc8e9a2010-07-14 14:51:57 -070023
Alex Deymo60ca1a72015-06-18 18:19:15 -070024#include <base/bind.h>
Alex Deymo8e18f932015-03-27 16:16:59 -070025#include <base/strings/string_number_conversions.h>
Alex Vakulenko75039d72014-03-25 12:36:28 -070026#include <base/strings/string_util.h>
27#include <base/strings/stringprintf.h>
28#include <base/time/time.h>
Alex Deymo60ca1a72015-06-18 18:19:15 -070029#include <chromeos/bind_lambda.h>
Alex Deymo60ca1a72015-06-18 18:19:15 -070030#include <chromeos/message_loops/fake_message_loop.h>
31#include <chromeos/message_loops/message_loop.h>
32#include <chromeos/message_loops/message_loop_utils.h>
Alex Deymoe1e3afe2014-10-30 13:02:49 -070033#include <gtest/gtest.h>
Jay Srinivasand29695d2013-04-08 15:08:05 -070034
Darin Petkov6a5b3222010-07-13 14:55:28 -070035#include "update_engine/action_pipe.h"
Jay Srinivasand29695d2013-04-08 15:08:05 -070036#include "update_engine/constants.h"
Alex Deymoe1e3afe2014-10-30 13:02:49 -070037#include "update_engine/fake_prefs.h"
Chris Sosa77f79e82014-06-02 18:16:24 -070038#include "update_engine/mock_connection_manager.h"
Darin Petkov6a5b3222010-07-13 14:55:28 -070039#include "update_engine/mock_http_fetcher.h"
Gilad Arnold74b5f552014-10-07 08:17:16 -070040#include "update_engine/mock_payload_state.h"
Darin Petkov6a5b3222010-07-13 14:55:28 -070041#include "update_engine/omaha_hash_calculator.h"
Darin Petkova4a8a8c2010-07-15 22:21:12 -070042#include "update_engine/omaha_request_params.h"
Jay Srinivasan480ddfa2012-06-01 19:15:26 -070043#include "update_engine/prefs.h"
Darin Petkov6a5b3222010-07-13 14:55:28 -070044#include "update_engine/test_utils.h"
Jay Srinivasan480ddfa2012-06-01 19:15:26 -070045#include "update_engine/utils.h"
Darin Petkov6a5b3222010-07-13 14:55:28 -070046
Darin Petkov1cbd78f2010-07-29 12:38:34 -070047using base::Time;
48using base::TimeDelta;
Alex Deymo10875d92014-11-10 21:52:57 -080049using chromeos_update_engine::test_utils::System;
50using chromeos_update_engine::test_utils::WriteFileString;
Darin Petkov6a5b3222010-07-13 14:55:28 -070051using std::string;
52using std::vector;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070053using testing::AllOf;
Alex Deymof329b932014-10-30 01:37:48 -070054using testing::AnyNumber;
Jay Srinivasan34b5d862012-07-23 11:43:22 -070055using testing::DoAll;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070056using testing::Ge;
57using testing::Le;
Darin Petkov9c096d62010-11-17 14:49:04 -080058using testing::NiceMock;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070059using testing::Return;
Gilad Arnold74b5f552014-10-07 08:17:16 -070060using testing::ReturnPointee;
61using testing::SaveArg;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070062using testing::SetArgumentPointee;
Alex Deymof329b932014-10-30 01:37:48 -070063using testing::_;
Darin Petkov6a5b3222010-07-13 14:55:28 -070064
Alex Deymo8e18f932015-03-27 16:16:59 -070065namespace {
66
67// This is a helper struct to allow unit tests build an update response with the
68// values they care about.
69struct FakeUpdateResponse {
70 string GetNoUpdateResponse() const {
71 string entity_str;
72 if (include_entity)
73 entity_str = "<!DOCTYPE response [<!ENTITY CrOS \"ChromeOS\">]>";
Alex Deymo00d79ac2015-06-29 15:41:49 -070074 return
75 "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" +
76 entity_str + "<response protocol=\"3.0\">"
Alex Deymo8e18f932015-03-27 16:16:59 -070077 "<daystart elapsed_seconds=\"100\"/>"
Alex Deymo00d79ac2015-06-29 15:41:49 -070078 "<app appid=\"" + app_id + "\" " +
79 (include_cohorts ? "cohort=\"" + cohort + "\" cohorthint=\"" +
80 cohorthint + "\" cohortname=\"" + cohortname + "\" " : "") +
81 " status=\"ok\">"
82 "<ping status=\"ok\"/>"
83 "<updatecheck status=\"noupdate\"/></app></response>";
Alex Deymo8e18f932015-03-27 16:16:59 -070084 }
85
86 string GetUpdateResponse() const {
87 return
88 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
89 "protocol=\"3.0\">"
90 "<daystart elapsed_seconds=\"100\"" +
91 (elapsed_days.empty() ? "" : (" elapsed_days=\"" + elapsed_days + "\""))
92 + "/>"
93 "<app appid=\"" + app_id + "\" " +
94 (include_cohorts ? "cohort=\"" + cohort + "\" cohorthint=\"" +
95 cohorthint + "\" cohortname=\"" + cohortname + "\" " : "") +
96 " status=\"ok\">"
97 "<ping status=\"ok\"/><updatecheck status=\"ok\">"
98 "<urls><url codebase=\"" + codebase + "\"/></urls>"
99 "<manifest version=\"" + version + "\">"
100 "<packages><package hash=\"not-used\" name=\"" + filename + "\" "
101 "size=\"" + base::Int64ToString(size) + "\"/></packages>"
102 "<actions><action event=\"postinstall\" "
103 "ChromeOSVersion=\"" + version + "\" "
104 "MoreInfo=\"" + more_info_url + "\" Prompt=\"" + prompt + "\" "
105 "IsDelta=\"true\" "
106 "IsDeltaPayload=\"true\" "
107 "MaxDaysToScatter=\"" + max_days_to_scatter + "\" "
108 "sha256=\"" + hash + "\" "
109 "needsadmin=\"" + needsadmin + "\" " +
110 (deadline.empty() ? "" : ("deadline=\"" + deadline + "\" ")) +
111 (disable_p2p_for_downloading ?
112 "DisableP2PForDownloading=\"true\" " : "") +
113 (disable_p2p_for_sharing ? "DisableP2PForSharing=\"true\" " : "") +
114 "/></actions></manifest></updatecheck></app></response>";
115 }
116
117 // Return the payload URL, which is split in two fields in the XML response.
118 string GetPayloadUrl() {
119 return codebase + filename;
120 }
121
122 string app_id = chromeos_update_engine::OmahaRequestParams::kAppId;
123 string version = "1.2.3.4";
124 string more_info_url = "http://more/info";
125 string prompt = "true";
126 string codebase = "http://code/base/";
127 string filename = "file.signed";
128 string hash = "HASH1234=";
129 string needsadmin = "false";
130 int64_t size = 123;
131 string deadline = "";
132 string max_days_to_scatter = "7";
133 string elapsed_days = "42";
134
135 // P2P setting defaults to allowed.
136 bool disable_p2p_for_downloading = false;
137 bool disable_p2p_for_sharing = false;
138
139 // Omaha cohorts settings.
140 bool include_cohorts = false;
141 string cohort = "";
142 string cohorthint = "";
143 string cohortname = "";
144
145 // Whether to include the CrOS <!ENTITY> in the XML response.
146 bool include_entity = false;
147};
148
149} // namespace
150
Darin Petkov6a5b3222010-07-13 14:55:28 -0700151namespace chromeos_update_engine {
152
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700153class OmahaRequestActionTest : public ::testing::Test {
154 protected:
Alex Deymo610277e2014-11-11 21:18:11 -0800155 void SetUp() override {
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700156 fake_system_state_.set_request_params(&request_params_);
157 fake_system_state_.set_prefs(&fake_prefs_);
158 }
159
160 // Returns true iff an output response was obtained from the
Alex Deymo8427b4a2014-11-05 14:00:32 -0800161 // OmahaRequestAction. |prefs| may be null, in which case a local MockPrefs
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700162 // is used. |payload_state| may be null, in which case a local mock is used.
163 // |p2p_manager| may be null, in which case a local mock is used.
164 // |connection_manager| may be null, in which case a local mock is used.
165 // out_response may be null. If |fail_http_response_code| is non-negative,
166 // the transfer will fail with that code. |ping_only| is passed through to the
167 // OmahaRequestAction constructor. out_post_data may be null; if non-null, the
168 // post-data received by the mock HttpFetcher is returned.
169 //
170 // The |expected_check_result|, |expected_check_reaction| and
171 // |expected_error_code| parameters are for checking expectations
172 // about reporting UpdateEngine.Check.{Result,Reaction,DownloadError}
173 // UMA statistics. Use the appropriate ::kUnset value to specify that
174 // the given metric should not be reported.
175 bool TestUpdateCheck(OmahaRequestParams* request_params,
176 const string& http_response,
177 int fail_http_response_code,
178 bool ping_only,
179 ErrorCode expected_code,
180 metrics::CheckResult expected_check_result,
181 metrics::CheckReaction expected_check_reaction,
182 metrics::DownloadErrorCode expected_download_error_code,
183 OmahaResponse* out_response,
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -0800184 chromeos::Blob* out_post_data);
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700185
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -0800186 // Runs and checks a ping test. |ping_only| indicates whether it should send
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700187 // only a ping or also an updatecheck.
188 void PingTest(bool ping_only);
189
190 // InstallDate test helper function.
Alex Deymof329b932014-10-30 01:37:48 -0700191 bool InstallDateParseHelper(const string &elapsed_days,
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700192 OmahaResponse *response);
193
194 // P2P test helper function.
195 void P2PTest(
196 bool initial_allow_p2p_for_downloading,
197 bool initial_allow_p2p_for_sharing,
198 bool omaha_disable_p2p_for_downloading,
199 bool omaha_disable_p2p_for_sharing,
200 bool payload_state_allow_p2p_attempt,
201 bool expect_p2p_client_lookup,
202 const string& p2p_client_result_url,
203 bool expected_allow_p2p_for_downloading,
204 bool expected_allow_p2p_for_sharing,
205 const string& expected_p2p_url);
206
207 FakeSystemState fake_system_state_;
Alex Deymo8e18f932015-03-27 16:16:59 -0700208 FakeUpdateResponse fake_update_response_;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700209
210 // By default, all tests use these objects unless they replace them in the
211 // fake_system_state_.
212 OmahaRequestParams request_params_ = OmahaRequestParams{
213 &fake_system_state_,
214 OmahaRequestParams::kOsPlatform,
215 OmahaRequestParams::kOsVersion,
216 "service_pack",
217 "x86-generic",
218 OmahaRequestParams::kAppId,
219 "0.1.0.0",
220 "en-US",
221 "unittest",
222 "OEM MODEL 09235 7471",
223 "ChromeOSFirmware.1.0",
224 "0X0A1",
225 false, // delta okay
226 false, // interactive
227 "http://url",
Gilad Arnold74b5f552014-10-07 08:17:16 -0700228 ""}; // target_version_prefix
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700229
230 FakePrefs fake_prefs_;
231};
Darin Petkov6a5b3222010-07-13 14:55:28 -0700232
233namespace {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700234class OmahaRequestActionTestProcessorDelegate : public ActionProcessorDelegate {
235 public:
236 OmahaRequestActionTestProcessorDelegate()
Alex Deymo60ca1a72015-06-18 18:19:15 -0700237 : expected_code_(ErrorCode::kSuccess) {}
Alex Deymo610277e2014-11-11 21:18:11 -0800238 ~OmahaRequestActionTestProcessorDelegate() override {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700239 }
Yunlian Jiang35866ed2015-01-29 13:09:20 -0800240 void ProcessingDone(const ActionProcessor* processor,
241 ErrorCode code) override {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700242 chromeos::MessageLoop::current()->BreakLoop();
Darin Petkov6a5b3222010-07-13 14:55:28 -0700243 }
244
Yunlian Jiang35866ed2015-01-29 13:09:20 -0800245 void ActionCompleted(ActionProcessor* processor,
246 AbstractAction* action,
247 ErrorCode code) override {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700248 // make sure actions always succeed
249 if (action->Type() == OmahaRequestAction::StaticType())
Darin Petkovc1a8b422010-07-19 11:34:49 -0700250 EXPECT_EQ(expected_code_, code);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700251 else
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700252 EXPECT_EQ(ErrorCode::kSuccess, code);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700253 }
David Zeuthena99981f2013-04-29 13:42:47 -0700254 ErrorCode expected_code_;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700255};
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700256} // namespace
Darin Petkov6a5b3222010-07-13 14:55:28 -0700257
258class OutputObjectCollectorAction;
259
260template<>
261class ActionTraits<OutputObjectCollectorAction> {
262 public:
263 // Does not take an object for input
264 typedef OmahaResponse InputObjectType;
265 // On success, puts the output path on output
266 typedef NoneType OutputObjectType;
267};
268
269class OutputObjectCollectorAction : public Action<OutputObjectCollectorAction> {
270 public:
271 OutputObjectCollectorAction() : has_input_object_(false) {}
272 void PerformAction() {
273 // copy input object
274 has_input_object_ = HasInputObject();
275 if (has_input_object_)
276 omaha_response_ = GetInputObject();
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700277 processor_->ActionComplete(this, ErrorCode::kSuccess);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700278 }
279 // Should never be called
280 void TerminateProcessing() {
281 CHECK(false);
282 }
283 // Debugging/logging
Alex Deymof329b932014-10-30 01:37:48 -0700284 static string StaticType() {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700285 return "OutputObjectCollectorAction";
286 }
Alex Deymof329b932014-10-30 01:37:48 -0700287 string Type() const { return StaticType(); }
Darin Petkov6a5b3222010-07-13 14:55:28 -0700288 bool has_input_object_;
289 OmahaResponse omaha_response_;
290};
291
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700292bool OmahaRequestActionTest::TestUpdateCheck(
293 OmahaRequestParams* request_params,
294 const string& http_response,
295 int fail_http_response_code,
296 bool ping_only,
297 ErrorCode expected_code,
298 metrics::CheckResult expected_check_result,
299 metrics::CheckReaction expected_check_reaction,
300 metrics::DownloadErrorCode expected_download_error_code,
301 OmahaResponse* out_response,
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -0800302 chromeos::Blob* out_post_data) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700303 chromeos::FakeMessageLoop loop(nullptr);
304 loop.SetAsCurrent();
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700305 MockHttpFetcher* fetcher = new MockHttpFetcher(http_response.data(),
Andrew de los Reyes45168102010-11-22 11:13:50 -0800306 http_response.size(),
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700307 nullptr);
Darin Petkovedc522e2010-11-05 09:35:17 -0700308 if (fail_http_response_code >= 0) {
309 fetcher->FailTransfer(fail_http_response_code);
310 }
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700311 if (request_params)
312 fake_system_state_.set_request_params(request_params);
313 OmahaRequestAction action(&fake_system_state_,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700314 nullptr,
Thieu Le116fda32011-04-19 11:01:54 -0700315 fetcher,
Darin Petkov265f2902011-05-09 15:17:40 -0700316 ping_only);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700317 OmahaRequestActionTestProcessorDelegate delegate;
Darin Petkovc1a8b422010-07-19 11:34:49 -0700318 delegate.expected_code_ = expected_code;
Darin Petkova4a8a8c2010-07-15 22:21:12 -0700319
Darin Petkov6a5b3222010-07-13 14:55:28 -0700320 ActionProcessor processor;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700321 processor.set_delegate(&delegate);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700322 processor.EnqueueAction(&action);
323
324 OutputObjectCollectorAction collector_action;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700325 BondActions(&action, &collector_action);
326 processor.EnqueueAction(&collector_action);
327
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700328 EXPECT_CALL(*fake_system_state_.mock_metrics_lib(), SendEnumToUMA(_, _, _))
David Zeuthen33bae492014-02-25 16:16:18 -0800329 .Times(AnyNumber());
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700330 EXPECT_CALL(*fake_system_state_.mock_metrics_lib(),
David Zeuthen33bae492014-02-25 16:16:18 -0800331 SendEnumToUMA(metrics::kMetricCheckResult,
332 static_cast<int>(expected_check_result),
333 static_cast<int>(metrics::CheckResult::kNumConstants) - 1))
334 .Times(expected_check_result == metrics::CheckResult::kUnset ? 0 : 1);
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700335 EXPECT_CALL(*fake_system_state_.mock_metrics_lib(),
David Zeuthen33bae492014-02-25 16:16:18 -0800336 SendEnumToUMA(metrics::kMetricCheckReaction,
337 static_cast<int>(expected_check_reaction),
338 static_cast<int>(metrics::CheckReaction::kNumConstants) - 1))
339 .Times(expected_check_reaction == metrics::CheckReaction::kUnset ? 0 : 1);
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700340 EXPECT_CALL(*fake_system_state_.mock_metrics_lib(),
David Zeuthenc0dd0212014-04-04 14:49:49 -0700341 SendSparseToUMA(metrics::kMetricCheckDownloadErrorCode,
342 static_cast<int>(expected_download_error_code)))
David Zeuthen33bae492014-02-25 16:16:18 -0800343 .Times(expected_download_error_code == metrics::DownloadErrorCode::kUnset
344 ? 0 : 1);
345
Alex Deymo60ca1a72015-06-18 18:19:15 -0700346 loop.PostTask(base::Bind([&processor] { processor.StartProcessing(); }));
347 LOG(INFO) << "loop.PendingTasks() = " << loop.PendingTasks();
348 loop.Run();
349 LOG(INFO) << "loop.PendingTasks() = " << loop.PendingTasks();
350 EXPECT_FALSE(loop.PendingTasks());
Darin Petkov6a5b3222010-07-13 14:55:28 -0700351 if (collector_action.has_input_object_ && out_response)
352 *out_response = collector_action.omaha_response_;
353 if (out_post_data)
354 *out_post_data = fetcher->post_data();
355 return collector_action.has_input_object_;
356}
357
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700358// Tests Event requests -- they should always succeed. |out_post_data|
359// may be null; if non-null, the post-data received by the mock
360// HttpFetcher is returned.
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700361void TestEvent(OmahaRequestParams params,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700362 OmahaEvent* event,
363 const string& http_response,
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -0800364 chromeos::Blob* out_post_data) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700365 chromeos::FakeMessageLoop loop(nullptr);
366 loop.SetAsCurrent();
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700367 MockHttpFetcher* fetcher = new MockHttpFetcher(http_response.data(),
Andrew de los Reyes45168102010-11-22 11:13:50 -0800368 http_response.size(),
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700369 nullptr);
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700370 FakeSystemState fake_system_state;
371 fake_system_state.set_request_params(&params);
372 OmahaRequestAction action(&fake_system_state, event, fetcher, false);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700373 OmahaRequestActionTestProcessorDelegate delegate;
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700374 ActionProcessor processor;
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700375 processor.set_delegate(&delegate);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700376 processor.EnqueueAction(&action);
377
Alex Deymo60ca1a72015-06-18 18:19:15 -0700378 loop.PostTask(base::Bind([&processor] { processor.StartProcessing(); }));
379 loop.Run();
380
381 // This test should schedule a callback to notify the crash reporter if
382 // the passed event is an error.
383 EXPECT_EQ(event->result == OmahaEvent::kResultError, loop.PendingTasks());
384
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700385 if (out_post_data)
386 *out_post_data = fetcher->post_data();
387}
388
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700389TEST_F(OmahaRequestActionTest, RejectEntities) {
David Zeuthenf3e28012014-08-26 18:23:52 -0400390 OmahaResponse response;
Alex Deymo8e18f932015-03-27 16:16:59 -0700391 fake_update_response_.include_entity = true;
David Zeuthenf3e28012014-08-26 18:23:52 -0400392 ASSERT_FALSE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700393 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -0700394 fake_update_response_.GetNoUpdateResponse(),
David Zeuthenf3e28012014-08-26 18:23:52 -0400395 -1,
396 false, // ping_only
397 ErrorCode::kOmahaRequestXMLHasEntityDecl,
398 metrics::CheckResult::kParsingError,
399 metrics::CheckReaction::kUnset,
400 metrics::DownloadErrorCode::kUnset,
401 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700402 nullptr));
David Zeuthenf3e28012014-08-26 18:23:52 -0400403 EXPECT_FALSE(response.update_exists);
404}
405
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700406TEST_F(OmahaRequestActionTest, NoUpdateTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700407 OmahaResponse response;
408 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700409 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -0700410 fake_update_response_.GetNoUpdateResponse(),
Darin Petkovedc522e2010-11-05 09:35:17 -0700411 -1,
Darin Petkov265f2902011-05-09 15:17:40 -0700412 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700413 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -0800414 metrics::CheckResult::kNoUpdateAvailable,
415 metrics::CheckReaction::kUnset,
416 metrics::DownloadErrorCode::kUnset,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700417 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700418 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700419 EXPECT_FALSE(response.update_exists);
420}
421
Alex Deymo8e18f932015-03-27 16:16:59 -0700422// Test that all the values in the response are parsed in a normal update
423// response.
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700424TEST_F(OmahaRequestActionTest, ValidUpdateTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700425 OmahaResponse response;
Alex Deymo8e18f932015-03-27 16:16:59 -0700426 fake_update_response_.deadline = "20101020";
Darin Petkov6a5b3222010-07-13 14:55:28 -0700427 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700428 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -0700429 fake_update_response_.GetUpdateResponse(),
Darin Petkovedc522e2010-11-05 09:35:17 -0700430 -1,
Darin Petkov265f2902011-05-09 15:17:40 -0700431 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700432 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -0800433 metrics::CheckResult::kUpdateAvailable,
434 metrics::CheckReaction::kUpdating,
435 metrics::DownloadErrorCode::kUnset,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700436 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700437 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700438 EXPECT_TRUE(response.update_exists);
Jay Srinivasan34b5d862012-07-23 11:43:22 -0700439 EXPECT_TRUE(response.update_exists);
Alex Deymo8e18f932015-03-27 16:16:59 -0700440 EXPECT_EQ(fake_update_response_.version, response.version);
441 EXPECT_EQ(fake_update_response_.GetPayloadUrl(), response.payload_urls[0]);
442 EXPECT_EQ(fake_update_response_.more_info_url, response.more_info_url);
443 EXPECT_EQ(fake_update_response_.hash, response.hash);
444 EXPECT_EQ(fake_update_response_.size, response.size);
445 EXPECT_EQ(fake_update_response_.prompt == "true", response.prompt);
446 EXPECT_EQ(fake_update_response_.deadline, response.deadline);
447 // Omaha cohort attribets are not set in the response, so they should not be
448 // persisted.
449 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohort));
450 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohortHint));
451 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohortName));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700452}
453
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700454TEST_F(OmahaRequestActionTest, ValidUpdateBlockedByConnection) {
Chris Sosa77f79e82014-06-02 18:16:24 -0700455 OmahaResponse response;
456 // Set up a connection manager that doesn't allow a valid update over
457 // the current ethernet connection.
Alex Deymof6ee0162015-07-31 12:35:22 -0700458 MockConnectionManager mock_cm;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700459 fake_system_state_.set_connection_manager(&mock_cm);
460
Alex Deymo30534502015-07-20 15:06:33 -0700461 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
462 .WillRepeatedly(
463 DoAll(SetArgumentPointee<0>(NetworkConnectionType::kEthernet),
464 SetArgumentPointee<1>(NetworkTethering::kUnknown),
465 Return(true)));
Alex Deymo75eac7e2015-07-29 13:39:14 -0700466 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(NetworkConnectionType::kEthernet, _))
Chris Sosa77f79e82014-06-02 18:16:24 -0700467 .WillRepeatedly(Return(false));
Chris Sosa77f79e82014-06-02 18:16:24 -0700468
469 ASSERT_FALSE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700470 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -0700471 fake_update_response_.GetUpdateResponse(),
Chris Sosa77f79e82014-06-02 18:16:24 -0700472 -1,
473 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700474 ErrorCode::kOmahaUpdateIgnoredPerPolicy,
Chris Sosa77f79e82014-06-02 18:16:24 -0700475 metrics::CheckResult::kUpdateAvailable,
476 metrics::CheckReaction::kIgnored,
477 metrics::DownloadErrorCode::kUnset,
478 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700479 nullptr));
Chris Sosa77f79e82014-06-02 18:16:24 -0700480 EXPECT_FALSE(response.update_exists);
481}
482
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700483TEST_F(OmahaRequestActionTest, ValidUpdateBlockedByRollback) {
Chris Sosa77f79e82014-06-02 18:16:24 -0700484 string rollback_version = "1234.0.0";
485 OmahaResponse response;
486
487 MockPayloadState mock_payload_state;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700488 fake_system_state_.set_payload_state(&mock_payload_state);
489
Chris Sosa77f79e82014-06-02 18:16:24 -0700490 EXPECT_CALL(mock_payload_state, GetRollbackVersion())
491 .WillRepeatedly(Return(rollback_version));
492
Alex Deymo8e18f932015-03-27 16:16:59 -0700493 fake_update_response_.version = rollback_version;
Chris Sosa77f79e82014-06-02 18:16:24 -0700494 ASSERT_FALSE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700495 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -0700496 fake_update_response_.GetUpdateResponse(),
Chris Sosa77f79e82014-06-02 18:16:24 -0700497 -1,
498 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700499 ErrorCode::kOmahaUpdateIgnoredPerPolicy,
Chris Sosa77f79e82014-06-02 18:16:24 -0700500 metrics::CheckResult::kUpdateAvailable,
501 metrics::CheckReaction::kIgnored,
502 metrics::DownloadErrorCode::kUnset,
503 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700504 nullptr));
Chris Sosa77f79e82014-06-02 18:16:24 -0700505 EXPECT_FALSE(response.update_exists);
506}
507
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700508TEST_F(OmahaRequestActionTest, WallClockBasedWaitAloneCausesScattering) {
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700509 OmahaResponse response;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700510 OmahaRequestParams params = request_params_;
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700511 params.set_wall_clock_based_wait_enabled(true);
512 params.set_update_check_count_wait_enabled(false);
513 params.set_waiting_period(TimeDelta::FromDays(2));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700514
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700515 ASSERT_FALSE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700516 TestUpdateCheck(&params,
Alex Deymo8e18f932015-03-27 16:16:59 -0700517 fake_update_response_.GetUpdateResponse(),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700518 -1,
519 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700520 ErrorCode::kOmahaUpdateDeferredPerPolicy,
David Zeuthen33bae492014-02-25 16:16:18 -0800521 metrics::CheckResult::kUpdateAvailable,
522 metrics::CheckReaction::kDeferring,
523 metrics::DownloadErrorCode::kUnset,
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700524 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700525 nullptr));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700526 EXPECT_FALSE(response.update_exists);
Chris Sosa968d0572013-08-23 14:46:02 -0700527
528 // Verify if we are interactive check we don't defer.
529 params.set_interactive(true);
530 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700531 TestUpdateCheck(&params,
Alex Deymo8e18f932015-03-27 16:16:59 -0700532 fake_update_response_.GetUpdateResponse(),
Chris Sosa968d0572013-08-23 14:46:02 -0700533 -1,
534 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700535 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -0800536 metrics::CheckResult::kUpdateAvailable,
537 metrics::CheckReaction::kUpdating,
538 metrics::DownloadErrorCode::kUnset,
Chris Sosa968d0572013-08-23 14:46:02 -0700539 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700540 nullptr));
Chris Sosa968d0572013-08-23 14:46:02 -0700541 EXPECT_TRUE(response.update_exists);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700542}
543
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700544TEST_F(OmahaRequestActionTest, NoWallClockBasedWaitCausesNoScattering) {
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700545 OmahaResponse response;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700546 OmahaRequestParams params = request_params_;
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700547 params.set_wall_clock_based_wait_enabled(false);
548 params.set_waiting_period(TimeDelta::FromDays(2));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700549
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700550 params.set_update_check_count_wait_enabled(true);
551 params.set_min_update_checks_needed(1);
552 params.set_max_update_checks_allowed(8);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700553
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700554 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700555 TestUpdateCheck(&params,
Alex Deymo8e18f932015-03-27 16:16:59 -0700556 fake_update_response_.GetUpdateResponse(),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700557 -1,
558 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700559 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -0800560 metrics::CheckResult::kUpdateAvailable,
561 metrics::CheckReaction::kUpdating,
562 metrics::DownloadErrorCode::kUnset,
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700563 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700564 nullptr));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700565 EXPECT_TRUE(response.update_exists);
566}
567
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700568TEST_F(OmahaRequestActionTest, ZeroMaxDaysToScatterCausesNoScattering) {
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700569 OmahaResponse response;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700570 OmahaRequestParams params = request_params_;
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700571 params.set_wall_clock_based_wait_enabled(true);
572 params.set_waiting_period(TimeDelta::FromDays(2));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700573
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700574 params.set_update_check_count_wait_enabled(true);
575 params.set_min_update_checks_needed(1);
576 params.set_max_update_checks_allowed(8);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700577
Alex Deymo8e18f932015-03-27 16:16:59 -0700578 fake_update_response_.max_days_to_scatter = "0";
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700579 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700580 TestUpdateCheck(&params,
Alex Deymo8e18f932015-03-27 16:16:59 -0700581 fake_update_response_.GetUpdateResponse(),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700582 -1,
583 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700584 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -0800585 metrics::CheckResult::kUpdateAvailable,
586 metrics::CheckReaction::kUpdating,
587 metrics::DownloadErrorCode::kUnset,
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700588 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700589 nullptr));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700590 EXPECT_TRUE(response.update_exists);
591}
592
593
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700594TEST_F(OmahaRequestActionTest, ZeroUpdateCheckCountCausesNoScattering) {
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700595 OmahaResponse response;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700596 OmahaRequestParams params = request_params_;
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700597 params.set_wall_clock_based_wait_enabled(true);
598 params.set_waiting_period(TimeDelta());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700599
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700600 params.set_update_check_count_wait_enabled(true);
601 params.set_min_update_checks_needed(0);
602 params.set_max_update_checks_allowed(0);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700603
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700604 ASSERT_TRUE(TestUpdateCheck(
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700605 &params,
Alex Deymo8e18f932015-03-27 16:16:59 -0700606 fake_update_response_.GetUpdateResponse(),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700607 -1,
608 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700609 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -0800610 metrics::CheckResult::kUpdateAvailable,
611 metrics::CheckReaction::kUpdating,
612 metrics::DownloadErrorCode::kUnset,
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700613 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700614 nullptr));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700615
Ben Chan9abb7632014-08-07 00:10:53 -0700616 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700617 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700618 ASSERT_EQ(count, 0);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700619 EXPECT_TRUE(response.update_exists);
620}
621
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700622TEST_F(OmahaRequestActionTest, NonZeroUpdateCheckCountCausesScattering) {
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700623 OmahaResponse response;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700624 OmahaRequestParams params = request_params_;
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700625 params.set_wall_clock_based_wait_enabled(true);
626 params.set_waiting_period(TimeDelta());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700627
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700628 params.set_update_check_count_wait_enabled(true);
629 params.set_min_update_checks_needed(1);
630 params.set_max_update_checks_allowed(8);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700631
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700632 ASSERT_FALSE(TestUpdateCheck(
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700633 &params,
Alex Deymo8e18f932015-03-27 16:16:59 -0700634 fake_update_response_.GetUpdateResponse(),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700635 -1,
636 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700637 ErrorCode::kOmahaUpdateDeferredPerPolicy,
David Zeuthen33bae492014-02-25 16:16:18 -0800638 metrics::CheckResult::kUpdateAvailable,
639 metrics::CheckReaction::kDeferring,
640 metrics::DownloadErrorCode::kUnset,
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700641 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700642 nullptr));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700643
Ben Chan9abb7632014-08-07 00:10:53 -0700644 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700645 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700646 ASSERT_GT(count, 0);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700647 EXPECT_FALSE(response.update_exists);
Chris Sosa968d0572013-08-23 14:46:02 -0700648
649 // Verify if we are interactive check we don't defer.
650 params.set_interactive(true);
651 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700652 TestUpdateCheck(&params,
Alex Deymo8e18f932015-03-27 16:16:59 -0700653 fake_update_response_.GetUpdateResponse(),
Chris Sosa968d0572013-08-23 14:46:02 -0700654 -1,
655 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700656 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -0800657 metrics::CheckResult::kUpdateAvailable,
658 metrics::CheckReaction::kUpdating,
659 metrics::DownloadErrorCode::kUnset,
Chris Sosa968d0572013-08-23 14:46:02 -0700660 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700661 nullptr));
Chris Sosa968d0572013-08-23 14:46:02 -0700662 EXPECT_TRUE(response.update_exists);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700663}
664
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700665TEST_F(OmahaRequestActionTest, ExistingUpdateCheckCountCausesScattering) {
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700666 OmahaResponse response;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700667 OmahaRequestParams params = request_params_;
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700668 params.set_wall_clock_based_wait_enabled(true);
669 params.set_waiting_period(TimeDelta());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700670
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700671 params.set_update_check_count_wait_enabled(true);
672 params.set_min_update_checks_needed(1);
673 params.set_max_update_checks_allowed(8);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700674
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700675 ASSERT_TRUE(fake_prefs_.SetInt64(kPrefsUpdateCheckCount, 5));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700676
677 ASSERT_FALSE(TestUpdateCheck(
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700678 &params,
Alex Deymo8e18f932015-03-27 16:16:59 -0700679 fake_update_response_.GetUpdateResponse(),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700680 -1,
681 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700682 ErrorCode::kOmahaUpdateDeferredPerPolicy,
David Zeuthen33bae492014-02-25 16:16:18 -0800683 metrics::CheckResult::kUpdateAvailable,
684 metrics::CheckReaction::kDeferring,
685 metrics::DownloadErrorCode::kUnset,
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700686 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700687 nullptr));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700688
Ben Chan9abb7632014-08-07 00:10:53 -0700689 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700690 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700691 // count remains the same, as the decrementing happens in update_attempter
692 // which this test doesn't exercise.
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700693 ASSERT_EQ(count, 5);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700694 EXPECT_FALSE(response.update_exists);
Chris Sosa968d0572013-08-23 14:46:02 -0700695
696 // Verify if we are interactive check we don't defer.
697 params.set_interactive(true);
698 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700699 TestUpdateCheck(&params,
Alex Deymo8e18f932015-03-27 16:16:59 -0700700 fake_update_response_.GetUpdateResponse(),
Chris Sosa968d0572013-08-23 14:46:02 -0700701 -1,
702 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700703 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -0800704 metrics::CheckResult::kUpdateAvailable,
705 metrics::CheckReaction::kUpdating,
706 metrics::DownloadErrorCode::kUnset,
Chris Sosa968d0572013-08-23 14:46:02 -0700707 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700708 nullptr));
Chris Sosa968d0572013-08-23 14:46:02 -0700709 EXPECT_TRUE(response.update_exists);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700710}
Jay Srinivasan0a708742012-03-20 11:26:12 -0700711
Alex Deymo8e18f932015-03-27 16:16:59 -0700712TEST_F(OmahaRequestActionTest, CohortsArePersisted) {
713 OmahaResponse response;
714 OmahaRequestParams params = request_params_;
715 fake_update_response_.include_cohorts = true;
716 fake_update_response_.cohort = "s/154454/8479665";
717 fake_update_response_.cohorthint = "please-put-me-on-beta";
718 fake_update_response_.cohortname = "stable";
719
720 ASSERT_TRUE(TestUpdateCheck(&params,
721 fake_update_response_.GetUpdateResponse(),
722 -1,
723 false, // ping_only
724 ErrorCode::kSuccess,
725 metrics::CheckResult::kUpdateAvailable,
726 metrics::CheckReaction::kUpdating,
727 metrics::DownloadErrorCode::kUnset,
728 &response,
729 nullptr));
730
731 string value;
732 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
733 EXPECT_EQ(fake_update_response_.cohort, value);
734
735 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
736 EXPECT_EQ(fake_update_response_.cohorthint, value);
737
738 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
739 EXPECT_EQ(fake_update_response_.cohortname, value);
740}
741
742TEST_F(OmahaRequestActionTest, CohortsAreUpdated) {
743 OmahaResponse response;
744 OmahaRequestParams params = request_params_;
745 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohort, "old_value"));
746 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohortHint, "old_hint"));
747 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohortName, "old_name"));
748 fake_update_response_.include_cohorts = true;
749 fake_update_response_.cohort = "s/154454/8479665";
750 fake_update_response_.cohorthint = "please-put-me-on-beta";
751 fake_update_response_.cohortname = "";
752
753 ASSERT_TRUE(TestUpdateCheck(&params,
754 fake_update_response_.GetUpdateResponse(),
755 -1,
756 false, // ping_only
757 ErrorCode::kSuccess,
758 metrics::CheckResult::kUpdateAvailable,
759 metrics::CheckReaction::kUpdating,
760 metrics::DownloadErrorCode::kUnset,
761 &response,
762 nullptr));
763
764 string value;
765 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
766 EXPECT_EQ(fake_update_response_.cohort, value);
767
768 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
769 EXPECT_EQ(fake_update_response_.cohorthint, value);
770
771 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
772}
773
774TEST_F(OmahaRequestActionTest, CohortsAreNotModifiedWhenMissing) {
775 OmahaResponse response;
776 OmahaRequestParams params = request_params_;
777 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohort, "old_value"));
778
779 ASSERT_TRUE(TestUpdateCheck(&params,
780 fake_update_response_.GetUpdateResponse(),
781 -1,
782 false, // ping_only
783 ErrorCode::kSuccess,
784 metrics::CheckResult::kUpdateAvailable,
785 metrics::CheckReaction::kUpdating,
786 metrics::DownloadErrorCode::kUnset,
787 &response,
788 nullptr));
789
790 string value;
791 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
792 EXPECT_EQ("old_value", value);
793
794 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
795 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
796}
797
Alex Deymo00d79ac2015-06-29 15:41:49 -0700798TEST_F(OmahaRequestActionTest, CohortsArePersistedWhenNoUpdate) {
799 OmahaResponse response;
800 OmahaRequestParams params = request_params_;
801 fake_update_response_.include_cohorts = true;
802 fake_update_response_.cohort = "s/154454/8479665";
803 fake_update_response_.cohorthint = "please-put-me-on-beta";
804 fake_update_response_.cohortname = "stable";
805
806 ASSERT_TRUE(TestUpdateCheck(&params,
807 fake_update_response_.GetNoUpdateResponse(),
808 -1,
809 false, // ping_only
810 ErrorCode::kSuccess,
811 metrics::CheckResult::kNoUpdateAvailable,
812 metrics::CheckReaction::kUnset,
813 metrics::DownloadErrorCode::kUnset,
814 &response,
815 nullptr));
816
817 string value;
818 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
819 EXPECT_EQ(fake_update_response_.cohort, value);
820
821 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
822 EXPECT_EQ(fake_update_response_.cohorthint, value);
823
824 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
825 EXPECT_EQ(fake_update_response_.cohortname, value);
826}
827
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700828TEST_F(OmahaRequestActionTest, NoOutputPipeTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -0700829 const string http_response(fake_update_response_.GetNoUpdateResponse());
Darin Petkov6a5b3222010-07-13 14:55:28 -0700830
Alex Deymo60ca1a72015-06-18 18:19:15 -0700831 chromeos::FakeMessageLoop loop(nullptr);
832 loop.SetAsCurrent();
Darin Petkov6a5b3222010-07-13 14:55:28 -0700833
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700834 OmahaRequestParams params = request_params_;
835 fake_system_state_.set_request_params(&params);
836 OmahaRequestAction action(&fake_system_state_, nullptr,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700837 new MockHttpFetcher(http_response.data(),
Andrew de los Reyes45168102010-11-22 11:13:50 -0800838 http_response.size(),
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700839 nullptr),
Thieu Le116fda32011-04-19 11:01:54 -0700840 false);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700841 OmahaRequestActionTestProcessorDelegate delegate;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700842 ActionProcessor processor;
843 processor.set_delegate(&delegate);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700844 processor.EnqueueAction(&action);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700845
Alex Deymo60ca1a72015-06-18 18:19:15 -0700846 loop.PostTask(base::Bind([&processor] { processor.StartProcessing(); }));
847 loop.Run();
848 EXPECT_FALSE(loop.PendingTasks());
Darin Petkov6a5b3222010-07-13 14:55:28 -0700849 EXPECT_FALSE(processor.IsRunning());
850}
851
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700852TEST_F(OmahaRequestActionTest, InvalidXmlTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700853 OmahaResponse response;
854 ASSERT_FALSE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700855 TestUpdateCheck(nullptr, // request_params
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700856 "invalid xml>",
Darin Petkovedc522e2010-11-05 09:35:17 -0700857 -1,
Darin Petkov265f2902011-05-09 15:17:40 -0700858 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700859 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -0800860 metrics::CheckResult::kParsingError,
861 metrics::CheckReaction::kUnset,
862 metrics::DownloadErrorCode::kUnset,
Darin Petkovedc522e2010-11-05 09:35:17 -0700863 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700864 nullptr));
Darin Petkovedc522e2010-11-05 09:35:17 -0700865 EXPECT_FALSE(response.update_exists);
866}
867
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700868TEST_F(OmahaRequestActionTest, EmptyResponseTest) {
Darin Petkovedc522e2010-11-05 09:35:17 -0700869 OmahaResponse response;
870 ASSERT_FALSE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700871 TestUpdateCheck(nullptr, // request_params
Darin Petkovedc522e2010-11-05 09:35:17 -0700872 "",
873 -1,
Darin Petkov265f2902011-05-09 15:17:40 -0700874 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700875 ErrorCode::kOmahaRequestEmptyResponseError,
David Zeuthen33bae492014-02-25 16:16:18 -0800876 metrics::CheckResult::kParsingError,
877 metrics::CheckReaction::kUnset,
878 metrics::DownloadErrorCode::kUnset,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700879 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700880 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700881 EXPECT_FALSE(response.update_exists);
882}
883
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700884TEST_F(OmahaRequestActionTest, MissingStatusTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700885 OmahaResponse response;
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700886 ASSERT_FALSE(TestUpdateCheck(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700887 nullptr, // request_params
Jay Srinivasan23b92a52012-10-27 02:00:21 -0700888 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
889 "<daystart elapsed_seconds=\"100\"/>"
890 "<app appid=\"foo\" status=\"ok\">"
891 "<ping status=\"ok\"/>"
892 "<updatecheck/></app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -0700893 -1,
Darin Petkov265f2902011-05-09 15:17:40 -0700894 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700895 ErrorCode::kOmahaResponseInvalid,
David Zeuthen33bae492014-02-25 16:16:18 -0800896 metrics::CheckResult::kParsingError,
897 metrics::CheckReaction::kUnset,
898 metrics::DownloadErrorCode::kUnset,
Darin Petkov6a5b3222010-07-13 14:55:28 -0700899 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700900 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700901 EXPECT_FALSE(response.update_exists);
902}
903
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700904TEST_F(OmahaRequestActionTest, InvalidStatusTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700905 OmahaResponse response;
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700906 ASSERT_FALSE(TestUpdateCheck(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700907 nullptr, // request_params
Jay Srinivasan23b92a52012-10-27 02:00:21 -0700908 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
909 "<daystart elapsed_seconds=\"100\"/>"
910 "<app appid=\"foo\" status=\"ok\">"
911 "<ping status=\"ok\"/>"
912 "<updatecheck status=\"InvalidStatusTest\"/></app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -0700913 -1,
Darin Petkov265f2902011-05-09 15:17:40 -0700914 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700915 ErrorCode::kOmahaResponseInvalid,
David Zeuthen33bae492014-02-25 16:16:18 -0800916 metrics::CheckResult::kParsingError,
917 metrics::CheckReaction::kUnset,
918 metrics::DownloadErrorCode::kUnset,
Darin Petkov6a5b3222010-07-13 14:55:28 -0700919 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700920 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700921 EXPECT_FALSE(response.update_exists);
922}
923
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700924TEST_F(OmahaRequestActionTest, MissingNodesetTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700925 OmahaResponse response;
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700926 ASSERT_FALSE(TestUpdateCheck(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700927 nullptr, // request_params
Jay Srinivasan23b92a52012-10-27 02:00:21 -0700928 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
929 "<daystart elapsed_seconds=\"100\"/>"
930 "<app appid=\"foo\" status=\"ok\">"
931 "<ping status=\"ok\"/>"
932 "</app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -0700933 -1,
Darin Petkov265f2902011-05-09 15:17:40 -0700934 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700935 ErrorCode::kOmahaResponseInvalid,
David Zeuthen33bae492014-02-25 16:16:18 -0800936 metrics::CheckResult::kParsingError,
937 metrics::CheckReaction::kUnset,
938 metrics::DownloadErrorCode::kUnset,
Darin Petkov6a5b3222010-07-13 14:55:28 -0700939 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700940 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700941 EXPECT_FALSE(response.update_exists);
942}
943
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700944TEST_F(OmahaRequestActionTest, MissingFieldTest) {
Jay Srinivasan23b92a52012-10-27 02:00:21 -0700945 string input_response =
946 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
947 "<daystart elapsed_seconds=\"100\"/>"
948 "<app appid=\"xyz\" status=\"ok\">"
949 "<updatecheck status=\"ok\">"
950 "<urls><url codebase=\"http://missing/field/test/\"/></urls>"
Chris Sosa3b748432013-06-20 16:42:59 -0700951 "<manifest version=\"10.2.3.4\">"
Jay Srinivasan23b92a52012-10-27 02:00:21 -0700952 "<packages><package hash=\"not-used\" name=\"f\" "
953 "size=\"587\"/></packages>"
954 "<actions><action event=\"postinstall\" "
Jay Srinivasan23b92a52012-10-27 02:00:21 -0700955 "ChromeOSVersion=\"10.2.3.4\" "
956 "Prompt=\"false\" "
957 "IsDelta=\"true\" "
Jay Srinivasand671e972013-01-11 17:17:19 -0800958 "IsDeltaPayload=\"false\" "
Jay Srinivasan23b92a52012-10-27 02:00:21 -0700959 "sha256=\"lkq34j5345\" "
960 "needsadmin=\"true\" "
961 "/></actions></manifest></updatecheck></app></response>";
962 LOG(INFO) << "Input Response = " << input_response;
963
Darin Petkov6a5b3222010-07-13 14:55:28 -0700964 OmahaResponse response;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700965 ASSERT_TRUE(TestUpdateCheck(nullptr, // request_params
Jay Srinivasan23b92a52012-10-27 02:00:21 -0700966 input_response,
Darin Petkovedc522e2010-11-05 09:35:17 -0700967 -1,
Darin Petkov265f2902011-05-09 15:17:40 -0700968 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700969 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -0800970 metrics::CheckResult::kUpdateAvailable,
971 metrics::CheckReaction::kUpdating,
972 metrics::DownloadErrorCode::kUnset,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700973 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700974 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700975 EXPECT_TRUE(response.update_exists);
Chris Sosa3b748432013-06-20 16:42:59 -0700976 EXPECT_EQ("10.2.3.4", response.version);
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800977 EXPECT_EQ("http://missing/field/test/f", response.payload_urls[0]);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700978 EXPECT_EQ("", response.more_info_url);
Jay Srinivasan23b92a52012-10-27 02:00:21 -0700979 EXPECT_EQ("lkq34j5345", response.hash);
980 EXPECT_EQ(587, response.size);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700981 EXPECT_FALSE(response.prompt);
Darin Petkov6c118642010-10-21 12:06:30 -0700982 EXPECT_TRUE(response.deadline.empty());
Darin Petkov6a5b3222010-07-13 14:55:28 -0700983}
984
985namespace {
986class TerminateEarlyTestProcessorDelegate : public ActionProcessorDelegate {
987 public:
988 void ProcessingStopped(const ActionProcessor* processor) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700989 chromeos::MessageLoop::current()->BreakLoop();
Darin Petkov6a5b3222010-07-13 14:55:28 -0700990 }
Darin Petkov6a5b3222010-07-13 14:55:28 -0700991};
992
Alex Deymo60ca1a72015-06-18 18:19:15 -0700993void TerminateTransferTestStarter(ActionProcessor* processor) {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700994 processor->StartProcessing();
995 CHECK(processor->IsRunning());
996 processor->StopProcessing();
Darin Petkov6a5b3222010-07-13 14:55:28 -0700997}
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700998} // namespace
Darin Petkov6a5b3222010-07-13 14:55:28 -0700999
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001000TEST_F(OmahaRequestActionTest, TerminateTransferTest) {
Alex Deymo60ca1a72015-06-18 18:19:15 -07001001 chromeos::FakeMessageLoop loop(nullptr);
1002 loop.SetAsCurrent();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001003
Alex Deymo60ca1a72015-06-18 18:19:15 -07001004 string http_response("doesn't matter");
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001005 OmahaRequestAction action(&fake_system_state_, nullptr,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001006 new MockHttpFetcher(http_response.data(),
Andrew de los Reyes45168102010-11-22 11:13:50 -08001007 http_response.size(),
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001008 nullptr),
Thieu Le116fda32011-04-19 11:01:54 -07001009 false);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001010 TerminateEarlyTestProcessorDelegate delegate;
Darin Petkov6a5b3222010-07-13 14:55:28 -07001011 ActionProcessor processor;
1012 processor.set_delegate(&delegate);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001013 processor.EnqueueAction(&action);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001014
Alex Deymo60ca1a72015-06-18 18:19:15 -07001015 loop.PostTask(base::Bind(&TerminateTransferTestStarter, &processor));
1016 loop.Run();
1017 EXPECT_FALSE(loop.PendingTasks());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001018}
1019
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001020TEST_F(OmahaRequestActionTest, XmlEncodeTest) {
Alex Deymob0d74eb2015-03-30 17:59:17 -07001021 string output;
1022 EXPECT_TRUE(XmlEncode("ab", &output));
1023 EXPECT_EQ("ab", output);
1024 EXPECT_TRUE(XmlEncode("a<b", &output));
1025 EXPECT_EQ("a&lt;b", output);
Alex Deymocc457852015-06-18 18:35:50 -07001026 EXPECT_TRUE(XmlEncode("<&>\"\'\\", &output));
1027 EXPECT_EQ("&lt;&amp;&gt;&quot;&apos;\\", output);
Alex Deymob0d74eb2015-03-30 17:59:17 -07001028 EXPECT_TRUE(XmlEncode("&lt;&amp;&gt;", &output));
1029 EXPECT_EQ("&amp;lt;&amp;amp;&amp;gt;", output);
Alex Deymocc457852015-06-18 18:35:50 -07001030 // Check that unterminated UTF-8 strings are handled properly.
Alex Deymob0d74eb2015-03-30 17:59:17 -07001031 EXPECT_FALSE(XmlEncode("\xc2", &output));
1032 // Fail with invalid ASCII-7 chars.
1033 EXPECT_FALSE(XmlEncode("This is an 'n' with a tilde: \xc3\xb1", &output));
1034}
Darin Petkov6a5b3222010-07-13 14:55:28 -07001035
Alex Deymob0d74eb2015-03-30 17:59:17 -07001036TEST_F(OmahaRequestActionTest, XmlEncodeWithDefaultTest) {
1037 EXPECT_EQ("&lt;&amp;&gt;", XmlEncodeWithDefault("<&>", "something else"));
1038 EXPECT_EQ("<not escaped>", XmlEncodeWithDefault("\xc2", "<not escaped>"));
1039}
1040
1041TEST_F(OmahaRequestActionTest, XmlEncodeIsUsedForParams) {
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001042 chromeos::Blob post_data;
Darin Petkov6a5b3222010-07-13 14:55:28 -07001043
1044 // Make sure XML Encode is being called on the params
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001045 OmahaRequestParams params(&fake_system_state_,
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001046 OmahaRequestParams::kOsPlatform,
Darin Petkov6a5b3222010-07-13 14:55:28 -07001047 OmahaRequestParams::kOsVersion,
1048 "testtheservice_pack>",
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001049 "x86 generic<id",
Darin Petkov6a5b3222010-07-13 14:55:28 -07001050 OmahaRequestParams::kAppId,
1051 "0.1.0.0",
1052 "en-US",
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001053 "unittest_track&lt;",
Darin Petkovfbb40092010-07-29 17:05:50 -07001054 "<OEM MODEL>",
Chris Sosac1972482013-04-30 22:31:10 -07001055 "ChromeOSFirmware.1.0",
1056 "EC100",
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001057 false, // delta okay
1058 false, // interactive
Jay Srinivasan0a708742012-03-20 11:26:12 -07001059 "http://url",
Gilad Arnold74b5f552014-10-07 08:17:16 -07001060 ""); // target_version_prefix
Alex Deymo8e18f932015-03-27 16:16:59 -07001061 fake_prefs_.SetString(kPrefsOmahaCohort, "evil\nstring");
1062 fake_prefs_.SetString(kPrefsOmahaCohortHint, "evil&string\\");
1063 fake_prefs_.SetString(kPrefsOmahaCohortName,
1064 JoinString(vector<string>(100, "My spoon is too big."),
1065 ' '));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001066 OmahaResponse response;
1067 ASSERT_FALSE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001068 TestUpdateCheck(&params,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001069 "invalid xml>",
Darin Petkovedc522e2010-11-05 09:35:17 -07001070 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001071 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001072 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -08001073 metrics::CheckResult::kParsingError,
1074 metrics::CheckReaction::kUnset,
1075 metrics::DownloadErrorCode::kUnset,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001076 &response,
1077 &post_data));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001078 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001079 string post_str(post_data.begin(), post_data.end());
Alex Deymo8e18f932015-03-27 16:16:59 -07001080 EXPECT_NE(string::npos, post_str.find("testtheservice_pack&gt;"));
1081 EXPECT_EQ(string::npos, post_str.find("testtheservice_pack>"));
1082 EXPECT_NE(string::npos, post_str.find("x86 generic&lt;id"));
1083 EXPECT_EQ(string::npos, post_str.find("x86 generic<id"));
1084 EXPECT_NE(string::npos, post_str.find("unittest_track&amp;lt;"));
1085 EXPECT_EQ(string::npos, post_str.find("unittest_track&lt;"));
1086 EXPECT_NE(string::npos, post_str.find("&lt;OEM MODEL&gt;"));
1087 EXPECT_EQ(string::npos, post_str.find("<OEM MODEL>"));
1088 EXPECT_NE(string::npos, post_str.find("cohort=\"evil\nstring\""));
1089 EXPECT_EQ(string::npos, post_str.find("cohorthint=\"evil&string\\\""));
1090 EXPECT_NE(string::npos, post_str.find("cohorthint=\"evil&amp;string\\\""));
1091 // Values from Prefs that are too big are removed from the XML instead of
1092 // encoded.
1093 EXPECT_EQ(string::npos, post_str.find("cohortname="));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001094}
1095
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001096TEST_F(OmahaRequestActionTest, XmlDecodeTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -07001097 OmahaResponse response;
Alex Deymo8e18f932015-03-27 16:16:59 -07001098 fake_update_response_.deadline = "&lt;20110101";
1099 fake_update_response_.more_info_url = "testthe&lt;url";
1100 fake_update_response_.codebase = "testthe&amp;codebase/";
Darin Petkov6a5b3222010-07-13 14:55:28 -07001101 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001102 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -07001103 fake_update_response_.GetUpdateResponse(),
Darin Petkovedc522e2010-11-05 09:35:17 -07001104 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001105 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001106 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001107 metrics::CheckResult::kUpdateAvailable,
1108 metrics::CheckReaction::kUpdating,
1109 metrics::DownloadErrorCode::kUnset,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001110 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001111 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001112
1113 EXPECT_EQ(response.more_info_url, "testthe<url");
Jay Srinivasan6f6ea002012-12-14 11:26:28 -08001114 EXPECT_EQ(response.payload_urls[0], "testthe&codebase/file.signed");
Darin Petkov6c118642010-10-21 12:06:30 -07001115 EXPECT_EQ(response.deadline, "<20110101");
Darin Petkov6a5b3222010-07-13 14:55:28 -07001116}
1117
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001118TEST_F(OmahaRequestActionTest, ParseIntTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -07001119 OmahaResponse response;
Alex Deymo8e18f932015-03-27 16:16:59 -07001120 // overflows int32_t:
1121 fake_update_response_.size = 123123123123123ll;
Darin Petkov6a5b3222010-07-13 14:55:28 -07001122 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001123 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -07001124 fake_update_response_.GetUpdateResponse(),
Darin Petkovedc522e2010-11-05 09:35:17 -07001125 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001126 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001127 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001128 metrics::CheckResult::kUpdateAvailable,
1129 metrics::CheckReaction::kUpdating,
1130 metrics::DownloadErrorCode::kUnset,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001131 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001132 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001133
1134 EXPECT_EQ(response.size, 123123123123123ll);
1135}
1136
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001137TEST_F(OmahaRequestActionTest, FormatUpdateCheckOutputTest) {
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001138 chromeos::Blob post_data;
Alex Deymo8427b4a2014-11-05 14:00:32 -08001139 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001140 fake_system_state_.set_prefs(&prefs);
1141
Darin Petkov95508da2011-01-05 12:42:29 -08001142 EXPECT_CALL(prefs, GetString(kPrefsPreviousVersion, _))
1143 .WillOnce(DoAll(SetArgumentPointee<1>(string("")), Return(true)));
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001144 EXPECT_CALL(prefs, SetString(kPrefsPreviousVersion, _)).Times(1);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001145 ASSERT_FALSE(TestUpdateCheck(nullptr, // request_params
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001146 "invalid xml>",
Darin Petkovedc522e2010-11-05 09:35:17 -07001147 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001148 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001149 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -08001150 metrics::CheckResult::kParsingError,
1151 metrics::CheckReaction::kUnset,
1152 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001153 nullptr, // response
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001154 &post_data));
1155 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001156 string post_str(post_data.begin(), post_data.end());
Thieu Le116fda32011-04-19 11:01:54 -07001157 EXPECT_NE(post_str.find(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001158 " <ping active=\"1\" a=\"-1\" r=\"-1\"></ping>\n"
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001159 " <updatecheck targetversionprefix=\"\"></updatecheck>\n"),
Jay Srinivasan0a708742012-03-20 11:26:12 -07001160 string::npos);
Darin Petkovfbb40092010-07-29 17:05:50 -07001161 EXPECT_NE(post_str.find("hardware_class=\"OEM MODEL 09235 7471\""),
1162 string::npos);
Chris Sosac1972482013-04-30 22:31:10 -07001163 EXPECT_NE(post_str.find("fw_version=\"ChromeOSFirmware.1.0\""),
1164 string::npos);
1165 EXPECT_NE(post_str.find("ec_version=\"0X0A1\""),
1166 string::npos);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001167}
1168
Jay Srinivasan0a708742012-03-20 11:26:12 -07001169
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001170TEST_F(OmahaRequestActionTest, FormatSuccessEventOutputTest) {
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001171 chromeos::Blob post_data;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001172 TestEvent(request_params_,
Darin Petkove17f86b2010-07-20 09:12:01 -07001173 new OmahaEvent(OmahaEvent::kTypeUpdateDownloadStarted),
1174 "invalid xml>",
1175 &post_data);
1176 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001177 string post_str(post_data.begin(), post_data.end());
Alex Vakulenko75039d72014-03-25 12:36:28 -07001178 string expected_event = base::StringPrintf(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001179 " <event eventtype=\"%d\" eventresult=\"%d\"></event>\n",
Darin Petkove17f86b2010-07-20 09:12:01 -07001180 OmahaEvent::kTypeUpdateDownloadStarted,
1181 OmahaEvent::kResultSuccess);
1182 EXPECT_NE(post_str.find(expected_event), string::npos);
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001183 EXPECT_EQ(post_str.find("ping"), string::npos);
1184 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
Darin Petkove17f86b2010-07-20 09:12:01 -07001185}
1186
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001187TEST_F(OmahaRequestActionTest, FormatErrorEventOutputTest) {
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001188 chromeos::Blob post_data;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001189 TestEvent(request_params_,
Darin Petkove17f86b2010-07-20 09:12:01 -07001190 new OmahaEvent(OmahaEvent::kTypeDownloadComplete,
1191 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001192 ErrorCode::kError),
Darin Petkove17f86b2010-07-20 09:12:01 -07001193 "invalid xml>",
1194 &post_data);
1195 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001196 string post_str(post_data.begin(), post_data.end());
Alex Vakulenko75039d72014-03-25 12:36:28 -07001197 string expected_event = base::StringPrintf(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001198 " <event eventtype=\"%d\" eventresult=\"%d\" "
1199 "errorcode=\"%d\"></event>\n",
Darin Petkove17f86b2010-07-20 09:12:01 -07001200 OmahaEvent::kTypeDownloadComplete,
1201 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001202 static_cast<int>(ErrorCode::kError));
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001203 EXPECT_NE(post_str.find(expected_event), string::npos);
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001204 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001205}
1206
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001207TEST_F(OmahaRequestActionTest, IsEventTest) {
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001208 string http_response("doesn't matter");
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001209 // Create a copy of the OmahaRequestParams to reuse it later.
1210 OmahaRequestParams params = request_params_;
1211 fake_system_state_.set_request_params(&params);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001212 OmahaRequestAction update_check_action(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001213 &fake_system_state_,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001214 nullptr,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001215 new MockHttpFetcher(http_response.data(),
Andrew de los Reyes45168102010-11-22 11:13:50 -08001216 http_response.size(),
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001217 nullptr),
Thieu Le116fda32011-04-19 11:01:54 -07001218 false);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001219 EXPECT_FALSE(update_check_action.IsEvent());
1220
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001221 params = request_params_;
1222 fake_system_state_.set_request_params(&params);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001223 OmahaRequestAction event_action(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001224 &fake_system_state_,
Darin Petkove17f86b2010-07-20 09:12:01 -07001225 new OmahaEvent(OmahaEvent::kTypeUpdateComplete),
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001226 new MockHttpFetcher(http_response.data(),
Andrew de los Reyes45168102010-11-22 11:13:50 -08001227 http_response.size(),
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001228 nullptr),
Thieu Le116fda32011-04-19 11:01:54 -07001229 false);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001230 EXPECT_TRUE(event_action.IsEvent());
1231}
1232
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001233TEST_F(OmahaRequestActionTest, FormatDeltaOkayOutputTest) {
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001234 for (int i = 0; i < 2; i++) {
1235 bool delta_okay = i == 1;
1236 const char* delta_okay_str = delta_okay ? "true" : "false";
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001237 chromeos::Blob post_data;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001238 OmahaRequestParams params(&fake_system_state_,
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001239 OmahaRequestParams::kOsPlatform,
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001240 OmahaRequestParams::kOsVersion,
1241 "service_pack",
1242 "x86-generic",
1243 OmahaRequestParams::kAppId,
1244 "0.1.0.0",
1245 "en-US",
1246 "unittest_track",
Darin Petkovfbb40092010-07-29 17:05:50 -07001247 "OEM MODEL REV 1234",
Chris Sosac1972482013-04-30 22:31:10 -07001248 "ChromeOSFirmware.1.0",
1249 "EC100",
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001250 delta_okay,
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001251 false, // interactive
Jay Srinivasan0a708742012-03-20 11:26:12 -07001252 "http://url",
Gilad Arnold74b5f552014-10-07 08:17:16 -07001253 ""); // target_version_prefix
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001254 ASSERT_FALSE(TestUpdateCheck(&params,
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001255 "invalid xml>",
Darin Petkovedc522e2010-11-05 09:35:17 -07001256 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001257 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001258 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -08001259 metrics::CheckResult::kParsingError,
1260 metrics::CheckReaction::kUnset,
1261 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001262 nullptr,
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001263 &post_data));
1264 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001265 string post_str(post_data.begin(), post_data.end());
Alex Vakulenko75039d72014-03-25 12:36:28 -07001266 EXPECT_NE(post_str.find(base::StringPrintf(" delta_okay=\"%s\"",
1267 delta_okay_str)),
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001268 string::npos)
1269 << "i = " << i;
1270 }
1271}
1272
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001273TEST_F(OmahaRequestActionTest, FormatInteractiveOutputTest) {
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001274 for (int i = 0; i < 2; i++) {
1275 bool interactive = i == 1;
Gilad Arnold8a659d82013-01-24 11:26:00 -08001276 const char* interactive_str = interactive ? "ondemandupdate" : "scheduler";
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001277 chromeos::Blob post_data;
Gilad Arnold5bb4c902014-04-10 12:32:13 -07001278 FakeSystemState fake_system_state;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001279 OmahaRequestParams params(&fake_system_state_,
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001280 OmahaRequestParams::kOsPlatform,
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001281 OmahaRequestParams::kOsVersion,
1282 "service_pack",
1283 "x86-generic",
1284 OmahaRequestParams::kAppId,
1285 "0.1.0.0",
1286 "en-US",
1287 "unittest_track",
1288 "OEM MODEL REV 1234",
Chris Sosac1972482013-04-30 22:31:10 -07001289 "ChromeOSFirmware.1.0",
1290 "EC100",
David Zeuthen8f191b22013-08-06 12:27:50 -07001291 true, // delta_okay
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001292 interactive,
1293 "http://url",
Gilad Arnold74b5f552014-10-07 08:17:16 -07001294 ""); // target_version_prefix
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001295 ASSERT_FALSE(TestUpdateCheck(&params,
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001296 "invalid xml>",
1297 -1,
1298 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001299 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -08001300 metrics::CheckResult::kParsingError,
1301 metrics::CheckReaction::kUnset,
1302 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001303 nullptr,
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001304 &post_data));
1305 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001306 string post_str(post_data.begin(), post_data.end());
Alex Vakulenko75039d72014-03-25 12:36:28 -07001307 EXPECT_NE(post_str.find(base::StringPrintf("installsource=\"%s\"",
1308 interactive_str)),
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001309 string::npos)
1310 << "i = " << i;
1311 }
1312}
1313
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001314TEST_F(OmahaRequestActionTest, OmahaEventTest) {
Darin Petkove17f86b2010-07-20 09:12:01 -07001315 OmahaEvent default_event;
1316 EXPECT_EQ(OmahaEvent::kTypeUnknown, default_event.type);
1317 EXPECT_EQ(OmahaEvent::kResultError, default_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001318 EXPECT_EQ(ErrorCode::kError, default_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001319
1320 OmahaEvent success_event(OmahaEvent::kTypeUpdateDownloadStarted);
1321 EXPECT_EQ(OmahaEvent::kTypeUpdateDownloadStarted, success_event.type);
1322 EXPECT_EQ(OmahaEvent::kResultSuccess, success_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001323 EXPECT_EQ(ErrorCode::kSuccess, success_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001324
1325 OmahaEvent error_event(OmahaEvent::kTypeUpdateDownloadFinished,
1326 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001327 ErrorCode::kError);
Darin Petkove17f86b2010-07-20 09:12:01 -07001328 EXPECT_EQ(OmahaEvent::kTypeUpdateDownloadFinished, error_event.type);
1329 EXPECT_EQ(OmahaEvent::kResultError, error_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001330 EXPECT_EQ(ErrorCode::kError, error_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001331}
1332
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001333void OmahaRequestActionTest::PingTest(bool ping_only) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001334 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001335 fake_system_state_.set_prefs(&prefs);
1336 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
1337 .Times(AnyNumber());
1338 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
1339 // Add a few hours to the day difference to test no rounding, etc.
1340 int64_t five_days_ago =
1341 (Time::Now() - TimeDelta::FromHours(5 * 24 + 13)).ToInternalValue();
1342 int64_t six_days_ago =
1343 (Time::Now() - TimeDelta::FromHours(6 * 24 + 11)).ToInternalValue();
1344 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
1345 .WillOnce(DoAll(SetArgumentPointee<1>(0), Return(true)));
1346 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
1347 .WillOnce(DoAll(SetArgumentPointee<1>(six_days_ago), Return(true)));
1348 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
1349 .WillOnce(DoAll(SetArgumentPointee<1>(five_days_ago), Return(true)));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001350 chromeos::Blob post_data;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001351 ASSERT_TRUE(
1352 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -07001353 fake_update_response_.GetNoUpdateResponse(),
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001354 -1,
1355 ping_only,
1356 ErrorCode::kSuccess,
1357 metrics::CheckResult::kUnset,
1358 metrics::CheckReaction::kUnset,
1359 metrics::DownloadErrorCode::kUnset,
1360 nullptr,
1361 &post_data));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001362 string post_str(post_data.begin(), post_data.end());
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001363 EXPECT_NE(post_str.find("<ping active=\"1\" a=\"6\" r=\"5\"></ping>"),
1364 string::npos);
1365 if (ping_only) {
1366 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
1367 EXPECT_EQ(post_str.find("previousversion"), string::npos);
1368 } else {
1369 EXPECT_NE(post_str.find("updatecheck"), string::npos);
1370 EXPECT_NE(post_str.find("previousversion"), string::npos);
Darin Petkov265f2902011-05-09 15:17:40 -07001371 }
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001372}
1373
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001374TEST_F(OmahaRequestActionTest, PingTestSendOnlyAPing) {
1375 PingTest(true /* ping_only */);
1376}
1377
1378TEST_F(OmahaRequestActionTest, PingTestSendAlsoAnUpdateCheck) {
1379 PingTest(false /* ping_only */);
1380}
1381
1382TEST_F(OmahaRequestActionTest, ActivePingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001383 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001384 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001385 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
1386 .Times(AnyNumber());
1387 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001388 int64_t three_days_ago =
1389 (Time::Now() - TimeDelta::FromHours(3 * 24 + 12)).ToInternalValue();
1390 int64_t now = Time::Now().ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001391 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
1392 .WillOnce(DoAll(SetArgumentPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001393 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
1394 .WillOnce(DoAll(SetArgumentPointee<1>(three_days_ago), Return(true)));
1395 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
1396 .WillOnce(DoAll(SetArgumentPointee<1>(now), Return(true)));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001397 chromeos::Blob post_data;
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001398 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001399 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -07001400 fake_update_response_.GetNoUpdateResponse(),
Darin Petkovedc522e2010-11-05 09:35:17 -07001401 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001402 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001403 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001404 metrics::CheckResult::kNoUpdateAvailable,
1405 metrics::CheckReaction::kUnset,
1406 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001407 nullptr,
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001408 &post_data));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001409 string post_str(post_data.begin(), post_data.end());
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001410 EXPECT_NE(post_str.find("<ping active=\"1\" a=\"3\"></ping>"),
Thieu Le116fda32011-04-19 11:01:54 -07001411 string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001412}
1413
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001414TEST_F(OmahaRequestActionTest, RollCallPingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001415 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001416 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001417 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
1418 .Times(AnyNumber());
1419 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001420 int64_t four_days_ago =
1421 (Time::Now() - TimeDelta::FromHours(4 * 24)).ToInternalValue();
1422 int64_t now = Time::Now().ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001423 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
1424 .WillOnce(DoAll(SetArgumentPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001425 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
1426 .WillOnce(DoAll(SetArgumentPointee<1>(now), Return(true)));
1427 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
1428 .WillOnce(DoAll(SetArgumentPointee<1>(four_days_ago), Return(true)));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001429 chromeos::Blob post_data;
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001430 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001431 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -07001432 fake_update_response_.GetNoUpdateResponse(),
Darin Petkovedc522e2010-11-05 09:35:17 -07001433 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001434 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001435 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001436 metrics::CheckResult::kNoUpdateAvailable,
1437 metrics::CheckReaction::kUnset,
1438 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001439 nullptr,
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001440 &post_data));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001441 string post_str(post_data.begin(), post_data.end());
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001442 EXPECT_NE(post_str.find("<ping active=\"1\" r=\"4\"></ping>\n"),
Thieu Le116fda32011-04-19 11:01:54 -07001443 string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001444}
1445
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001446TEST_F(OmahaRequestActionTest, NoPingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001447 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001448 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001449 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
1450 .Times(AnyNumber());
1451 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001452 int64_t one_hour_ago =
1453 (Time::Now() - TimeDelta::FromHours(1)).ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001454 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
1455 .WillOnce(DoAll(SetArgumentPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001456 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
1457 .WillOnce(DoAll(SetArgumentPointee<1>(one_hour_ago), Return(true)));
1458 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
1459 .WillOnce(DoAll(SetArgumentPointee<1>(one_hour_ago), Return(true)));
Alex Deymoebbe7ef2014-10-30 13:02:49 -07001460 // LastActivePingDay and PrefsLastRollCallPingDay are set even if we didn't
1461 // send a ping.
1462 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _))
1463 .WillOnce(Return(true));
1464 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _))
1465 .WillOnce(Return(true));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001466 chromeos::Blob post_data;
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001467 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001468 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -07001469 fake_update_response_.GetNoUpdateResponse(),
Darin Petkovedc522e2010-11-05 09:35:17 -07001470 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001471 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001472 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001473 metrics::CheckResult::kNoUpdateAvailable,
1474 metrics::CheckReaction::kUnset,
1475 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001476 nullptr,
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001477 &post_data));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001478 string post_str(post_data.begin(), post_data.end());
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001479 EXPECT_EQ(post_str.find("ping"), string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001480}
1481
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001482TEST_F(OmahaRequestActionTest, IgnoreEmptyPingTest) {
Thieu Leb44e9e82011-06-06 14:34:04 -07001483 // This test ensures that we ignore empty ping only requests.
Alex Deymo8427b4a2014-11-05 14:00:32 -08001484 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001485 fake_system_state_.set_prefs(&prefs);
Thieu Leb44e9e82011-06-06 14:34:04 -07001486 int64_t now = Time::Now().ToInternalValue();
1487 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
1488 .WillOnce(DoAll(SetArgumentPointee<1>(now), Return(true)));
1489 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
1490 .WillOnce(DoAll(SetArgumentPointee<1>(now), Return(true)));
1491 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
1492 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001493 chromeos::Blob post_data;
Thieu Leb44e9e82011-06-06 14:34:04 -07001494 EXPECT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001495 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -07001496 fake_update_response_.GetNoUpdateResponse(),
Thieu Leb44e9e82011-06-06 14:34:04 -07001497 -1,
1498 true, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001499 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001500 metrics::CheckResult::kUnset,
1501 metrics::CheckReaction::kUnset,
1502 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001503 nullptr,
Thieu Leb44e9e82011-06-06 14:34:04 -07001504 &post_data));
1505 EXPECT_EQ(post_data.size(), 0);
1506}
1507
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001508TEST_F(OmahaRequestActionTest, BackInTimePingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001509 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001510 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001511 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
1512 .Times(AnyNumber());
1513 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001514 int64_t future =
1515 (Time::Now() + TimeDelta::FromHours(3 * 24 + 4)).ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001516 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
1517 .WillOnce(DoAll(SetArgumentPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001518 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
1519 .WillOnce(DoAll(SetArgumentPointee<1>(future), Return(true)));
1520 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
1521 .WillOnce(DoAll(SetArgumentPointee<1>(future), Return(true)));
1522 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _))
1523 .WillOnce(Return(true));
1524 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _))
1525 .WillOnce(Return(true));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001526 chromeos::Blob post_data;
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001527 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001528 TestUpdateCheck(nullptr, // request_params
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001529 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
1530 "protocol=\"3.0\"><daystart elapsed_seconds=\"100\"/>"
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001531 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001532 "<updatecheck status=\"noupdate\"/></app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -07001533 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001534 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001535 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001536 metrics::CheckResult::kNoUpdateAvailable,
1537 metrics::CheckReaction::kUnset,
1538 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001539 nullptr,
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001540 &post_data));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001541 string post_str(post_data.begin(), post_data.end());
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001542 EXPECT_EQ(post_str.find("ping"), string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001543}
1544
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001545TEST_F(OmahaRequestActionTest, LastPingDayUpdateTest) {
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001546 // This test checks that the action updates the last ping day to now
Darin Petkov84c763c2010-07-29 16:27:58 -07001547 // minus 200 seconds with a slack of 5 seconds. Therefore, the test
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001548 // may fail if it runs for longer than 5 seconds. It shouldn't run
1549 // that long though.
1550 int64_t midnight =
1551 (Time::Now() - TimeDelta::FromSeconds(200)).ToInternalValue();
1552 int64_t midnight_slack =
1553 (Time::Now() - TimeDelta::FromSeconds(195)).ToInternalValue();
Alex Deymo8427b4a2014-11-05 14:00:32 -08001554 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001555 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001556 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
1557 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001558 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay,
1559 AllOf(Ge(midnight), Le(midnight_slack))))
1560 .WillOnce(Return(true));
1561 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay,
1562 AllOf(Ge(midnight), Le(midnight_slack))))
1563 .WillOnce(Return(true));
1564 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001565 TestUpdateCheck(nullptr, // request_params
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001566 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
1567 "protocol=\"3.0\"><daystart elapsed_seconds=\"200\"/>"
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001568 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001569 "<updatecheck status=\"noupdate\"/></app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -07001570 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001571 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001572 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001573 metrics::CheckResult::kNoUpdateAvailable,
1574 metrics::CheckReaction::kUnset,
1575 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001576 nullptr,
1577 nullptr));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001578}
1579
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001580TEST_F(OmahaRequestActionTest, NoElapsedSecondsTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001581 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001582 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001583 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
1584 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001585 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
1586 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
1587 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001588 TestUpdateCheck(nullptr, // request_params
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001589 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
1590 "protocol=\"3.0\"><daystart blah=\"200\"/>"
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001591 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001592 "<updatecheck status=\"noupdate\"/></app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -07001593 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001594 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001595 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001596 metrics::CheckResult::kNoUpdateAvailable,
1597 metrics::CheckReaction::kUnset,
1598 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001599 nullptr,
1600 nullptr));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001601}
1602
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001603TEST_F(OmahaRequestActionTest, BadElapsedSecondsTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001604 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001605 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001606 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
1607 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001608 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
1609 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
1610 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001611 TestUpdateCheck(nullptr, // request_params
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001612 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
1613 "protocol=\"3.0\"><daystart elapsed_seconds=\"x\"/>"
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001614 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001615 "<updatecheck status=\"noupdate\"/></app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -07001616 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001617 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001618 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001619 metrics::CheckResult::kNoUpdateAvailable,
1620 metrics::CheckReaction::kUnset,
1621 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001622 nullptr,
1623 nullptr));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001624}
1625
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001626TEST_F(OmahaRequestActionTest, NoUniqueIDTest) {
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001627 chromeos::Blob post_data;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001628 ASSERT_FALSE(TestUpdateCheck(nullptr, // request_params
Darin Petkov84c763c2010-07-29 16:27:58 -07001629 "invalid xml>",
Darin Petkovedc522e2010-11-05 09:35:17 -07001630 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001631 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001632 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -08001633 metrics::CheckResult::kParsingError,
1634 metrics::CheckReaction::kUnset,
1635 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001636 nullptr, // response
Darin Petkov84c763c2010-07-29 16:27:58 -07001637 &post_data));
1638 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001639 string post_str(post_data.begin(), post_data.end());
Darin Petkov84c763c2010-07-29 16:27:58 -07001640 EXPECT_EQ(post_str.find("machineid="), string::npos);
1641 EXPECT_EQ(post_str.find("userid="), string::npos);
1642}
1643
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001644TEST_F(OmahaRequestActionTest, NetworkFailureTest) {
Darin Petkovedc522e2010-11-05 09:35:17 -07001645 OmahaResponse response;
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001646 const int http_error_code =
1647 static_cast<int>(ErrorCode::kOmahaRequestHTTPResponseBase) + 501;
Darin Petkovedc522e2010-11-05 09:35:17 -07001648 ASSERT_FALSE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001649 TestUpdateCheck(nullptr, // request_params
Darin Petkovedc522e2010-11-05 09:35:17 -07001650 "",
1651 501,
Darin Petkov265f2902011-05-09 15:17:40 -07001652 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001653 static_cast<ErrorCode>(http_error_code),
David Zeuthen33bae492014-02-25 16:16:18 -08001654 metrics::CheckResult::kDownloadError,
1655 metrics::CheckReaction::kUnset,
1656 static_cast<metrics::DownloadErrorCode>(501),
Darin Petkovedc522e2010-11-05 09:35:17 -07001657 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001658 nullptr));
Darin Petkovedc522e2010-11-05 09:35:17 -07001659 EXPECT_FALSE(response.update_exists);
1660}
1661
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001662TEST_F(OmahaRequestActionTest, NetworkFailureBadHTTPCodeTest) {
Darin Petkovedc522e2010-11-05 09:35:17 -07001663 OmahaResponse response;
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001664 const int http_error_code =
1665 static_cast<int>(ErrorCode::kOmahaRequestHTTPResponseBase) + 999;
Darin Petkovedc522e2010-11-05 09:35:17 -07001666 ASSERT_FALSE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001667 TestUpdateCheck(nullptr, // request_params
Darin Petkovedc522e2010-11-05 09:35:17 -07001668 "",
1669 1500,
Darin Petkov265f2902011-05-09 15:17:40 -07001670 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001671 static_cast<ErrorCode>(http_error_code),
David Zeuthen33bae492014-02-25 16:16:18 -08001672 metrics::CheckResult::kDownloadError,
1673 metrics::CheckReaction::kUnset,
1674 metrics::DownloadErrorCode::kHttpStatusOther,
Darin Petkovedc522e2010-11-05 09:35:17 -07001675 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001676 nullptr));
Darin Petkovedc522e2010-11-05 09:35:17 -07001677 EXPECT_FALSE(response.update_exists);
1678}
1679
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001680TEST_F(OmahaRequestActionTest, TestUpdateFirstSeenAtGetsPersistedFirstTime) {
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001681 OmahaResponse response;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001682 OmahaRequestParams params = request_params_;
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001683 params.set_wall_clock_based_wait_enabled(true);
1684 params.set_waiting_period(TimeDelta().FromDays(1));
1685 params.set_update_check_count_wait_enabled(false);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001686
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001687 ASSERT_FALSE(TestUpdateCheck(
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001688 &params,
Alex Deymo8e18f932015-03-27 16:16:59 -07001689 fake_update_response_.GetUpdateResponse(),
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001690 -1,
1691 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001692 ErrorCode::kOmahaUpdateDeferredPerPolicy,
David Zeuthen33bae492014-02-25 16:16:18 -08001693 metrics::CheckResult::kUpdateAvailable,
1694 metrics::CheckReaction::kDeferring,
1695 metrics::DownloadErrorCode::kUnset,
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001696 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001697 nullptr));
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001698
Ben Chan9abb7632014-08-07 00:10:53 -07001699 int64_t timestamp = 0;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001700 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateFirstSeenAt, &timestamp));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001701 ASSERT_GT(timestamp, 0);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001702 EXPECT_FALSE(response.update_exists);
Chris Sosa968d0572013-08-23 14:46:02 -07001703
1704 // Verify if we are interactive check we don't defer.
1705 params.set_interactive(true);
1706 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001707 TestUpdateCheck(&params,
Alex Deymo8e18f932015-03-27 16:16:59 -07001708 fake_update_response_.GetUpdateResponse(),
Chris Sosa968d0572013-08-23 14:46:02 -07001709 -1,
1710 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001711 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001712 metrics::CheckResult::kUpdateAvailable,
1713 metrics::CheckReaction::kUpdating,
1714 metrics::DownloadErrorCode::kUnset,
Chris Sosa968d0572013-08-23 14:46:02 -07001715 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001716 nullptr));
Chris Sosa968d0572013-08-23 14:46:02 -07001717 EXPECT_TRUE(response.update_exists);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001718}
1719
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001720TEST_F(OmahaRequestActionTest, TestUpdateFirstSeenAtGetsUsedIfAlreadyPresent) {
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001721 OmahaResponse response;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001722 OmahaRequestParams params = request_params_;
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001723 params.set_wall_clock_based_wait_enabled(true);
1724 params.set_waiting_period(TimeDelta().FromDays(1));
1725 params.set_update_check_count_wait_enabled(false);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001726
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001727 // Set the timestamp to a very old value such that it exceeds the
1728 // waiting period set above.
1729 Time t1;
1730 Time::FromString("1/1/2012", &t1);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001731 ASSERT_TRUE(fake_prefs_.SetInt64(
1732 kPrefsUpdateFirstSeenAt, t1.ToInternalValue()));
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001733 ASSERT_TRUE(TestUpdateCheck(
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001734 &params,
Alex Deymo8e18f932015-03-27 16:16:59 -07001735 fake_update_response_.GetUpdateResponse(),
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001736 -1,
1737 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001738 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001739 metrics::CheckResult::kUpdateAvailable,
1740 metrics::CheckReaction::kUpdating,
1741 metrics::DownloadErrorCode::kUnset,
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001742 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001743 nullptr));
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001744
1745 EXPECT_TRUE(response.update_exists);
1746
1747 // Make sure the timestamp t1 is unchanged showing that it was reused.
Ben Chan9abb7632014-08-07 00:10:53 -07001748 int64_t timestamp = 0;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001749 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateFirstSeenAt, &timestamp));
Jay Srinivasan34b5d862012-07-23 11:43:22 -07001750 ASSERT_TRUE(timestamp == t1.ToInternalValue());
1751}
1752
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001753TEST_F(OmahaRequestActionTest, TestChangingToMoreStableChannel) {
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07001754 // Create a uniquely named test directory.
1755 string test_dir;
1756 ASSERT_TRUE(utils::MakeTempDirectory(
1757 "omaha_request_action-test-XXXXXX", &test_dir));
1758
1759 ASSERT_EQ(0, System(string("mkdir -p ") + test_dir + "/etc"));
1760 ASSERT_EQ(0, System(string("mkdir -p ") + test_dir +
Chris Sosabe45bef2013-04-09 18:25:12 -07001761 kStatefulPartition + "/etc"));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001762 chromeos::Blob post_data;
Alex Deymo8427b4a2014-11-05 14:00:32 -08001763 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001764 fake_system_state_.set_prefs(&prefs);
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001765 ASSERT_TRUE(WriteFileString(
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07001766 test_dir + "/etc/lsb-release",
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001767 "CHROMEOS_RELEASE_APPID={11111111-1111-1111-1111-111111111111}\n"
1768 "CHROMEOS_BOARD_APPID={22222222-2222-2222-2222-222222222222}\n"
1769 "CHROMEOS_RELEASE_TRACK=canary-channel\n"));
1770 ASSERT_TRUE(WriteFileString(
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07001771 test_dir + kStatefulPartition + "/etc/lsb-release",
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001772 "CHROMEOS_IS_POWERWASH_ALLOWED=true\n"
1773 "CHROMEOS_RELEASE_TRACK=stable-channel\n"));
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001774 OmahaRequestParams params = request_params_;
Gilad Arnoldd04f8e22014-01-09 13:13:40 -08001775 params.set_root(test_dir);
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001776 params.SetLockDown(false);
1777 params.Init("1.2.3.4", "", 0);
1778 EXPECT_EQ("canary-channel", params.current_channel());
1779 EXPECT_EQ("stable-channel", params.target_channel());
1780 EXPECT_TRUE(params.to_more_stable_channel());
1781 EXPECT_TRUE(params.is_powerwash_allowed());
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001782 ASSERT_FALSE(TestUpdateCheck(&params,
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001783 "invalid xml>",
1784 -1,
1785 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001786 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -08001787 metrics::CheckResult::kParsingError,
1788 metrics::CheckReaction::kUnset,
1789 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001790 nullptr, // response
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001791 &post_data));
1792 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001793 string post_str(post_data.begin(), post_data.end());
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001794 EXPECT_NE(string::npos, post_str.find(
1795 "appid=\"{22222222-2222-2222-2222-222222222222}\" "
1796 "version=\"0.0.0.0\" from_version=\"1.2.3.4\" "
1797 "track=\"stable-channel\" from_track=\"canary-channel\" "));
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07001798
Alex Deymo10875d92014-11-10 21:52:57 -08001799 ASSERT_TRUE(test_utils::RecursiveUnlinkDir(test_dir));
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001800}
1801
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001802TEST_F(OmahaRequestActionTest, TestChangingToLessStableChannel) {
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07001803 // Create a uniquely named test directory.
1804 string test_dir;
1805 ASSERT_TRUE(utils::MakeTempDirectory(
1806 "omaha_request_action-test-XXXXXX", &test_dir));
1807
1808 ASSERT_EQ(0, System(string("mkdir -p ") + test_dir + "/etc"));
1809 ASSERT_EQ(0, System(string("mkdir -p ") + test_dir +
Chris Sosabe45bef2013-04-09 18:25:12 -07001810 kStatefulPartition + "/etc"));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001811 chromeos::Blob post_data;
Alex Deymo8427b4a2014-11-05 14:00:32 -08001812 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001813 fake_system_state_.set_prefs(&prefs);
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001814 ASSERT_TRUE(WriteFileString(
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07001815 test_dir + "/etc/lsb-release",
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001816 "CHROMEOS_RELEASE_APPID={11111111-1111-1111-1111-111111111111}\n"
1817 "CHROMEOS_BOARD_APPID={22222222-2222-2222-2222-222222222222}\n"
1818 "CHROMEOS_RELEASE_TRACK=stable-channel\n"));
1819 ASSERT_TRUE(WriteFileString(
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07001820 test_dir + kStatefulPartition + "/etc/lsb-release",
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001821 "CHROMEOS_RELEASE_TRACK=canary-channel\n"));
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001822 OmahaRequestParams params = request_params_;
Gilad Arnoldd04f8e22014-01-09 13:13:40 -08001823 params.set_root(test_dir);
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001824 params.SetLockDown(false);
1825 params.Init("5.6.7.8", "", 0);
1826 EXPECT_EQ("stable-channel", params.current_channel());
1827 EXPECT_EQ("canary-channel", params.target_channel());
1828 EXPECT_FALSE(params.to_more_stable_channel());
1829 EXPECT_FALSE(params.is_powerwash_allowed());
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001830 ASSERT_FALSE(TestUpdateCheck(&params,
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001831 "invalid xml>",
1832 -1,
1833 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001834 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -08001835 metrics::CheckResult::kParsingError,
1836 metrics::CheckReaction::kUnset,
1837 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001838 nullptr, // response
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001839 &post_data));
1840 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001841 string post_str(post_data.begin(), post_data.end());
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001842 EXPECT_NE(string::npos, post_str.find(
1843 "appid=\"{11111111-1111-1111-1111-111111111111}\" "
1844 "version=\"5.6.7.8\" "
1845 "track=\"canary-channel\" from_track=\"stable-channel\""));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001846 EXPECT_EQ(string::npos, post_str.find("from_version"));
Jay Srinivasanae4697c2013-03-18 17:08:08 -07001847}
1848
Alex Deymoebbe7ef2014-10-30 13:02:49 -07001849// Checks that the initial ping with a=-1 r=-1 is not send when the device
1850// was powerwashed.
1851TEST_F(OmahaRequestActionTest, PingWhenPowerwashed) {
1852 fake_prefs_.SetString(kPrefsPreviousVersion, "");
1853
1854 // Flag that the device was powerwashed in the past.
1855 fake_system_state_.fake_hardware()->SetPowerwashCount(1);
1856
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001857 chromeos::Blob post_data;
Alex Deymoebbe7ef2014-10-30 13:02:49 -07001858 ASSERT_TRUE(
1859 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -07001860 fake_update_response_.GetNoUpdateResponse(),
Alex Deymoebbe7ef2014-10-30 13:02:49 -07001861 -1,
1862 false, // ping_only
1863 ErrorCode::kSuccess,
1864 metrics::CheckResult::kNoUpdateAvailable,
1865 metrics::CheckReaction::kUnset,
1866 metrics::DownloadErrorCode::kUnset,
1867 nullptr,
1868 &post_data));
1869 // We shouldn't send a ping in this case since powerwash > 0.
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001870 string post_str(post_data.begin(), post_data.end());
Alex Deymoebbe7ef2014-10-30 13:02:49 -07001871 EXPECT_EQ(string::npos, post_str.find("<ping"));
1872}
1873
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001874void OmahaRequestActionTest::P2PTest(
1875 bool initial_allow_p2p_for_downloading,
1876 bool initial_allow_p2p_for_sharing,
1877 bool omaha_disable_p2p_for_downloading,
1878 bool omaha_disable_p2p_for_sharing,
1879 bool payload_state_allow_p2p_attempt,
1880 bool expect_p2p_client_lookup,
1881 const string& p2p_client_result_url,
1882 bool expected_allow_p2p_for_downloading,
1883 bool expected_allow_p2p_for_sharing,
1884 const string& expected_p2p_url) {
David Zeuthen8f191b22013-08-06 12:27:50 -07001885 OmahaResponse response;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001886 OmahaRequestParams request_params = request_params_;
Gilad Arnold74b5f552014-10-07 08:17:16 -07001887 bool actual_allow_p2p_for_downloading = initial_allow_p2p_for_downloading;
1888 bool actual_allow_p2p_for_sharing = initial_allow_p2p_for_sharing;
1889 string actual_p2p_url;
David Zeuthen8f191b22013-08-06 12:27:50 -07001890
1891 MockPayloadState mock_payload_state;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001892 fake_system_state_.set_payload_state(&mock_payload_state);
David Zeuthen8f191b22013-08-06 12:27:50 -07001893 EXPECT_CALL(mock_payload_state, P2PAttemptAllowed())
1894 .WillRepeatedly(Return(payload_state_allow_p2p_attempt));
Gilad Arnold74b5f552014-10-07 08:17:16 -07001895 EXPECT_CALL(mock_payload_state, GetUsingP2PForDownloading())
1896 .WillRepeatedly(ReturnPointee(&actual_allow_p2p_for_downloading));
1897 EXPECT_CALL(mock_payload_state, GetUsingP2PForSharing())
1898 .WillRepeatedly(ReturnPointee(&actual_allow_p2p_for_sharing));
1899 EXPECT_CALL(mock_payload_state, SetUsingP2PForDownloading(_))
1900 .WillRepeatedly(SaveArg<0>(&actual_allow_p2p_for_downloading));
1901 EXPECT_CALL(mock_payload_state, SetUsingP2PForSharing(_))
1902 .WillRepeatedly(SaveArg<0>(&actual_allow_p2p_for_sharing));
1903 EXPECT_CALL(mock_payload_state, SetP2PUrl(_))
1904 .WillRepeatedly(SaveArg<0>(&actual_p2p_url));
1905
David Zeuthen8f191b22013-08-06 12:27:50 -07001906 MockP2PManager mock_p2p_manager;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001907 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -07001908 mock_p2p_manager.fake().SetLookupUrlForFileResult(p2p_client_result_url);
1909
David Zeuthen4cc5ed22014-01-15 12:35:03 -08001910 TimeDelta timeout = TimeDelta::FromSeconds(kMaxP2PNetworkWaitTimeSeconds);
1911 EXPECT_CALL(mock_p2p_manager, LookupUrlForFile(_, _, timeout, _))
David Zeuthen8f191b22013-08-06 12:27:50 -07001912 .Times(expect_p2p_client_lookup ? 1 : 0);
1913
Alex Deymo8e18f932015-03-27 16:16:59 -07001914 fake_update_response_.disable_p2p_for_downloading =
1915 omaha_disable_p2p_for_downloading;
1916 fake_update_response_.disable_p2p_for_sharing = omaha_disable_p2p_for_sharing;
David Zeuthen8f191b22013-08-06 12:27:50 -07001917 ASSERT_TRUE(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001918 TestUpdateCheck(&request_params,
Alex Deymo8e18f932015-03-27 16:16:59 -07001919 fake_update_response_.GetUpdateResponse(),
David Zeuthen8f191b22013-08-06 12:27:50 -07001920 -1,
1921 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001922 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001923 metrics::CheckResult::kUpdateAvailable,
1924 metrics::CheckReaction::kUpdating,
1925 metrics::DownloadErrorCode::kUnset,
David Zeuthen8f191b22013-08-06 12:27:50 -07001926 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001927 nullptr));
David Zeuthen8f191b22013-08-06 12:27:50 -07001928 EXPECT_TRUE(response.update_exists);
1929
Gilad Arnold74b5f552014-10-07 08:17:16 -07001930 EXPECT_EQ(omaha_disable_p2p_for_downloading,
1931 response.disable_p2p_for_downloading);
1932 EXPECT_EQ(omaha_disable_p2p_for_sharing,
1933 response.disable_p2p_for_sharing);
David Zeuthen8f191b22013-08-06 12:27:50 -07001934
Gilad Arnold74b5f552014-10-07 08:17:16 -07001935 EXPECT_EQ(expected_allow_p2p_for_downloading,
1936 actual_allow_p2p_for_downloading);
1937 EXPECT_EQ(expected_allow_p2p_for_sharing, actual_allow_p2p_for_sharing);
1938 EXPECT_EQ(expected_p2p_url, actual_p2p_url);
David Zeuthen8f191b22013-08-06 12:27:50 -07001939}
1940
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001941TEST_F(OmahaRequestActionTest, P2PWithPeer) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001942 P2PTest(true, // initial_allow_p2p_for_downloading
1943 true, // initial_allow_p2p_for_sharing
1944 false, // omaha_disable_p2p_for_downloading
1945 false, // omaha_disable_p2p_for_sharing
1946 true, // payload_state_allow_p2p_attempt
1947 true, // expect_p2p_client_lookup
1948 "http://1.3.5.7/p2p", // p2p_client_result_url
1949 true, // expected_allow_p2p_for_downloading
1950 true, // expected_allow_p2p_for_sharing
1951 "http://1.3.5.7/p2p"); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07001952}
1953
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001954TEST_F(OmahaRequestActionTest, P2PWithoutPeer) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001955 P2PTest(true, // initial_allow_p2p_for_downloading
1956 true, // initial_allow_p2p_for_sharing
1957 false, // omaha_disable_p2p_for_downloading
1958 false, // omaha_disable_p2p_for_sharing
1959 true, // payload_state_allow_p2p_attempt
1960 true, // expect_p2p_client_lookup
1961 "", // p2p_client_result_url
1962 false, // expected_allow_p2p_for_downloading
1963 true, // expected_allow_p2p_for_sharing
1964 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07001965}
1966
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001967TEST_F(OmahaRequestActionTest, P2PDownloadNotAllowed) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001968 P2PTest(false, // initial_allow_p2p_for_downloading
1969 true, // initial_allow_p2p_for_sharing
1970 false, // omaha_disable_p2p_for_downloading
1971 false, // omaha_disable_p2p_for_sharing
1972 true, // payload_state_allow_p2p_attempt
1973 false, // expect_p2p_client_lookup
1974 "unset", // p2p_client_result_url
1975 false, // expected_allow_p2p_for_downloading
1976 true, // expected_allow_p2p_for_sharing
1977 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07001978}
1979
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001980TEST_F(OmahaRequestActionTest, P2PWithPeerDownloadDisabledByOmaha) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001981 P2PTest(true, // initial_allow_p2p_for_downloading
1982 true, // initial_allow_p2p_for_sharing
1983 true, // omaha_disable_p2p_for_downloading
1984 false, // omaha_disable_p2p_for_sharing
1985 true, // payload_state_allow_p2p_attempt
1986 false, // expect_p2p_client_lookup
1987 "unset", // p2p_client_result_url
1988 false, // expected_allow_p2p_for_downloading
1989 true, // expected_allow_p2p_for_sharing
1990 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07001991}
1992
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001993TEST_F(OmahaRequestActionTest, P2PWithPeerSharingDisabledByOmaha) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001994 P2PTest(true, // initial_allow_p2p_for_downloading
1995 true, // initial_allow_p2p_for_sharing
1996 false, // omaha_disable_p2p_for_downloading
1997 true, // omaha_disable_p2p_for_sharing
1998 true, // payload_state_allow_p2p_attempt
1999 true, // expect_p2p_client_lookup
2000 "http://1.3.5.7/p2p", // p2p_client_result_url
2001 true, // expected_allow_p2p_for_downloading
2002 false, // expected_allow_p2p_for_sharing
2003 "http://1.3.5.7/p2p"); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002004}
2005
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002006TEST_F(OmahaRequestActionTest, P2PWithPeerBothDisabledByOmaha) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002007 P2PTest(true, // initial_allow_p2p_for_downloading
2008 true, // initial_allow_p2p_for_sharing
2009 true, // omaha_disable_p2p_for_downloading
2010 true, // omaha_disable_p2p_for_sharing
2011 true, // payload_state_allow_p2p_attempt
2012 false, // expect_p2p_client_lookup
2013 "unset", // p2p_client_result_url
2014 false, // expected_allow_p2p_for_downloading
2015 false, // expected_allow_p2p_for_sharing
2016 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002017}
2018
Alex Deymof329b932014-10-30 01:37:48 -07002019bool OmahaRequestActionTest::InstallDateParseHelper(const string &elapsed_days,
2020 OmahaResponse *response) {
Alex Deymo8e18f932015-03-27 16:16:59 -07002021 fake_update_response_.elapsed_days = elapsed_days;
David Zeuthen639aa362014-02-03 16:23:44 -08002022 return
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002023 TestUpdateCheck(nullptr, // request_params
Alex Deymo8e18f932015-03-27 16:16:59 -07002024 fake_update_response_.GetUpdateResponse(),
David Zeuthen639aa362014-02-03 16:23:44 -08002025 -1,
2026 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002027 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08002028 metrics::CheckResult::kUpdateAvailable,
2029 metrics::CheckReaction::kUpdating,
2030 metrics::DownloadErrorCode::kUnset,
David Zeuthen639aa362014-02-03 16:23:44 -08002031 response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07002032 nullptr);
David Zeuthen639aa362014-02-03 16:23:44 -08002033}
2034
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002035TEST_F(OmahaRequestActionTest, ParseInstallDateFromResponse) {
David Zeuthen639aa362014-02-03 16:23:44 -08002036 OmahaResponse response;
David Zeuthen639aa362014-02-03 16:23:44 -08002037
2038 // Check that we parse elapsed_days in the Omaha Response correctly.
2039 // and that the kPrefsInstallDateDays value is written to.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002040 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2041 EXPECT_TRUE(InstallDateParseHelper("42", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002042 EXPECT_TRUE(response.update_exists);
2043 EXPECT_EQ(42, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002044 EXPECT_TRUE(fake_prefs_.Exists(kPrefsInstallDateDays));
David Zeuthen639aa362014-02-03 16:23:44 -08002045 int64_t prefs_days;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002046 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002047 EXPECT_EQ(prefs_days, 42);
2048
2049 // If there already is a value set, we shouldn't do anything.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002050 EXPECT_TRUE(InstallDateParseHelper("7", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002051 EXPECT_TRUE(response.update_exists);
2052 EXPECT_EQ(7, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002053 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002054 EXPECT_EQ(prefs_days, 42);
2055
2056 // Note that elapsed_days is not necessarily divisible by 7 so check
2057 // that we round down correctly when populating kPrefsInstallDateDays.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002058 EXPECT_TRUE(fake_prefs_.Delete(kPrefsInstallDateDays));
2059 EXPECT_TRUE(InstallDateParseHelper("23", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002060 EXPECT_TRUE(response.update_exists);
2061 EXPECT_EQ(23, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002062 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002063 EXPECT_EQ(prefs_days, 21);
2064
2065 // Check that we correctly handle elapsed_days not being included in
2066 // the Omaha Response.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002067 EXPECT_TRUE(InstallDateParseHelper("", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002068 EXPECT_TRUE(response.update_exists);
2069 EXPECT_EQ(-1, response.install_date_days);
David Zeuthen639aa362014-02-03 16:23:44 -08002070}
2071
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002072// If there is no prefs and OOBE is not complete, we should not
2073// report anything to Omaha.
2074TEST_F(OmahaRequestActionTest, GetInstallDateWhenNoPrefsNorOOBE) {
2075 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), -1);
2076 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2077}
David Zeuthen639aa362014-02-03 16:23:44 -08002078
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002079// If OOBE is complete and happened on a valid date (e.g. after Jan
2080// 1 2007 0:00 PST), that date should be used and written to
2081// prefs. However, first try with an invalid date and check we do
2082// nothing.
2083TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedWithInvalidDate) {
2084 Time oobe_date = Time::FromTimeT(42); // Dec 31, 1969 16:00:42 PST.
2085 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2086 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), -1);
2087 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2088}
David Zeuthen639aa362014-02-03 16:23:44 -08002089
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002090// Then check with a valid date. The date Jan 20, 2007 0:00 PST
2091// should yield an InstallDate of 14.
2092TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedWithValidDate) {
2093 Time oobe_date = Time::FromTimeT(1169280000); // Jan 20, 2007 0:00 PST.
2094 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2095 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 14);
2096 EXPECT_TRUE(fake_prefs_.Exists(kPrefsInstallDateDays));
David Zeuthen639aa362014-02-03 16:23:44 -08002097
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002098 int64_t prefs_days;
2099 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2100 EXPECT_EQ(prefs_days, 14);
2101}
David Zeuthen639aa362014-02-03 16:23:44 -08002102
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002103// Now that we have a valid date in prefs, check that we keep using
2104// that even if OOBE date reports something else. The date Jan 30,
2105// 2007 0:00 PST should yield an InstallDate of 28... but since
2106// there's a prefs file, we should still get 14.
2107TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedDateChanges) {
2108 // Set a valid date in the prefs first.
2109 EXPECT_TRUE(fake_prefs_.SetInt64(kPrefsInstallDateDays, 14));
David Zeuthen639aa362014-02-03 16:23:44 -08002110
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002111 Time oobe_date = Time::FromTimeT(1170144000); // Jan 30, 2007 0:00 PST.
2112 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2113 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 14);
David Zeuthen639aa362014-02-03 16:23:44 -08002114
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002115 int64_t prefs_days;
2116 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2117 EXPECT_EQ(prefs_days, 14);
David Zeuthen639aa362014-02-03 16:23:44 -08002118
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002119 // If we delete the prefs file, we should get 28 days.
2120 EXPECT_TRUE(fake_prefs_.Delete(kPrefsInstallDateDays));
2121 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 28);
2122 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2123 EXPECT_EQ(prefs_days, 28);
David Zeuthen639aa362014-02-03 16:23:44 -08002124}
2125
Darin Petkov6a5b3222010-07-13 14:55:28 -07002126} // namespace chromeos_update_engine