commit 11a2ce8da33e0ec4be250fd85c47f706d6c91a10
author Chih-Hung Hsieh <chh@google.com> Wed Jul 27 14:11:02 2016 -0700
committer Chih-Hung Hsieh <chh@google.com> Wed Jul 27 14:11:02 2016 -0700
tree 8dcac528bfb17372727e475d8cfb20a7038463ea
parent 786c536e84ef29b9c885f15bf8cf9b92653962ec

Fix clang-tidy performance warnings in system/vold.

* Use const reference type for for-loop index variables
  to avoid unnecessary copy.

Bug: 30413223
Change-Id: Id4d980ae8afec1374fc3be0b23f1c6a39bff86e0
Test: build with WITH_TIDY=1

VolumeBase.cpp

diff --git a/VolumeBase.cpp b/VolumeBase.cpp
index ea4d372..627feba 100644
--- a/VolumeBase.cpp
+++ b/VolumeBase.cpp
@@ -219,7 +219,7 @@
     }
 
     setState(State::kEjecting);
-    for (auto vol : mVolumes) {
+    for (const auto& vol : mVolumes) {
         if (vol->destroy()) {
             LOG(WARNING) << getId() << " failed to destroy " << vol->getId()
                     << " stacked above";