Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / vold / c07fa3fa5ada60b5f0b13d84f7a9893e2c331549
commitc07fa3fa5ada60b5f0b13d84f7a9893e2c331549[log] [tgz]
authorDan Albert <danalbert@google.com>Thu Dec 18 10:00:55 2014 -0800
committerDan Albert <danalbert@google.com>Thu Dec 18 10:24:23 2014 -0800
tree60de6672ef62073a44dda1ce14fd5a49f8f03229
parent4be3610636674b747839c3f604d25d0c5aa4fc78 [diff]
Fix alignment of buffer used for dm_ioctl.

Since the dm_ioctl struct was being allocated on the stack as a large
character array, it was getting character alignment rather than the
proper alignment for the struct. GCC had been getting away with this
so far, but it's undefined behavior that clang managed to expose.

Bug: 18736778
Change-Id: Ied275dfad7fcc41d712b2d02c8a185f499221f57
2 files changed
tree: 60de6672ef62073a44dda1ce14fd5a49f8f03229
  1. tests/
  2. Android.mk
  3. Asec.h
  4. CheckBattery.cpp
  5. CheckBattery.h
  6. CleanSpec.mk
  7. CommandListener.cpp
  8. CommandListener.h
  9. cryptfs.c
  10. cryptfs.h
  11. Devmapper.cpp
  12. Devmapper.h
  13. DirectVolume.cpp
  14. DirectVolume.h
  15. Ext4.cpp
  16. Ext4.h
  17. Fat.cpp
  18. Fat.h
  19. fstrim.c
  20. fstrim.h
  21. hash.h
  22. Loop.cpp
  23. Loop.h
  24. main.cpp
  25. NetlinkHandler.cpp
  26. NetlinkHandler.h
  27. NetlinkManager.cpp
  28. NetlinkManager.h
  29. Process.cpp
  30. Process.h
  31. ResponseCode.cpp
  32. ResponseCode.h
  33. sehandle.h
  34. vdc.c
  35. VoldCommand.cpp
  36. VoldCommand.h
  37. VoldUtil.c
  38. VoldUtil.h
  39. Volume.cpp
  40. Volume.h
  41. VolumeManager.cpp
  42. VolumeManager.h