acloud shouldn't force user to upgrade dependencies.
Bug: 148116924
Bug: 147992840
Test: acloud-dev create --local-instance
Change-Id: I1a3e2c65cb789fbe97ead22d1316ce77f687dff8
diff --git a/setup/setup_common.py b/setup/setup_common.py
index 7ed9bde..f5ded57 100644
--- a/setup/setup_common.py
+++ b/setup/setup_common.py
@@ -132,11 +132,9 @@
installed_ver,
candidate_ver)
return False
- # installed package is old and we care about the version.
+ # TODO(148116924):Setup process should ask user to update package if the
+ # minimax required version is specified.
if compare_version and installed_ver != candidate_ver:
- logger.debug("Package %s version at %s, expected %s",
- pkg_name,
- installed_ver,
- candidate_ver)
- return False
+ logger.warning("Package %s version at %s, expected %s",
+ pkg_name, installed_ver, candidate_ver)
return True
diff --git a/setup/setup_common_test.py b/setup/setup_common_test.py
index d17d2dc..5a00cfc 100644
--- a/setup/setup_common_test.py
+++ b/setup/setup_common_test.py
@@ -61,15 +61,15 @@
setup_common.PackageInstalled("fake_package")
# pylint: disable=invalid-name
- def testPackageInstalledFalseForOldVersion(self):
- """Test PackageInstalled should return False when pkg is out-of-date."""
+ def testPackageInstalledForOldVersion(self):
+ """Test PackageInstalled should return True when pkg is out-of-date."""
self.Patch(
setup_common,
"CheckCmdOutput",
return_value=self.PKG_INFO_OLD_VERSION)
- self.assertFalse(setup_common.PackageInstalled("fake_package",
- compare_version=True))
+ self.assertTrue(setup_common.PackageInstalled("fake_package",
+ compare_version=True))
def testPackageInstalled(self):
"""Test PackageInstalled should return True when pkg is installed."""