Fix syslog process hang on SL4F start failure
Fixes https://fxbug.dev/94967.
Renamed init_server_connection to init_sl4f_connection for clarity with
init_ffx_connection.
Refactored the initialization and clean up of ffx into the
start_services() and clean_up_services() methods. Also moved the
initialization of the SL4F server connection into start_services().
This reduced repetition in places where the same services were stopped
then started again.
Removes some unused function parameters and any associated hardcoded
constants that aren't being as a consequence.
Bug: None
Test: act.py -tc FlashTest (on a DUT that fails to start SL4F)
Change-Id: I303b631cd97fda8d36cba1f27c83b6d4b594e0e2
3 files changed