commit 35aef8bfd5320e54fed4da6272be365e65ad03ee
author Mark De Ruyter <markdr@google.com> Thu Jan 09 18:30:32 2020 -0800
committer Mark De Ruyter <markdr@google.com> Thu Jan 09 19:46:11 2020 -0800
tree d6219538aa9186a4382813df11520517a707cb35
parent 14aad4ff61e59793673e2a06a2d71353276424d2

Fixes unittests in binding_test.py

Bug: 147462211
Test: UT
Change-Id: Id608d9ffbc817e214976c2b23f55a0c5aa82aca0

acts/framework/tests/libs/test_bindings/binding_test.py

diff --git a/acts/framework/tests/libs/test_bindings/binding_test.py b/acts/framework/tests/libs/test_bindings/binding_test.py
index f76c1e0..b948ca5 100644
--- a/acts/framework/tests/libs/test_bindings/binding_test.py
+++ b/acts/framework/tests/libs/test_bindings/binding_test.py
@@ -26,7 +26,7 @@
 
     def test_instance_binding(self):
         instance = object()
-        binding = Binding(None)
+        binding = Binding(object)
 
         instance_binding = binding.__get__(instance, None)
 
@@ -76,7 +76,7 @@
 
     def test_call_inner_fail_on_false(self):
 
-        def inner(*args, **kwargs):
+        def inner(*_, **__):
             return False
 
         binding = Binding(inner, instance_args=['test'])
@@ -88,7 +88,7 @@
 
     def test_call_inner_pass_through_signal(self):
 
-        def inner(*args, **kwargs):
+        def inner(*_, **__):
             raise signals.TestPass('DETAILS')
 
         binding = Binding(inner, instance_args=['test'])
@@ -102,7 +102,7 @@
         self.inner_args = []
         self.inner_kwargs = {}
 
-        def arg_modifier(inner, *args, **kwargs):
+        def arg_modifier(_, *args, **kwargs):
             new_args = list(args) + ['new arg']
             new_kwargs = dict(kwargs, kw='value')
 
@@ -126,10 +126,10 @@
 
         self.has_called_before = False
 
-        def before(*args, **kwargs):
+        def before(*_, **__):
             self.has_called_before = True
 
-        def inner(*args, **kwargs):
+        def inner(*_, **__):
             self.assertTrue(self.has_called_before)
 
         binding = Binding(inner, before=before)
@@ -145,10 +145,10 @@
 
         self.has_called_after = False
 
-        def after(*args, **kwargs):
+        def after(*_, **__):
             self.has_called_after = True
 
-        def inner(*args, **kwargs):
+        def inner(*_, **__):
             self.assertFalse(self.has_called_after)
 
         binding = Binding(inner, after=after)
@@ -162,10 +162,10 @@
 
     def test_signal_modify(self):
 
-        def inner(*args, **kwargs):
+        def inner(*_, **__):
             raise signals.TestPass('DETAILS')
 
-        def signal_modifier(inner, signal, *args, **kwargs):
+        def signal_modifier(_, signal, *__, **___):
             raise signals.TestFailure(signal.details)
 
         binding = Binding(inner, signal_modifier=signal_modifier)
@@ -176,7 +176,10 @@
             self.assertEqual(signal.details, 'DETAILS')
 
     def test_inner_attr_proxy_test(self):
-        inner = mock.Mock()
+        def some_func():
+            pass
+
+        inner = some_func
         inner.x = 10
 
         binding = Binding(inner)