commit bb89fa62d988ece75903c27e80fa781adc2aaad9
author Praveena Pachipulusu <pveena@codeaurora.org> Wed Nov 26 12:34:16 2014 +0530
committer Gerrit - the friendly Code Review server <code-review@localhost> Wed Nov 26 00:58:50 2014 -0800
tree 11c4fa05bac84820a17f543398fbdbeb8981ed03
parent f4b46aeb5f8dc2791bd752716c2f2530c5c5be73

overlay: Handle return value of validateAndSet gracefully

Handle return value of validateAndSet so that the error
value doesnt get over written by improper value.

Change-Id: Ib7fde09bfcf80010ba6dab3ef28c589008d2dc50

liboverlay/overlayMdp.cpp

diff --git a/liboverlay/overlayMdp.cpp b/liboverlay/overlayMdp.cpp
index b8bb33e..4cd52a7 100644
--- a/liboverlay/overlayMdp.cpp
+++ b/liboverlay/overlayMdp.cpp
@@ -359,9 +359,12 @@
         fnProgramScale(&list);
     }
 
-    if(!mdp_wrapper::validateAndSet(fbFd, list)) {
+    // Error value is based on file errno-base.h
+    // 0 - indicates no error.
+    int errVal = mdp_wrapper::validateAndSet(fbFd, list);
+    if(errVal) {
         /* No dump for failure due to insufficient resource */
-        if(errno != E2BIG) {
+        if(errVal != E2BIG) {
             mdp_wrapper::dump("Bad ov dump: ",
                 *list.overlay_list[list.processed_overlays]);
         }