commit 4416a78b473d2174629fa13ee2be018fba89b658
author Jeff Johnson <jjohnson@qca.qualcomm.com> Mon Mar 25 14:17:50 2013 -0700
committer Gopichand Nakkala <gnakkala@qca.qualcomm.com> Wed Mar 27 22:20:59 2013 -0700
tree d4481a1be070c725c957687fea36d089a1d9adb8
parent fbf5ffc5c1ad82f90a9704e25b62540206ab9da9

Fixed bugs found during static code analysis

Fixed miscellaneous bugs

Change-Id: I14a9f9dc55ae758861ddd05848cdeafa25dd8861

CORE/HDD/src/wlan_hdd_dev_pwr.c

diff --git a/CORE/HDD/src/wlan_hdd_dev_pwr.c b/CORE/HDD/src/wlan_hdd_dev_pwr.c
index 38ac7cc..9b7a344 100644
--- a/CORE/HDD/src/wlan_hdd_dev_pwr.c
+++ b/CORE/HDD/src/wlan_hdd_dev_pwr.c
@@ -488,8 +488,8 @@
 
    pHddCtx =  (hdd_context_t*)wcnss_wlan_get_drvdata(dev);
 
-   if((pHddCtx->tmInfo.currentTmLevel == newTmLevel) ||
-      (!pHddCtx->cfg_ini->thermalMitigationEnable))
+   if ((pHddCtx->tmInfo.currentTmLevel == newTmLevel) ||
+       (!pHddCtx->cfg_ini->thermalMitigationEnable))
    {
       VOS_TRACE(VOS_MODULE_ID_HDD,VOS_TRACE_LEVEL_WARN,
                 "%s: TM Not enabled %d or Level does not changed %d",
@@ -500,10 +500,19 @@
       return;
    }
 
-   if(changedTmLevel != WLAN_HDD_TM_LEVEL_4)
+   if ((newTmLevel < WLAN_HDD_TM_LEVEL_0) ||
+       (newTmLevel >= WLAN_HDD_TM_LEVEL_MAX))
+   {
+      VOS_TRACE(VOS_MODULE_ID_HDD,VOS_TRACE_LEVEL_ERROR,
+                "%s: TM level %d out of range",
+                __func__, newTmLevel);
+      return;
+   }
+
+   if (changedTmLevel != WLAN_HDD_TM_LEVEL_4)
       sme_SetTmLevel(pHddCtx->hHal, changedTmLevel, 0);
 
-   if(mutex_lock_interruptible(&pHddCtx->tmInfo.tmOperationLock))
+   if (mutex_lock_interruptible(&pHddCtx->tmInfo.tmOperationLock))
    {
       VOS_TRACE(VOS_MODULE_ID_HDD,VOS_TRACE_LEVEL_ERROR,
                 "%s: Acquire lock fail", __func__);
@@ -517,12 +526,12 @@
                 sizeof(hdd_tmLevelAction_t));
 
 
-   if(pHddCtx->tmInfo.tmAction.enterImps)
+   if (pHddCtx->tmInfo.tmAction.enterImps)
    {
       staAdapater = hdd_get_adapter(pHddCtx, WLAN_HDD_INFRA_STATION);
-      if(staAdapater)
+      if (staAdapater)
       {
-         if(hdd_connIsConnected(WLAN_HDD_GET_STATION_CTX_PTR(staAdapater)))
+         if (hdd_connIsConnected(WLAN_HDD_GET_STATION_CTX_PTR(staAdapater)))
          {
             sme_RoamDisconnect(pHddCtx->hHal,
                                staAdapater->sessionId,