commit 7dc0e6c3c1b50d0c643fca06758871ddaa2bdeba
author Hanumantha Reddy Pothula <c_hpothu@qti.qualcomm.com> Fri Mar 06 15:11:16 2015 +0530
committer Satyanarayana Dash <c_sadash@qti.qualcomm.com> Sat Mar 07 01:33:53 2015 +0530
tree f44798b9950f90503459b3c655ff3d63731960ff
parent 1de3e69806079cebe8350ed55901a61b5eae56c4

wlan: Cleanup North-Bound load/unload logs

If IOCTLs or CFG callbacks are issued continiously during driver
load/unload or during SSR, observing stability issues because of
excessive logging.
Hence move log level to INFO from ERROR in wlan_hdd_validate_context
function and don't print return status in its caller functions.

Change-Id: I8fd9b25e0c774e1e12b01128eb86783c9dec2ab7
CRs-Fixed: 800631

CORE/HDD/src/wlan_hdd_ftm.c

diff --git a/CORE/HDD/src/wlan_hdd_ftm.c b/CORE/HDD/src/wlan_hdd_ftm.c
index 6af3937..4736999 100644
--- a/CORE/HDD/src/wlan_hdd_ftm.c
+++ b/CORE/HDD/src/wlan_hdd_ftm.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012-2013 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2012-2015 The Linux Foundation. All rights reserved.
  *
  * Previously licensed under the ISC license by Qualcomm Atheros, Inc.
  *
@@ -4871,6 +4871,8 @@
     hdd_context_t *pHddCtx;
     struct iw_point s_priv_data;
 
+    ENTER();
+
     ret =0;
     /* helper function to get iwreq_data with compat handling. */
     if (hdd_priv_get_data(&s_priv_data, wrqu))
@@ -4895,8 +4897,6 @@
     ret = wlan_hdd_validate_context(pHddCtx);
     if (0 != ret)
     {
-        VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
-                  "%s: HDD context is not valid",__func__);
         return ret;
     }
     sub_cmd = s_priv_data.flags;
@@ -4967,6 +4967,7 @@
 
 OUT:
     kfree(param);
+    EXIT();
     return ret;
 }
 
@@ -4993,6 +4994,8 @@
     int ret = 0; /* success */
     VOS_STATUS status;
 
+    ENTER();
+
     pAdapter = (netdev_priv(dev));
     if (NULL == pAdapter)
     {
@@ -5003,7 +5006,6 @@
     ret = wlan_hdd_validate_context(pHddCtx);
     if (0 != ret)
     {
-        hddLog(VOS_TRACE_LEVEL_ERROR, "%s: HDD context is not valid",__func__);
         return ret;
     }
     switch(sub_cmd)
@@ -5169,6 +5171,7 @@
         }
     }
 
+    EXIT();
     return ret;
 }
 
@@ -5193,6 +5196,8 @@
     int ret = 0; /* success */
     VOS_STATUS status;
 
+    ENTER();
+
     pAdapter = (netdev_priv(dev));
     if (NULL == pAdapter)
     {
@@ -5203,7 +5208,6 @@
     ret = wlan_hdd_validate_context(pHddCtx);
     if (0 != ret)
     {
-        hddLog(VOS_TRACE_LEVEL_ERROR, "%s: HDD context is not valid",__func__);
         return ret;
     }
 
@@ -5249,6 +5253,7 @@
         }
     }
 
+    EXIT();
     return ret;
 }
 
@@ -5273,6 +5278,8 @@
     hdd_context_t *pHddCtx;
     int ret = 0;
 
+    ENTER();
+
     pAdapter = (netdev_priv(dev));
     if (NULL == pAdapter)
     {
@@ -5283,7 +5290,6 @@
     ret = wlan_hdd_validate_context(pHddCtx);
     if (0 != ret)
     {
-        hddLog(VOS_TRACE_LEVEL_ERROR, "%s: HDD context is not valid ",__func__);
         return ret;
     }
     switch(sub_cmd)
@@ -5346,6 +5352,7 @@
         }
     }
 
+    EXIT();
     return 0;
 }
 
@@ -5483,6 +5490,8 @@
     int *value = (int*)wrqu->data.pointer;
     int ret = 0;
 
+    ENTER();
+
     if(wrqu->data.length != 2)
     {
         hddLog(LOGE, "Invalid number of Arguments  %d  \n",  wrqu->data.length);
@@ -5499,8 +5508,6 @@
     ret = wlan_hdd_validate_context(pHddCtx);
     if (0 != ret)
     {
-        hddLog(VOS_TRACE_LEVEL_ERROR,
-                  "%s: HDD context is not valid",__func__);
         return ret;
     }
     switch (sub_cmd)
@@ -5531,6 +5538,7 @@
         }
     }
 
+    EXIT();
     return 0;
 }