commit 7dc0e6c3c1b50d0c643fca06758871ddaa2bdeba
author Hanumantha Reddy Pothula <c_hpothu@qti.qualcomm.com> Fri Mar 06 15:11:16 2015 +0530
committer Satyanarayana Dash <c_sadash@qti.qualcomm.com> Sat Mar 07 01:33:53 2015 +0530
tree f44798b9950f90503459b3c655ff3d63731960ff
parent 1de3e69806079cebe8350ed55901a61b5eae56c4

wlan: Cleanup North-Bound load/unload logs

If IOCTLs or CFG callbacks are issued continiously during driver
load/unload or during SSR, observing stability issues because of
excessive logging.
Hence move log level to INFO from ERROR in wlan_hdd_validate_context
function and don't print return status in its caller functions.

Change-Id: I8fd9b25e0c774e1e12b01128eb86783c9dec2ab7
CRs-Fixed: 800631

CORE/HDD/src/wlan_hdd_main.c

diff --git a/CORE/HDD/src/wlan_hdd_main.c b/CORE/HDD/src/wlan_hdd_main.c
index 9afc876..bb026b6 100755
--- a/CORE/HDD/src/wlan_hdd_main.c
+++ b/CORE/HDD/src/wlan_hdd_main.c
@@ -1683,12 +1683,12 @@
     int ret = 0;
     hdd_context_t *pHddCtx;
 
+    ENTER();
+
     pHddCtx = WLAN_HDD_GET_CTX(pAdapter);
     ret = wlan_hdd_validate_context(pHddCtx);
     if (ret)
     {
-        VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
-                  "%s: HDD context is not valid!", __func__);
         goto exit;
     }
 
@@ -1911,7 +1911,7 @@
     }
 
 exit:
-
+    EXIT();
     return ret;
 }
 
@@ -2187,6 +2187,8 @@
    hdd_scaninfo_t *pScanInfo = NULL;
    int ret = 0;
    int status;
+
+   ENTER();
    /*
     * Note that valid pointers are provided by caller
     */
@@ -2206,9 +2208,8 @@
    status = wlan_hdd_validate_context(pHddCtx);
    if (0 != status)
    {
-       VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
-                  "%s: HDD context is not valid", __func__);
-       return status;
+       ret = -EINVAL;
+       goto exit;
    }
    /* Allocate +1 for '\0' */
    command = kmalloc(priv_data.total_len + 1, GFP_KERNEL);
@@ -4338,6 +4339,7 @@
        }
    }
 exit:
+   EXIT();
    if (command)
    {
        kfree(command);
@@ -4403,6 +4405,8 @@
    hdd_context_t *pHddCtx;
    int ret;
 
+   ENTER();
+
    pAdapter = WLAN_HDD_GET_PRIV_PTR(dev);
    if (NULL == pAdapter) {
       VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
@@ -4443,6 +4447,7 @@
       break;
    }
  exit:
+   EXIT();
    return ret;
 }
 
@@ -5435,8 +5440,6 @@
    ret = wlan_hdd_validate_context(pHddCtx);
    if (ret)
    {
-      VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
-                "%s: HDD context is not valid!", __func__);
       return ret;
    }
 
@@ -5908,8 +5911,6 @@
    ret = wlan_hdd_validate_context(pHddCtx);
    if (0 != ret)
    {
-       VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
-                 "%s: HDD context is not valid",__func__);
        return ret;
    }
 
@@ -7916,6 +7917,8 @@
    int i = 0, ret = 0;
    struct netdev_hw_addr *ha;
 
+   ENTER();
+
    pAdapter = WLAN_HDD_GET_PRIV_PTR(dev);
    if (NULL == pAdapter)
    {
@@ -7927,8 +7930,6 @@
    ret = wlan_hdd_validate_context(pHddCtx);
    if (0 != ret)
    {
-      hddLog(VOS_TRACE_LEVEL_ERROR,
-                 "%s: HDD context is not valid",__func__);
        return;
    }
    if (dev->flags & IFF_ALLMULTI)
@@ -7963,6 +7964,8 @@
          i++;
       }
    }
+
+   EXIT();
    return;
 }