commit 87f22fcac0ba9152fffaf56dcf491d96b433258e
author Mingcheng Zhu <mingchen@qca.qualcomm.com> Thu Jan 30 19:23:32 2014 -0800
committer Kiet Lam <c_kietl@qca.qualcomm.com> Tue Feb 04 17:32:08 2014 -0800
tree 514a42436991faee04f115072183ad5b1280cb8d
parent 588ae878e66759759ad7aaa2a3c1c1b9d33e8f01

wlan: fix static analysis issues in HDD files

Fix static analysis issues reported in following files:
prima/CORE/HDD/src/wlan_hdd_main.c
prima/CORE/HDD/src/wlan_hdd_tx_rx.c
prima/CORE/HDD/src/wlan_hdd_wext.c
prima/CORE/HDD/src/wlan_hdd_wmm.c
prima/CORE/HDD/src/wlan_hdd_wowl.c
prima/CORE/SME/src/pmc/pmcApi.c

Change-Id: Ib17858f23478b94b297a955e3cfddb4d3dfda042
CRs-Fixed: 609611

CORE/HDD/src/wlan_hdd_wmm.c

diff --git a/CORE/HDD/src/wlan_hdd_wmm.c b/CORE/HDD/src/wlan_hdd_wmm.c
index 69116e5..57475cd 100644
--- a/CORE/HDD/src/wlan_hdd_wmm.c
+++ b/CORE/HDD/src/wlan_hdd_wmm.c
@@ -107,7 +107,7 @@
 #define DHCP_DESTINATION_PORT 0x4300
 
 static sme_QosWmmUpType hddWmmDscpToUpMap[WLAN_HDD_MAX_DSCP+1];
-
+#define HDD_WMM_UP_TO_AC_MAP_SIZE 8
 const v_U8_t hddWmmUpToAcMap[] = {
    WLANTL_AC_BE,
    WLANTL_AC_BK,
@@ -2468,7 +2468,16 @@
    // we assume the tspec has already been validated by the caller
 
    pQosContext->handle = handle;
-   pQosContext->acType = hddWmmUpToAcMap[pTspec->ts_info.up];
+   if (pTspec->ts_info.up < HDD_WMM_UP_TO_AC_MAP_SIZE)
+      pQosContext->acType = hddWmmUpToAcMap[pTspec->ts_info.up];
+   else {
+      VOS_TRACE(VOS_MODULE_ID_HDD, WMM_TRACE_LEVEL_ERROR,
+                "%s: ts_info.up (%d) larger than max value (%d), "
+                "use default acType (%d)",
+                __func__, pTspec->ts_info.up,
+                HDD_WMM_UP_TO_AC_MAP_SIZE - 1, hddWmmUpToAcMap[0]);
+      pQosContext->acType = hddWmmUpToAcMap[0];
+   }
    pQosContext->pAdapter = pAdapter;
    pQosContext->qosFlowId = 0;
    pQosContext->magic = HDD_WMM_CTX_MAGIC;