wlan: HDD log level modification.
Added logs which should get printed when some unexpected error
happens. Modification in log level for HDD.
CRs-Fixed: 517829
Change-Id: I5da6044a28b2f225ccdb51da184c8665895d4b67
diff --git a/CORE/HDD/src/wlan_hdd_assoc.c b/CORE/HDD/src/wlan_hdd_assoc.c
index 30afe16..bced130 100644
--- a/CORE/HDD/src/wlan_hdd_assoc.c
+++ b/CORE/HDD/src/wlan_hdd_assoc.c
@@ -775,7 +775,7 @@
// Sanity check
if(dev == NULL)
{
- hddLog(VOS_TRACE_LEVEL_INFO_HIGH,
+ hddLog(VOS_TRACE_LEVEL_ERROR,
"%s: net_dev is released return", __func__);
return eHAL_STATUS_FAILURE;
}
@@ -2446,7 +2446,8 @@
* in any case tell the OS, our carrier is off and mark
* interface down */
case eCSR_ROAM_FT_REASSOC_FAILED:
- hddLog(LOG1, FL("Reassoc Failed"));
+ hddLog(LOGE, FL("Reassoc Failed with roamStatus: %d roamResult: %d SessionID: %d"),
+ roamStatus, roamResult, pAdapter->sessionId);
halStatus = hdd_DisConnectHandler( pAdapter, pRoamInfo, roamId, roamStatus, roamResult );
/* Check if Mcast/Bcast Filters are set, if yes clear the filters here */
if ((WLAN_HDD_GET_CTX(pAdapter))->hdd_mcastbcast_filter_set == TRUE) {
@@ -3264,7 +3265,7 @@
if ((WLAN_HDD_GET_CTX(pAdapter))->isLogpInProgress)
{
- VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
"%s:LOGP in Progress. Ignore!!!",__func__);
return 0;
}
@@ -3722,7 +3723,7 @@
wrqu->param.value = IW_AUTH_ALG_OPEN_SYSTEM;
break;
case eCSR_AUTH_TYPE_WPA_PSK:
- hddLog(LOG1,"%s called with unknown auth type", __func__);
+ hddLog(LOG1,"%s called with WPA PSK auth type", __func__);
wrqu->param.value = IW_AUTH_ALG_OPEN_SYSTEM;
return -EIO;
#ifdef WLAN_FEATURE_VOWIFI_11R
@@ -3732,11 +3733,11 @@
#ifdef WLAN_FEATURE_11W
case eCSR_AUTH_TYPE_RSN_PSK_SHA256:
#endif
- hddLog(LOG1,"%s called with unknown auth type", __func__);
+ hddLog(LOG1,"%s called with RSN PSK auth type", __func__);
wrqu->param.value = IW_AUTH_ALG_OPEN_SYSTEM;
return -EIO;
default:
- hddLog(LOG1,"%s called with unknown auth type", __func__);
+ hddLog(LOGE,"%s called with unknown auth type", __func__);
wrqu->param.value = IW_AUTH_ALG_OPEN_SYSTEM;
return -EIO;
}
@@ -3762,7 +3763,8 @@
wrqu->param.value = IW_AUTH_CIPHER_CCMP;
break;
default:
- hddLog(LOG1, "%s called with unknown auth type", __func__);
+ hddLog(LOG1, "%s called with unknown auth type %d ",
+ __func__, pRoamProfile->negotiatedUCEncryptionType);
return -EIO;
}
}
@@ -3789,7 +3791,8 @@
wrqu->param.value = IW_AUTH_CIPHER_CCMP;
break;
default:
- hddLog(LOG1, "%s called with unknown auth type", __func__);
+ hddLog(LOG1, "%s called with unknown auth type %d ",
+ __func__, pRoamProfile->negotiatedMCEncryptionType);
return -EIO;
}
}
diff --git a/CORE/HDD/src/wlan_hdd_cfg80211.c b/CORE/HDD/src/wlan_hdd_cfg80211.c
index ade5155..131ab42 100644
--- a/CORE/HDD/src/wlan_hdd_cfg80211.c
+++ b/CORE/HDD/src/wlan_hdd_cfg80211.c
@@ -7968,7 +7968,7 @@
if (NULL == pAdapter)
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
"%s: HDD adapter is Null", __func__);
return ;
}
@@ -8858,7 +8858,7 @@
if (NULL == pAdapter)
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
"%s: HDD adapter is Null", __func__);
return ;
}
diff --git a/CORE/HDD/src/wlan_hdd_early_suspend.c b/CORE/HDD/src/wlan_hdd_early_suspend.c
index 868950b..9550b8b 100644
--- a/CORE/HDD/src/wlan_hdd_early_suspend.c
+++ b/CORE/HDD/src/wlan_hdd_early_suspend.c
@@ -1011,7 +1011,8 @@
}
else
{
- hddLog(VOS_TRACE_LEVEL_INFO, FL("IP Address is not assigned\n"));
+ hddLog(VOS_TRACE_LEVEL_ERROR, FL("IP Address is not assigned"));
+ return VOS_STATUS_E_AGAIN;
}
if (fenable == 1 && !pAdapter->ipv4_notifier_registered)
@@ -1557,7 +1558,8 @@
return;
}
- if (pHddCtx->isLogpInProgress) {
+ if (pHddCtx->isLogpInProgress)
+ {
hddLog(VOS_TRACE_LEVEL_INFO,
"%s: Ignore resume wlan, LOGP in progress!", __func__);
return;
diff --git a/CORE/HDD/src/wlan_hdd_hostapd.c b/CORE/HDD/src/wlan_hdd_hostapd.c
index 4397ffd..a04f6e8 100644
--- a/CORE/HDD/src/wlan_hdd_hostapd.c
+++ b/CORE/HDD/src/wlan_hdd_hostapd.c
@@ -275,7 +275,7 @@
if (NULL == pAdapter)
{
VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
- "%s: HDD adapter context is Null", __func__);
+ "%s: pAdapter is Null", __func__);
ret = -ENODEV;
goto exit;
}
@@ -896,7 +896,7 @@
wrqu.data.pointer = unknownSTAEvent;
wrqu.data.length = strlen(unknownSTAEvent);
we_custom_event_generic = (v_BYTE_t *)unknownSTAEvent;
- hddLog(LOG1,"%s", unknownSTAEvent);
+ hddLog(LOGE,"%s", unknownSTAEvent);
break;
case eSAP_MAX_ASSOC_EXCEEDED:
@@ -2174,7 +2174,7 @@
if(eHAL_STATUS_SUCCESS != sme_getSoftApDomain(hHal,(v_REGDOMAIN_t *) &domainIdCurrentSoftap))
{
- hddLog(LOG1,FL("Failed to get Domain ID, %d"),domainIdCurrentSoftap);
+ hddLog(LOGE,FL("Failed to get Domain ID, %d"),domainIdCurrentSoftap);
return -EIO;
}
@@ -3117,7 +3117,7 @@
if (NULL == pAdapter)
{
- hddLog(VOS_TRACE_LEVEL_ERROR,"%s: Padapter is NULL", __func__);
+ hddLog(VOS_TRACE_LEVEL_ERROR,"%s: pAdapter is NULL", __func__);
return VOS_STATUS_E_FAULT;
}
diff --git a/CORE/HDD/src/wlan_hdd_main.c b/CORE/HDD/src/wlan_hdd_main.c
index 41f6219..ba0e415 100644
--- a/CORE/HDD/src/wlan_hdd_main.c
+++ b/CORE/HDD/src/wlan_hdd_main.c
@@ -1898,7 +1898,7 @@
if (NULL == pAdapter)
{
VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
- "%s: HDD adapter context is Null", __func__);
+ "%s: pAdapter is Null", __func__);
ret = -ENODEV;
goto exit;
}
@@ -4625,7 +4625,7 @@
if (NULL == pAdapter)
{
VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
- "%s: HDD adapter context is Null", __func__);
+ "%s: pAdapter is Null", __func__);
return -ENODEV;
}
@@ -4715,7 +4715,7 @@
if (NULL == pAdapter)
{
VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
- "%s: HDD adapter context is Null", __func__);
+ "%s: pAdapter is Null", __func__);
return -ENODEV;
}
@@ -7773,12 +7773,12 @@
*/
if (WCNSS_XO_48MHZ == wcnss_wlan_iris_xo_mode())
{
- hddLog(VOS_TRACE_LEVEL_INFO, "%s: Hardware supports 5Ghz", __func__);
+ hddLog(VOS_TRACE_LEVEL_ERROR, "%s: Hardware supports 5Ghz", __func__);
return true;
}
else
{
- hddLog(VOS_TRACE_LEVEL_INFO, "%s: Hardware doesn't supports 5Ghz",
+ hddLog(VOS_TRACE_LEVEL_ERROR, "%s: Hardware doesn't supports 5Ghz",
__func__);
return false;
}
diff --git a/CORE/HDD/src/wlan_hdd_tx_rx.c b/CORE/HDD/src/wlan_hdd_tx_rx.c
index ee2b1af..1063972 100644
--- a/CORE/HDD/src/wlan_hdd_tx_rx.c
+++ b/CORE/HDD/src/wlan_hdd_tx_rx.c
@@ -1060,16 +1060,18 @@
if( ( NULL == vosContext ) || ( NULL == pVosPacket ) )
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,"%s: Null params being passed", __func__);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ "%s: Null params being passed", __func__);
return VOS_STATUS_E_FAILURE;
}
//Return the skb to the OS
status = vos_pkt_get_os_packet( pVosPacket, &pOsPkt, VOS_TRUE );
- if(!VOS_IS_STATUS_SUCCESS( status ))
+ if (!VOS_IS_STATUS_SUCCESS( status ))
{
//This is bad but still try to free the VOSS resources if we can
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,"%s: Failure extracting skb from vos pkt", __func__);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ "%s: Failure extracting skb from vos pkt", __func__);
vos_pkt_return_packet( pVosPacket );
return VOS_STATUS_E_FAILURE;
}
@@ -1078,9 +1080,10 @@
pHddCtx = (hdd_context_t *)vos_get_context( VOS_MODULE_ID_HDD, vosContext );
//Get the Adapter context.
pAdapter = hdd_get_adapter(pHddCtx,WLAN_HDD_INFRA_STATION);
- if(pAdapter == NULL)
+ if (pAdapter == NULL)
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_INFO,"%s: HDD adapter context is Null", __func__);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_INFO,
+ "%s: HDD adapter context is Null", __func__);
}
else
{
@@ -1091,9 +1094,10 @@
//Return the VOS packet resources.
status = vos_pkt_return_packet( pVosPacket );
- if(!VOS_IS_STATUS_SUCCESS( status ))
+ if (!VOS_IS_STATUS_SUCCESS( status ))
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,"%s: Could not return VOS packet to the pool", __func__);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ "%s: Could not return VOS packet to the pool", __func__);
}
return status;
@@ -1139,7 +1143,8 @@
( NULL == ppVosPacket ) ||
( NULL == pPktMetaInfo ) )
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,"%s: Null Params being passed", __func__);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ "%s: Null Params being passed", __func__);
return VOS_STATUS_E_FAILURE;
}
@@ -1147,10 +1152,10 @@
pHddCtx = (hdd_context_t *)vos_get_context( VOS_MODULE_ID_HDD, vosContext );
if(pHddCtx == NULL)
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,"%s: HDD adapter context is Null", __func__);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ "%s: HDD adapter context is Null", __func__);
return VOS_STATUS_E_FAILURE;
}
-
pAdapter = pHddCtx->sta_to_adapter[*pStaId];
if ((NULL == pAdapter) || (WLAN_HDD_ADAPTER_MAGIC != pAdapter->magic))
{
@@ -1165,14 +1170,16 @@
//Make sure the AC being asked for is sane
if( ac >= WLANTL_MAX_AC || ac < 0)
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,"%s: Invalid AC %d passed by TL", __func__, ac);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ "%s: Invalid AC %d passed by TL", __func__, ac);
return VOS_STATUS_E_FAILURE;
}
++pAdapter->hdd_stats.hddTxRxStats.txFetchedAC[ac];
#ifdef HDD_WMM_DEBUG
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,"%s: AC %d passed by TL", __func__, ac);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
+ "%s: AC %d passed by TL", __func__, ac);
#endif // HDD_WMM_DEBUG
// We find an AC with packets
@@ -1475,9 +1482,10 @@
v_SIZE_t size = 0;
hdd_adapter_t* pAdapter = (hdd_adapter_t *)userData;
- if(pAdapter == NULL)
+ if (NULL == pAdapter)
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,"%s: HDD adapter context is Null", __func__);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ "%s: pAdapter is Null", __func__);
return VOS_STATUS_E_FAILURE;
}
@@ -1500,7 +1508,8 @@
(WLANTL_ACEnumType)i );
if( !VOS_IS_STATUS_SUCCESS( status ) )
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,"%s: Failure in indicating pkt to TL for ac=%d", __func__,i);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ "%s: Failure in indicating pkt to TL for ac=%d", __func__, i);
}
}
}
@@ -1540,14 +1549,16 @@
( NULL == pVosPacketChain ) ||
( NULL == pRxMetaInfo ) )
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,"%s: Null params being passed", __func__);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ "%s: Null params being passed", __func__);
return VOS_STATUS_E_FAILURE;
}
pHddCtx = (hdd_context_t *)vos_get_context( VOS_MODULE_ID_HDD, vosContext );
if ( NULL == pHddCtx )
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,"%s: HDD adapter context is Null", __func__);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ "%s: HDD adapter context is Null", __func__);
return VOS_STATUS_E_FAILURE;
}
@@ -1573,7 +1584,8 @@
if (!((status == VOS_STATUS_SUCCESS) || (status == VOS_STATUS_E_EMPTY)))
{
++pAdapter->hdd_stats.hddTxRxStats.rxDropped;
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,"%s: Failure walking packet chain", __func__);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ "%s: Failure walking packet chain", __func__);
return VOS_STATUS_E_FAILURE;
}
@@ -1583,7 +1595,8 @@
if(!VOS_IS_STATUS_SUCCESS( status ))
{
++pAdapter->hdd_stats.hddTxRxStats.rxDropped;
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,"%s: Failure extracting skb from vos pkt", __func__);
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ "%s: Failure extracting skb from vos pkt", __func__);
return VOS_STATUS_E_FAILURE;
}
diff --git a/CORE/HDD/src/wlan_hdd_wext.c b/CORE/HDD/src/wlan_hdd_wext.c
index f990208..100c6e7 100644
--- a/CORE/HDD/src/wlan_hdd_wext.c
+++ b/CORE/HDD/src/wlan_hdd_wext.c
@@ -482,8 +482,9 @@
ENTER();
- if ((WLAN_HDD_GET_CTX(pAdapter))->isLogpInProgress) {
- VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_INFO,
+ if ((WLAN_HDD_GET_CTX(pAdapter))->isLogpInProgress)
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_WARN,
"%s:LOGP in Progress. Ignore!!!",__func__);
return status;
}
@@ -510,7 +511,8 @@
ENTER();
- if ((WLAN_HDD_GET_CTX(pAdapter))->isLogpInProgress) {
+ if ((WLAN_HDD_GET_CTX(pAdapter))->isLogpInProgress)
+ {
VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_INFO,
"%s:LOGP in Progress. Ignore!!!",__func__);
return status;
@@ -1343,7 +1345,7 @@
pRoamProfile->BSSType = eCSR_BSS_TYPE_ANY;
break;
default:
- hddLog(LOG1, "%s Unknown AP Mode value", __func__);
+ hddLog(LOGE, "%s Unknown AP Mode value %d ", __func__, wrqu->mode);
return -EOPNOTSUPP;
}
@@ -2902,7 +2904,7 @@
if (NULL == pHddCtx)
{
- hddLog(VOS_TRACE_LEVEL_INFO_HIGH, "HDD context NULL");
+ hddLog(VOS_TRACE_LEVEL_ERROR, "HDD context NULL");
return VOS_STATUS_E_FAULT;
}
@@ -3593,7 +3595,8 @@
{
if(IW_AUTH_KEY_MGMT_802_1X == pWextState->authKeyMgmt) {
- VOS_TRACE (VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_INFO,("Invalid Configuration:%s"),__func__);
+ VOS_TRACE (VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ ("Invalid Configuration:%s"),__func__);
return -EINVAL;
}
else {
@@ -7111,7 +7114,7 @@
(band == eCSR_BAND_5G && pHddCtx->cfg_ini->nBandCapability==1) ||
(band == eCSR_BAND_ALL && pHddCtx->cfg_ini->nBandCapability!=0))
{
- VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_INFO,
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
"%s: band value %u violate INI settings %u", __func__,
band, pHddCtx->cfg_ini->nBandCapability);
return -EIO;
diff --git a/CORE/HDD/src/wlan_hdd_wmm.c b/CORE/HDD/src/wlan_hdd_wmm.c
index 3a07f2b..69116e5 100644
--- a/CORE/HDD/src/wlan_hdd_wmm.c
+++ b/CORE/HDD/src/wlan_hdd_wmm.c
@@ -1870,7 +1870,7 @@
/*Get the Station ID*/
if (VOS_STATUS_SUCCESS != hdd_softap_GetStaId(pAdapter, pDestMacAddress, &STAId))
{
- VOS_TRACE( VOS_MODULE_ID_HDD_SOFTAP, VOS_TRACE_LEVEL_INFO,
+ VOS_TRACE( VOS_MODULE_ID_HDD_SOFTAP, VOS_TRACE_LEVEL_ERROR,
"%s: Failed to find right station", __func__);
*pSTAId = HDD_WLAN_INVALID_STA_ID;
goto done;
@@ -1936,7 +1936,7 @@
hdd_Ibss_GetStaId(&pAdapter->sessionCtx.station,
pDestMacAddress, pSTAId))
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_INFO,
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
"%s: Failed to find right station pDestMacAddress: "
MAC_ADDRESS_STR , __func__,
MAC_ADDR_ARRAY(pDestMacAddress->bytes));