wlan: During SSR ensure that driver threads complete their work
TX, RX and MC Threads should complete exexution before
the exit routine tries to free the dynamic data these threads
are trying to process. The current implementation does an
interruptible wait for completion of the threads; but it has been
observed that if the process which initiated the driver unload
receives SIGKILL while waiting for threads to complete, the process
will continue without waiting for threads to complete and the threads
will try to access invalidated data after the module has been removed
leading to a kernel panic. To fix this make the wait uninterruptible
during SSR and ensure that the driver threads complete execution
before the driver exits.
Change-Id: I77088bf15787dfdfb213d3f0fcc8348190d0df95
CRs-Fixed: 752958
diff --git a/CORE/HDD/src/wlan_hdd_early_suspend.c b/CORE/HDD/src/wlan_hdd_early_suspend.c
index a30be21..79541c9 100644
--- a/CORE/HDD/src/wlan_hdd_early_suspend.c
+++ b/CORE/HDD/src/wlan_hdd_early_suspend.c
@@ -1850,7 +1850,6 @@
v_CONTEXT_t pVosContext = NULL;
hdd_context_t *pHddCtx = NULL;
pVosSchedContext vosSchedContext = NULL;
- long ret;
hddLog(VOS_TRACE_LEVEL_FATAL, "%s: WLAN driver shutting down! ",__func__);
@@ -1926,24 +1925,14 @@
set_bit(MC_SHUTDOWN_EVENT_MASK, &vosSchedContext->mcEventFlag);
set_bit(MC_POST_EVENT_MASK, &vosSchedContext->mcEventFlag);
wake_up_interruptible(&vosSchedContext->mcWaitQueue);
- ret = wait_for_completion_interruptible(&vosSchedContext->McShutdown);
- if (0 >= ret)
- {
- hddLog(VOS_TRACE_LEVEL_ERROR, "%s:wait on McShutdown failed %ld",
- __func__, ret);
- }
+ wait_for_completion(&vosSchedContext->McShutdown);
/* Wait for TX to exit */
hddLog(VOS_TRACE_LEVEL_FATAL, "%s: Shutting down TX thread",__func__);
set_bit(TX_SHUTDOWN_EVENT_MASK, &vosSchedContext->txEventFlag);
set_bit(TX_POST_EVENT_MASK, &vosSchedContext->txEventFlag);
wake_up_interruptible(&vosSchedContext->txWaitQueue);
- ret = wait_for_completion_interruptible(&vosSchedContext->TxShutdown);
- if (0 >= ret)
- {
- hddLog(VOS_TRACE_LEVEL_ERROR, "%s:wait on TxShutdown failed %ld",
- __func__, ret);
- }
+ wait_for_completion(&vosSchedContext->TxShutdown);
/* Wait for RX to exit */
hddLog(VOS_TRACE_LEVEL_FATAL, "%s: Shutting down RX thread",__func__);
@@ -1951,12 +1940,7 @@
set_bit(RX_POST_EVENT_MASK, &vosSchedContext->rxEventFlag);
wake_up_interruptible(&vosSchedContext->rxWaitQueue);
- ret = wait_for_completion_interruptible(&vosSchedContext->RxShutdown);
- if (0 >= ret)
- {
- hddLog(VOS_TRACE_LEVEL_ERROR, "%s:wait on RxShutdown failed %ld",
- __func__, ret);
- }
+ wait_for_completion(&vosSchedContext->RxShutdown);
#ifdef WLAN_BTAMP_FEATURE
vosStatus = WLANBAP_Stop(pVosContext);