wlan: Address excessive logging issues during driver unload
Netdev ops has the valid address until net device is unregistered
and currently same is unregistered at the last during the driver unload.
The calls to net dev ioctls during driver unload, may lead to failure
due to load/unload progress check. And the failure error logs results
in watchdog bark.
To mitigate this issue, make ndo_ops structure members as NULL to
avoid invoking the same during driver unload.
Change-Id: I5552b4ef8289a208b5164fd339d3c5549f58ad2f
CRs-Fixed: 783172
diff --git a/CORE/HDD/src/wlan_hdd_main.c b/CORE/HDD/src/wlan_hdd_main.c
index 0c02810..8f019c8 100755
--- a/CORE/HDD/src/wlan_hdd_main.c
+++ b/CORE/HDD/src/wlan_hdd_main.c
@@ -5986,7 +5986,18 @@
.ndo_do_ioctl = hdd_ioctl,
.ndo_set_mac_address = hdd_set_mac_address,
};
-
+ static struct net_device_ops nullify_netdev_ops = {
+ .ndo_open = NULL,
+ .ndo_stop = NULL,
+ .ndo_uninit = NULL,
+ .ndo_start_xmit = NULL,
+ .ndo_tx_timeout = NULL,
+ .ndo_get_stats = NULL,
+ .ndo_set_mac_address = NULL,
+ .ndo_do_ioctl = NULL,
+ .ndo_change_mtu = NULL,
+ .ndo_select_queue = NULL,
+ };
#endif
void hdd_set_station_ops( struct net_device *pWlanDev )
@@ -8146,15 +8157,6 @@
pAdapter = pAdapterNode->pAdapter;
if (NULL != pAdapter)
{
- /* Disable TX on the interface, after this hard_start_xmit() will
- * not be called on that interface
- */
- hddLog(VOS_TRACE_LEVEL_INFO, FL("Disabling queues"));
- netif_tx_disable(pAdapter->dev);
-
- /* Mark the interface status as "down" for outside world */
- netif_carrier_off(pAdapter->dev);
-
/* DeInit the adapter. This ensures that all data packets
* are freed.
*/
@@ -9950,6 +9952,9 @@
hddLog(VOS_TRACE_LEVEL_ERROR, FL("WD context is invalid"));
goto done;
}
+ rtnl_lock();
+ hdd_nullify_netdev_ops(pHddCtx);
+ rtnl_unlock();
spin_lock_irqsave(&pVosWDCtx->wdLock, flags);
if (!pHddCtx->isLogpInProgress || (TRUE ==
vos_is_wlan_in_badState(VOS_MODULE_ID_HDD, NULL)))
@@ -10853,6 +10858,33 @@
}
return VOS_STATUS_SUCCESS;
}
+
+void hdd_nullify_netdev_ops(hdd_context_t *pHddCtx)
+{
+ VOS_STATUS status;
+ hdd_adapter_list_node_t *pAdapterNode = NULL, *pNext = NULL;
+ hdd_adapter_t *pAdapter;
+
+ status = hdd_get_front_adapter ( pHddCtx, &pAdapterNode );
+ while ( NULL != pAdapterNode && VOS_STATUS_SUCCESS == status )
+ {
+ pAdapter = pAdapterNode->pAdapter;
+ if (NULL != pAdapter)
+ {
+ /* Disable TX on the interface, after this hard_start_xmit() will
+ * not be called on that interface
+ */
+ hddLog(VOS_TRACE_LEVEL_INFO, FL("Disabling queues"));
+ netif_tx_disable(pAdapter->dev);
+ /* Mark the interface status as "down" for outside world */
+ netif_carrier_off(pAdapter->dev);
+ pAdapter->dev->netdev_ops = &nullify_netdev_ops;
+ }
+ status = hdd_get_next_adapter ( pHddCtx, pAdapterNode, &pNext );
+ pAdapterNode = pNext;
+ }
+}
+
//Register the module init/exit functions
module_init(hdd_module_init);
module_exit(hdd_module_exit);