commit bac753d968f39c1fab8507a7e5afb8e84db947ea
author Dustin Brown <dustinb@codeaurora.org> Thu Jun 29 14:16:53 2017 -0700
committer snandini <snandini@codeaurora.org> Tue Aug 01 12:46:21 2017 -0700
tree 6775743b95c631f5d4756689854ddb02bf6f5c90
parent 634d53f81b431bdbb0f0544f890e5cc6020905a3

qcacmn: Avoid WD panic during scheduler shutdown

Avoid scheduler watchdog panic during scheduler shutdown to avoid
interfering with recovery mechanisms.

Change-Id: If32cc77a9725fdb61fc09c4065fc2603f2e8e00b
CRs-Fixed: 2069429

qdf/linux/src/i_qdf_trace.h

diff --git a/qdf/linux/src/i_qdf_trace.h b/qdf/linux/src/i_qdf_trace.h
index 5c53f1b..e6ad92a 100644
--- a/qdf/linux/src/i_qdf_trace.h
+++ b/qdf/linux/src/i_qdf_trace.h
@@ -131,7 +131,7 @@
 #ifdef KSYM_SYMBOL_LEN
 #define __QDF_SYMBOL_LEN KSYM_SYMBOL_LEN
 #else
-#define __QDF_SYMBOL_LEN 0
+#define __QDF_SYMBOL_LEN 1
 #endif
 
 #endif /* __I_QDF_TRACE_H */

scheduler/src/scheduler_api.c

diff --git a/scheduler/src/scheduler_api.c b/scheduler/src/scheduler_api.c
index ef0c0dd..5e3e17d 100644
--- a/scheduler/src/scheduler_api.c
+++ b/scheduler/src/scheduler_api.c
@@ -63,11 +63,13 @@
 				"%s: sched_ctx == NULL", __func__);
 		return QDF_STATUS_E_FAILURE;
 	}
+
 	/* shut down scheduler thread */
 	qdf_set_bit(MC_SHUTDOWN_EVENT_MASK, &sched_ctx->sch_event_flag);
 	qdf_set_bit(MC_POST_EVENT_MASK, &sched_ctx->sch_event_flag);
 	qdf_wake_up_interruptible(&sched_ctx->sch_wait_queue);
-	/* Wait for MC to exit */
+
+	/* Wait for scheduler thread to exit */
 	qdf_wait_single_event(&sched_ctx->sch_shutdown, 0);
 	sched_ctx->sch_thread = 0;
 
@@ -84,27 +86,32 @@
 
 static inline void scheduler_watchdog_notify(struct scheduler_ctx *sched)
 {
-	char symbol[QDF_SYMBOL_LEN] = "<null>";
+	char symbol[QDF_SYMBOL_LEN];
 
 	if (sched->watchdog_callback)
 		qdf_sprint_symbol(symbol, sched->watchdog_callback);
 
-	QDF_TRACE(QDF_MODULE_ID_SCHEDULER, QDF_TRACE_LEVEL_ERROR,
-		  "%s: Callback %s (type 0x%x) has exceeded its allotted time of %ds",
-		  __func__, symbol, sched->watchdog_msg_type,
-		  SCHEDULER_WATCHDOG_TIMEOUT / 1000);
+	sched_err("Callback %s (type 0x%x) exceeded its allotted time of %ds",
+		  sched->watchdog_callback ? symbol : "<null>",
+		  sched->watchdog_msg_type, SCHEDULER_WATCHDOG_TIMEOUT / 1000);
 }
 
 #ifdef CONFIG_SLUB_DEBUG_ON
-static void scheduler_watchdog_bite(void *arg)
+static void scheduler_watchdog_timeout(void *arg)
 {
-	scheduler_watchdog_notify((struct scheduler_ctx *)arg);
-	QDF_TRACE(QDF_MODULE_ID_SCHEDULER, QDF_TRACE_LEVEL_ERROR,
-		  "%s: Going down for Scheduler Watchdog Bite!", __func__);
+	struct scheduler_ctx *sched = arg;
+
+	scheduler_watchdog_notify(sched);
+
+	/* avoid crashing during shutdown */
+	if (qdf_test_bit(MC_SHUTDOWN_EVENT_MASK, &sched->sch_event_flag))
+		return;
+
+	sched_fatal("Going down for Scheduler Watchdog Bite!");
 	QDF_BUG(0);
 }
 #else
-static void scheduler_watchdog_bite(void *arg)
+static void scheduler_watchdog_timeout(void *arg)
 {
 	scheduler_watchdog_notify((struct scheduler_ctx *)arg);
 }
@@ -130,7 +137,7 @@
 	sched_ctx->sch_event_flag = 0;
 	qdf_timer_init(NULL,
 		       &sched_ctx->watchdog_timer,
-		       &scheduler_watchdog_bite,
+		       &scheduler_watchdog_timeout,
 		       sched_ctx,
 		       QDF_TIMER_TYPE_SW);