commit bd0ef8a2495fd76d634950a3c179969392eb97d4
author Manikandan Mohan <manikand@codeaurora.org> Mon Apr 10 13:10:21 2017 -0700
committer snandini <snandini@codeaurora.org> Tue May 02 13:29:28 2017 -0700
tree 4f5a276844597539d2bc7a699d80822de03affa9
parent af3fb2cbb0af2a11bb2fab59c7153d0f0c2c18ac

qcacmn: Fix kernel module check patch warnings in HIF files

Fix kernel module check patch warnings in HIF files

Change-Id: I3ddc76399004f15f325b56709e4f2e96bf4cda96
CRs-fixed: 2033001

hif/src/hif_main.c

diff --git a/hif/src/hif_main.c b/hif/src/hif_main.c
index b938ba2..6186e94 100644
--- a/hif/src/hif_main.c
+++ b/hif/src/hif_main.c
@@ -100,8 +100,8 @@
 void hif_vote_link_down(struct hif_opaque_softc *hif_ctx)
 {
 	struct hif_softc *scn = HIF_GET_SOFTC(hif_ctx);
-	QDF_BUG(scn);
 
+	QDF_BUG(scn);
 	scn->linkstate_vote--;
 	if (scn->linkstate_vote == 0)
 		hif_bus_prevent_linkdown(scn, false);
@@ -121,8 +121,8 @@
 void hif_vote_link_up(struct hif_opaque_softc *hif_ctx)
 {
 	struct hif_softc *scn = HIF_GET_SOFTC(hif_ctx);
-	QDF_BUG(scn);
 
+	QDF_BUG(scn);
 	scn->linkstate_vote++;
 	if (scn->linkstate_vote == 1)
 		hif_bus_prevent_linkdown(scn, true);
@@ -143,8 +143,8 @@
 bool hif_can_suspend_link(struct hif_opaque_softc *hif_ctx)
 {
 	struct hif_softc *scn = HIF_GET_SOFTC(hif_ctx);
-	QDF_BUG(scn);
 
+	QDF_BUG(scn);
 	return scn->linkstate_vote == 0;
 }
 
@@ -426,7 +426,8 @@
 	qdf_atomic_init(&scn->active_grp_tasklet_cnt);
 	qdf_atomic_init(&scn->link_suspended);
 	qdf_atomic_init(&scn->tasklet_from_intr);
-	qdf_mem_copy(&scn->callbacks, cbk, sizeof(struct hif_driver_state_callbacks));
+	qdf_mem_copy(&scn->callbacks, cbk,
+		     sizeof(struct hif_driver_state_callbacks));
 	scn->bus_type  = bus_type;
 	status = hif_bus_open(scn, bus_type);
 	if (status != QDF_STATUS_SUCCESS) {
@@ -461,6 +462,7 @@
 
 	if (scn->target_info.hw_name) {
 		char *hw_name = scn->target_info.hw_name;
+
 		scn->target_info.hw_name = "ErrUnloading";
 		qdf_mem_free(hw_name);
 	}
@@ -499,7 +501,8 @@
  * Return: QDF_STATUS
  */
 QDF_STATUS hif_enable(struct hif_opaque_softc *hif_ctx, struct device *dev,
-					  void *bdev, const hif_bus_id *bid,
+					  void *bdev,
+					  const struct hif_bus_id *bid,
 					  enum qdf_bus_type bus_type,
 					  enum hif_enable_type type)
 {
@@ -646,7 +649,6 @@
 {
 	HIF_INFO_MED("%s: Collecting target RAM dump disabled",
 		__func__);
-	return;
 }
 #endif /* TARGET_RAMDUMP_AFTER_KERNEL_PANIC */
 
@@ -805,6 +807,7 @@
 enum qdf_bus_type hif_get_bus_type(struct hif_opaque_softc *hif_hdl)
 {
 	struct hif_softc *scn = HIF_GET_SOFTC(hif_hdl);
+
 	return scn->bus_type;
 }
 
@@ -984,7 +987,8 @@
  *
  * Return: pointer to HIF Callbacks
  */
-struct hif_driver_state_callbacks *hif_get_callbacks_handle(struct hif_softc *scn)
+struct hif_driver_state_callbacks *hif_get_callbacks_handle(
+							struct hif_softc *scn)
 {
 	return &scn->callbacks;
 }
@@ -1098,6 +1102,7 @@
 void hif_update_tx_ring(struct hif_opaque_softc *osc, u_int32_t num_htt_cmpls)
 {
 	void *ce_tx_hdl = hif_get_ce_handle(osc, CE_HTT_TX_CE);
+
 	ce_update_tx_ring(ce_tx_hdl, num_htt_cmpls);
 }
 
@@ -1155,6 +1160,7 @@
 		uint32_t value)
 {
 	struct hif_softc *scn = HIF_GET_SOFTC(hif_ctx);
+
 	hif_write32_mb(scn->mem + offset, value);
 
 }
@@ -1171,6 +1177,7 @@
 {
 
 	struct hif_softc *scn = HIF_GET_SOFTC(hif_ctx);
+
 	return hif_read32_mb(scn->mem + offset);
 }