qcacld-3.0: Fix memory leaks when WMI send fails
Calls to wmi_unified_cmd_send() do not cleanup the passed buffer on
failure. Ensure all calls to wmi_unified_cmd_send() handle the failure
case and free the passed buffer.
Change-Id: I222bfbafc7e1f2eb0e11a54775a5d01a7a339521
CRs-Fixed: 1100325
diff --git a/core/wma/src/wma_features.c b/core/wma/src/wma_features.c
index 17f1eb3..b8af3db 100644
--- a/core/wma/src/wma_features.c
+++ b/core/wma/src/wma_features.c
@@ -5558,6 +5558,8 @@
ret = wmi_unified_cmd_send(wma->wmi_handle, buf, len,
WMI_PEER_INFO_REQ_CMDID);
+ if (ret != QDF_STATUS_SUCCESS)
+ wmi_buf_free(buf);
WMA_LOGE("IBSS get peer info cmd sent len: %d, vdev %d"
" command id: %d, status: %d", len,
@@ -5649,6 +5651,8 @@
ret = wmi_unified_cmd_send(wma->wmi_handle, buf, len,
WMI_RMC_SET_MODE_CMDID);
+ if (ret != QDF_STATUS_SUCCESS)
+ wmi_buf_free(buf);
WMA_LOGE("Enable RMC cmd sent len: %d, vdev %d" " command id: %d,"
" status: %d", len, vdev_id, WMI_RMC_SET_MODE_CMDID, ret);
@@ -5699,6 +5703,8 @@
ret = wmi_unified_cmd_send(wma->wmi_handle, buf, len,
WMI_RMC_SET_MODE_CMDID);
+ if (ret != QDF_STATUS_SUCCESS)
+ wmi_buf_free(buf);
WMA_LOGE("Disable RMC cmd sent len: %d, vdev %d" " command id: %d,"
" status: %d", len, vdev_id, WMI_RMC_SET_MODE_CMDID, ret);
@@ -5762,6 +5768,8 @@
ret = wmi_unified_cmd_send(wma->wmi_handle, buf, len,
WMI_RMC_SET_ACTION_PERIOD_CMDID);
+ if (ret != QDF_STATUS_SUCCESS)
+ wmi_buf_free(buf);
WMA_LOGE("RMC action period %d cmd sent len: %d, vdev %d"
" command id: %d, status: %d", periodicity_msec,