qcacld-3.0: add error handling for cdp_soc_attach
If cdp_soc_attach returns null, need to handle the error.
Change-Id: I8fe9c176ecf777564830baca9fc3b1e919fbb6e4
CRs-Fixed: 2118029
diff --git a/core/cds/src/cds_api.c b/core/cds/src/cds_api.c
index 8c465cd..4436a53 100644
--- a/core/cds/src/cds_api.c
+++ b/core/cds/src/cds_api.c
@@ -593,6 +593,9 @@
pmo_ucfg_psoc_update_dp_handle(psoc, gp_cds_context->dp_soc);
+ if (gp_cds_context->dp_soc == NULL)
+ goto err_wma_close;
+
cds_set_ac_specs_params(cds_cfg);
cds_cdp_cfg_attach(cds_cfg);
@@ -607,7 +610,7 @@
QDF_TRACE(QDF_MODULE_ID_QDF, QDF_TRACE_LEVEL_FATAL,
"%s: Failed to open MAC", __func__);
QDF_ASSERT(0);
- goto err_wma_close;
+ goto err_soc_detach;
}
/* Now proceed to open the SME */
@@ -645,6 +648,8 @@
err_mac_close:
mac_close(gp_cds_context->pMACContext);
+err_soc_detach:
+ /* todo: add propper error handling */
err_wma_close:
cds_shutdown_notifier_purge();
wma_close();