qcacld-3.0: Refine the link layer stats callback API
It is fine for an API to use a void pointer for a data structure that
is opaque or a binary blob, but it is not ok to do so when the type of
the data must be known and agreed upon by both the caller and the
callee. In the case of the link layer stats callback the API
definition uses a void pointer for both the context parameter and the
response parameter, but an HDD handle is always passed as the context
and a tSirLLStatsResults struct is always passed as the response, so
explicitly reference those types. This will allow the compiler to
verify that the correct types of parameters are being passed.
Change-Id: Iba181bbc97331f8fdde1cdf5c81a80efef014839
CRs-Fixed: 2276494
diff --git a/core/wma/src/wma_utils.c b/core/wma/src/wma_utils.c
index 98f446f..5099c80 100644
--- a/core/wma/src/wma_utils.c
+++ b/core/wma/src/wma_utils.c
@@ -1253,7 +1253,7 @@
return -EINVAL;
}
- if (!pMac->sme.pLinkLayerStatsIndCallback) {
+ if (!pMac->sme.link_layer_stats_cb) {
WMA_LOGD("%s: HDD callback is null", __func__);
return -EINVAL;
}
@@ -1375,7 +1375,7 @@
* vdev_id/ifacId in link_stats_results will be
* used to retrieve the correct HDD context
*/
- pMac->sme.pLinkLayerStatsIndCallback(pMac->hdd_handle,
+ pMac->sme.link_layer_stats_cb(pMac->hdd_handle,
WMA_LINK_LAYER_STATS_RESULTS_RSP,
link_stats_results);
qdf_mem_free(link_stats_results);
@@ -1449,7 +1449,7 @@
return -EINVAL;
}
- if (!mac->sme.pLinkLayerStatsIndCallback) {
+ if (!mac->sme.link_layer_stats_cb) {
WMA_LOGD("%s: HDD callback is null", __func__);
return -EINVAL;
}
@@ -1571,7 +1571,7 @@
* vdev_id/ifacId in link_stats_results will be
* used to retrieve the correct HDD context
*/
- mac->sme.pLinkLayerStatsIndCallback(mac->hdd_handle,
+ mac->sme.link_layer_stats_cb(mac->hdd_handle,
WMA_LINK_LAYER_STATS_RESULTS_RSP,
link_stats_results);
wma_unified_radio_tx_mem_free(handle);
@@ -1611,7 +1611,7 @@
return -EINVAL;
}
- if (!pMac->sme.pLinkLayerStatsIndCallback) {
+ if (!pMac->sme.link_layer_stats_cb) {
WMA_LOGD("%s: HDD callback is null", __func__);
return -EINVAL;
}
@@ -1779,7 +1779,7 @@
return 0;
}
- pMac->sme.pLinkLayerStatsIndCallback(pMac->hdd_handle,
+ pMac->sme.link_layer_stats_cb(pMac->hdd_handle,
WMA_LINK_LAYER_STATS_RESULTS_RSP,
link_stats_results);
wma_unified_radio_tx_mem_free(handle);
@@ -2073,7 +2073,7 @@
return -EINVAL;
}
- if (!pMac->sme.pLinkLayerStatsIndCallback) {
+ if (!pMac->sme.link_layer_stats_cb) {
WMA_LOGD("%s: HDD callback is null", __func__);
return -EINVAL;
}
@@ -2204,7 +2204,7 @@
* vdev_id/ifacId in link_stats_results will be
* used to retrieve the correct HDD context
*/
- pMac->sme.pLinkLayerStatsIndCallback(pMac->hdd_handle,
+ pMac->sme.link_layer_stats_cb(pMac->hdd_handle,
WMA_LINK_LAYER_STATS_RESULTS_RSP,
link_stats_results);
qdf_mem_free(link_stats_results);