qcacld-3.0: Replace typedef tSirSmeDeauthInd
The Linux Coding Style enumerates a few special cases where typedefs
are useful, but stresses "NEVER EVER use a typedef unless you can
clearly match one of those rules." The tSirSmeDeauthInd typedef does
not meet any of those criteria, so replace it (and the "tp" variant)
with a reference to the underlying struct.
Further note the Linux Coding Style frowns upon mixed-case names and
so-called Hungarian notation, so in conjunction rename the underlying
struct to be in compliance.
Change-Id: I4d98feee8da17ba53b199d37092a4b3bafe25d54
CRs-Fixed: 2395993
diff --git a/core/mac/src/pe/lim/lim_send_sme_rsp_messages.c b/core/mac/src/pe/lim/lim_send_sme_rsp_messages.c
index 6586eb2..1f8d26f 100644
--- a/core/mac/src/pe/lim/lim_send_sme_rsp_messages.c
+++ b/core/mac/src/pe/lim/lim_send_sme_rsp_messages.c
@@ -965,14 +965,14 @@
struct pe_session *pe_session)
{
struct scheduler_msg mmhMsg = {0};
- tSirSmeDeauthInd *pSirSmeDeauthInd;
+ struct deauth_ind *pSirSmeDeauthInd;
- pSirSmeDeauthInd = qdf_mem_malloc(sizeof(tSirSmeDeauthInd));
+ pSirSmeDeauthInd = qdf_mem_malloc(sizeof(*pSirSmeDeauthInd));
if (!pSirSmeDeauthInd)
return;
pSirSmeDeauthInd->messageType = eWNI_SME_DEAUTH_IND;
- pSirSmeDeauthInd->length = sizeof(tSirSmeDeauthInd);
+ pSirSmeDeauthInd->length = sizeof(*pSirSmeDeauthInd);
pSirSmeDeauthInd->sessionId = pe_session->smeSessionId;
pSirSmeDeauthInd->transactionId = pe_session->transactionId;
@@ -980,7 +980,7 @@
pSirSmeDeauthInd->statusCode =
(tSirResultCodes) sta->mlmStaContext.cleanupTrigger;
} else {
- /* Need to indicatet he reascon code over the air */
+ /* Need to indicate the reason code over the air */
pSirSmeDeauthInd->statusCode =
(tSirResultCodes) sta->mlmStaContext.disassocReason;
}
@@ -1176,7 +1176,7 @@
{
uint8_t *pBuf;
struct deauth_rsp *pSirSmeDeauthRsp;
- tSirSmeDeauthInd *pSirSmeDeauthInd;
+ struct deauth_ind *pSirSmeDeauthInd;
struct pe_session *pe_session;
uint8_t sessionId;
uint32_t *pMsg = NULL;
@@ -1228,13 +1228,14 @@
* frame reception from peer entity or due to
* loss of link with peer entity.
*/
- pSirSmeDeauthInd = qdf_mem_malloc(sizeof(tSirSmeDeauthInd));
+ pSirSmeDeauthInd = qdf_mem_malloc(sizeof(*pSirSmeDeauthInd));
if (!pSirSmeDeauthInd)
return;
- pe_debug("send eWNI_SME_DEAUTH_IND with retCode: %d for " MAC_ADDRESS_STR,
- reasonCode, MAC_ADDR_ARRAY(peerMacAddr));
+ pe_debug("send eWNI_SME_DEAUTH_IND with retCode: %d for "
+ MAC_ADDRESS_STR,
+ reasonCode, MAC_ADDR_ARRAY(peerMacAddr));
pSirSmeDeauthInd->messageType = eWNI_SME_DEAUTH_IND;
- pSirSmeDeauthInd->length = sizeof(tSirSmeDeauthInd);
+ pSirSmeDeauthInd->length = sizeof(*pSirSmeDeauthInd);
pSirSmeDeauthInd->reasonCode = eSIR_MAC_UNSPEC_FAILURE_REASON;
/* sessionId */