commit 2cffae58e352d724ad21318bb243971a6ab33d3c
author Kiran Kumar Lokere <klokere@codeaurora.org> Thu Sep 26 18:44:15 2019 -0700
committer Jouni Malinen <jouni@codeaurora.org> Sat Sep 28 00:45:45 2019 +0300
tree d92471c7fa4d552d7f5c500ed439610a38a00d11
parent f8d81aa4f407ffd34100137847a3c7ca9a3a287c

HE: Fix TWT attribute types in TWT request message

For TWT flag attributes netlink u8 type (with 0 = false, nonzero = true)
was used while sending the driver command. Use netlink flag type for the
flag attributes (not present = false, present = true) to send the TWT
request driver command.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

sta.c

diff --git a/sta.c b/sta.c
index 4b57ce4..35f3d7c 100644
--- a/sta.c
+++ b/sta.c
@@ -8115,14 +8115,13 @@
 	    !(attr1 = nla_nest_start(msg, NL80211_ATTR_VENDOR_DATA)) ||
 	    nla_put_u8(msg, QCA_WLAN_VENDOR_ATTR_TWT_SETUP_WAKE_INTVL_EXP,
 		       wake_interval_exp) ||
-	    nla_put_u8(msg, QCA_WLAN_VENDOR_ATTR_TWT_SETUP_BCAST, 0) ||
 	    nla_put_u8(msg, QCA_WLAN_VENDOR_ATTR_TWT_SETUP_REQ_TYPE, 1) ||
-	    nla_put_u8(msg, QCA_WLAN_VENDOR_ATTR_TWT_SETUP_TRIGGER,
-		       twt_trigger) ||
+	    (twt_trigger &&
+	     nla_put_flag(msg, QCA_WLAN_VENDOR_ATTR_TWT_SETUP_TRIGGER)) ||
 	    nla_put_u8(msg, QCA_WLAN_VENDOR_ATTR_TWT_SETUP_FLOW_TYPE,
 		       flow_type) ||
-	    nla_put_u8(msg, QCA_WLAN_VENDOR_ATTR_TWT_SETUP_PROTECTION,
-		       protection) ||
+	    (protection &&
+	     nla_put_flag(msg, QCA_WLAN_VENDOR_ATTR_TWT_SETUP_PROTECTION)) ||
 	    nla_put_u32(msg, QCA_WLAN_VENDOR_ATTR_TWT_SETUP_WAKE_TIME,
 			target_wake_time) ||
 	    nla_put_u32(msg, QCA_WLAN_VENDOR_ATTR_TWT_SETUP_WAKE_DURATION,