commit 429c69ec36f117aa3d9aaf03ded6d5667d85c5d2
author Pradeep Reddy POTTETI <c_ppotte@qti.qualcomm.com> Thu Oct 13 17:22:03 2016 +0530
committer Jouni Malinen <jouni@qca.qualcomm.com> Tue Oct 25 16:20:46 2016 +0300
tree 0865691c878968c6f2345061539e57f5cffff23d
parent f58a1fe77808d0be2cd3caa4b5696e6fac670194

sta_set_systime: Validate month value

This commit fixes static analysis taint issues.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

sta.c

diff --git a/sta.c b/sta.c
index f003e32..d1b54d2 100644
--- a/sta.c
+++ b/sta.c
@@ -7274,6 +7274,7 @@
 	struct tm tm;
 	time_t t;
 	const char *val;
+	int v;
 
 	wpa_command(get_station_ifname(), "PMKSA_FLUSH");
 
@@ -7291,8 +7292,15 @@
 	if (val)
 		tm.tm_mday = atoi(val);
 	val = get_param(cmd, "month");
-	if (val)
-		tm.tm_mon = atoi(val) - 1;
+	if (val) {
+		v = atoi(val);
+		if (v < 1 || v > 12) {
+			send_resp(dut, conn, SIGMA_INVALID,
+				  "errorCode,Invalid month");
+			return 0;
+		}
+		tm.tm_mon = v - 1;
+	}
 	val = get_param(cmd, "year");
 	if (val) {
 		int year = atoi(val);