commit 008c45f1a1a7a60736a0afbb03b57f43b11dcf49
author Jason Molenda <jmolenda@apple.com> Tue Nov 12 23:33:32 2013 +0000
committer Jason Molenda <jmolenda@apple.com> Tue Nov 12 23:33:32 2013 +0000
tree 7114ed975f63a8e96be158e08c350bc9d2bde21e
parent 6cd1b9aec4a9f84f9a88679c8cfbe92fbf5fbf81

Change SBThread::GetExtendedBacktrace to
SBThread::GetExtendedBacktraceThread to make it more clear what is
being returned.

llvm-svn: 194531

lldb/source/API/SBProcess.cpp

diff --git a/lldb/source/API/SBProcess.cpp b/lldb/source/API/SBProcess.cpp
index d690da7..557006f 100644
--- a/lldb/source/API/SBProcess.cpp
+++ b/lldb/source/API/SBProcess.cpp
@@ -1278,7 +1278,7 @@
     if (process_sp && process_sp->GetSystemRuntime())
     {
         SystemRuntime *runtime = process_sp->GetSystemRuntime();
-        std::vector<ConstString> names = runtime->GetExtendedBacktraceTypes();
+        const std::vector<ConstString> &names = runtime->GetExtendedBacktraceTypes();
         if (idx < names.size())
         {
             return names[idx].AsCString();

lldb/source/API/SBThread.cpp

diff --git a/lldb/source/API/SBThread.cpp b/lldb/source/API/SBThread.cpp
index 72fe3cf..e36d09e 100644
--- a/lldb/source/API/SBThread.cpp
+++ b/lldb/source/API/SBThread.cpp
@@ -433,7 +433,6 @@
     m_opaque_sp->SetThreadSP (lldb_object_sp);
 }
 
-
 lldb::tid_t
 SBThread::GetThreadID () const
 {
@@ -1283,7 +1282,7 @@
 }
 
 SBThread
-SBThread::GetExtendedBacktrace (const char *type)
+SBThread::GetExtendedBacktraceThread (const char *type)
 {
     Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));
     Mutex::Locker api_locker;
@@ -1305,7 +1304,7 @@
                     SystemRuntime *runtime = process->GetSystemRuntime();
                     if (runtime)
                     {
-                        ThreadSP new_thread_sp (runtime->GetExtendedBacktrace (real_thread, type_const));
+                        ThreadSP new_thread_sp (runtime->GetExtendedBacktraceThread (real_thread, type_const));
                         // Save this in the Process' ExtendedThreadList so a strong pointer retains the
                         // object.
                         process->GetExtendedThreadList().AddThread (new_thread_sp);

lldb/source/Commands/CommandObjectThread.cpp

diff --git a/lldb/source/Commands/CommandObjectThread.cpp b/lldb/source/Commands/CommandObjectThread.cpp
index bfe954115..10d6618 100644
--- a/lldb/source/Commands/CommandObjectThread.cpp
+++ b/lldb/source/Commands/CommandObjectThread.cpp
@@ -180,7 +180,7 @@
             const std::vector<ConstString> &types = runtime->GetExtendedBacktraceTypes();
             for (auto type : types)
             {
-                ThreadSP ext_thread_sp = runtime->GetExtendedBacktrace (thread->shared_from_this(), type);
+                ThreadSP ext_thread_sp = runtime->GetExtendedBacktraceThread (thread->shared_from_this(), type);
                 if (ext_thread_sp && ext_thread_sp->IsValid ())
                 {
                     const uint32_t num_frames_with_source = 0;

lldb/source/Target/SystemRuntime.cpp

diff --git a/lldb/source/Target/SystemRuntime.cpp b/lldb/source/Target/SystemRuntime.cpp
index c885aa7..5c07ed3 100644
--- a/lldb/source/Target/SystemRuntime.cpp
+++ b/lldb/source/Target/SystemRuntime.cpp
@@ -67,7 +67,7 @@
 }
 
 ThreadSP
-SystemRuntime::GetExtendedBacktrace (ThreadSP thread, ConstString type)
+SystemRuntime::GetExtendedBacktraceThread (ThreadSP thread, ConstString type)
 {
     return ThreadSP();
 }