[TBAAVerifier] Be stricter around verifying scalar nodes

This fixes the issue exposed in PR31393, where we weren't trying
sufficiently hard to diagnose bad TBAA metadata.

This does reduce the variety in the error messages we print out, but I
think the tradeoff of verifying more, simply and quickly overrules the
need for more helpful error messags here.

llvm-svn: 290713
diff --git a/llvm/test/DebugInfo/Generic/recursive_inlining.ll b/llvm/test/DebugInfo/Generic/recursive_inlining.ll
index 9afa8ae..03ccfed 100644
--- a/llvm/test/DebugInfo/Generic/recursive_inlining.ll
+++ b/llvm/test/DebugInfo/Generic/recursive_inlining.ll
@@ -239,7 +239,7 @@
 !35 = !DILocation(line: 9, scope: !36, inlinedAt: !24)
 !36 = distinct !DILexicalBlock(scope: !30, file: !2, line: 9)
 !37 = !{!38, !39, i64 0}
-!38 = !{!4, !39, i64 0}
+!38 = !{!"struct", !39, i64 0}
 !39 = !{!"int", !27, i64 0}
 !40 = !DILocation(line: 9, scope: !41, inlinedAt: !24)
 !41 = distinct !DILexicalBlock(scope: !36, file: !2, line: 9)