commit 022c3c85df68d4089dafece189d681666e33c837
author Zachary Turner <zturner@google.com> Wed Sep 02 17:59:19 2015 +0000
committer Zachary Turner <zturner@google.com> Wed Sep 02 17:59:19 2015 +0000
tree a6ecc1ed0e9241bcb1e536b40e6856b5d4af8991
parent 58e0823ee9c5da4e5ce204eb266ea47af1e8353d

When redirecting stdio, use FILE_SHARE_DELETE.

Some tests were failing because the test would try to delete the
file before inferior had exited, but on Windows this will fail by
default unless you specify FILE_SHARE_DELETE when opening the file.

Can't think of a good reason not to do this, so here it is.

llvm-svn: 246682

lldb/source/Host/windows/ProcessLauncherWindows.cpp

diff --git a/lldb/source/Host/windows/ProcessLauncherWindows.cpp b/lldb/source/Host/windows/ProcessLauncherWindows.cpp
index a09906d..355dd40 100644
--- a/lldb/source/Host/windows/ProcessLauncherWindows.cpp
+++ b/lldb/source/Host/windows/ProcessLauncherWindows.cpp
@@ -83,7 +83,7 @@
 
     const char *path = action->GetPath();
     DWORD access = 0;
-    DWORD share = FILE_SHARE_READ | FILE_SHARE_WRITE;
+    DWORD share = FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE;
     DWORD create = 0;
     DWORD flags = 0;
     if (fd == STDIN_FILENO)