commit 055fcec78cf6026719af4966c7568e39c1229d2d
author Erik Pilkington <erik.pilkington@gmail.com> Mon Aug 12 19:29:43 2019 +0000
committer Erik Pilkington <erik.pilkington@gmail.com> Mon Aug 12 19:29:43 2019 +0000
tree 61b63147257e4764dbd17003125e42a6bb8172ec
parent 0761a38e8af5bddaf8d7622501c56988bea86af3

[Sema] Check __builtin_bit_cast operand for completeness before materializing it.

This shouldn't be observable, but it doesn't make sense to materialize an
incomplete type.

llvm-svn: 368610

clang/lib/Sema/SemaCast.cpp

diff --git a/clang/lib/Sema/SemaCast.cpp b/clang/lib/Sema/SemaCast.cpp
index 7a1d52a..71e5e8e 100644
--- a/clang/lib/Sema/SemaCast.cpp
+++ b/clang/lib/Sema/SemaCast.cpp
@@ -2799,9 +2799,6 @@
 
 void CastOperation::CheckBuiltinBitCast() {
   QualType SrcType = SrcExpr.get()->getType();
-  if (SrcExpr.get()->isRValue())
-    SrcExpr = Self.CreateMaterializeTemporaryExpr(SrcType, SrcExpr.get(),
-                                                  /*IsLValueReference=*/false);
 
   if (Self.RequireCompleteType(OpRange.getBegin(), DestType,
                                diag::err_typecheck_cast_to_incomplete) ||
@@ -2811,6 +2808,10 @@
     return;
   }
 
+  if (SrcExpr.get()->isRValue())
+    SrcExpr = Self.CreateMaterializeTemporaryExpr(SrcType, SrcExpr.get(),
+                                                  /*IsLValueReference=*/false);
+
   CharUnits DestSize = Self.Context.getTypeSizeInChars(DestType);
   CharUnits SourceSize = Self.Context.getTypeSizeInChars(SrcType);
   if (DestSize != SourceSize) {