commit 06e39a3aed315950d58617f6f9c1f208c356fd02
author Haojian Wu <hokein@google.com> Tue Nov 08 00:45:34 2016 +0000
committer Haojian Wu <hokein@google.com> Tue Nov 08 00:45:34 2016 +0000
tree 27df1be74748b594df1581faa905d2901d3d2593
parent 9ac0eba6724806d65d2b28b6e96cceded33b4e35

[clang-tidy] Don't warn implicit variables in peformance-unnecessary-copy-initialization.

Summary:

This will prevent the check warning the variables which have been
implicitly added by compiler, like the following case (in for-range loop):

  the variable '__end' is copy-constructed from a const reference...

Reviewers: alexfh

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D25911

llvm-svn: 286186

clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp

diff --git a/clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp b/clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp
index e486350..66773a6 100644
--- a/clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp
+++ b/clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp
@@ -57,6 +57,7 @@
                    declStmt(
                        has(varDecl(hasLocalStorage(),
                                    hasType(matchers::isExpensiveToCopy()),
+                                   unless(isImplicit()),
                                    hasInitializer(
                                        cxxConstructExpr(
                                            hasDeclaration(cxxConstructorDecl(