commit 07f5b65e637eb8e77ff6310d64f39e668ba967cb
author Chandler Carruth <chandlerc@gmail.com> Thu May 26 23:37:58 2011 +0000
committer Chandler Carruth <chandlerc@gmail.com> Thu May 26 23:37:58 2011 +0000
tree 3aaaf6c354eaf9755b5cdfac1e46450b36d38585
parent bf22998f21fd61b53ec8b40c6255ec31091c881e

Fix warning about || and && without explicit grouping.

This looks like it flagged an actual bug. Devang, please review. I added
the parentheses that change behavior, but make the behavior more closely
match commit log's intent.

llvm-svn: 132165

llvm/lib/Transforms/Scalar/CodeGenPrepare.cpp

diff --git a/llvm/lib/Transforms/Scalar/CodeGenPrepare.cpp b/llvm/lib/Transforms/Scalar/CodeGenPrepare.cpp
index dbf0e08..eb33fe2 100644
--- a/llvm/lib/Transforms/Scalar/CodeGenPrepare.cpp
+++ b/llvm/lib/Transforms/Scalar/CodeGenPrepare.cpp
@@ -554,8 +554,8 @@
   // find a node corresponding to the value.
   if (DbgValueInst *DVI = dyn_cast<DbgValueInst>(CI))
     if (Instruction *VI = dyn_cast_or_null<Instruction>(DVI->getValue()))
-      if (!VI->isTerminator() && 
-          DVI->getParent() != VI->getParent() || DT->dominates(DVI, VI)) {
+      if (!VI->isTerminator() &&
+          (DVI->getParent() != VI->getParent() || DT->dominates(DVI, VI))) {
         DEBUG(dbgs() << "Moving Debug Value before :\n" << *DVI << ' ' << *VI);
         DVI->removeFromParent();
         if (isa<PHINode>(VI))