Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins; other minor fixes.
Differential Revision: http://reviews.llvm.org/D13840
llvm-svn: 250721
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
index 9358ce1..be8e870 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
@@ -1,4 +1,4 @@
-//===-- SymbolFileDWARFDebugMap.cpp ----------------------------*- C++ -*-===//
+//===-- SymbolFileDWARFDebugMap.cpp -----------------------------*- C++ -*-===//
//
// The LLVM Compiler Infrastructure
//
@@ -7,6 +7,10 @@
//
//===----------------------------------------------------------------------===//
+// C Includes
+// C++ Includes
+// Other libraries and framework includes
+// Project includes
#include "SymbolFileDWARFDebugMap.h"
#include "DWARFDebugAranges.h"
@@ -41,9 +45,6 @@
// (so we can fixup the object file sections) and also for "Module::GetSymbolVendor()"
// (so we can fixup the symbol file id.
-
-
-
const SymbolFileDWARFDebugMap::FileRangeMap &
SymbolFileDWARFDebugMap::CompileUnitInfo::GetFileRangeMap(SymbolFileDWARFDebugMap *exe_symfile)
{
@@ -173,7 +174,6 @@
return file_range_map;
}
-
class DebugMapModule : public Module
{
public:
@@ -190,14 +190,10 @@
{
}
- virtual
- ~DebugMapModule ()
- {
- }
+ ~DebugMapModule() override = default;
-
- virtual SymbolVendor*
- GetSymbolVendor(bool can_create = true, lldb_private::Stream *feedback_strm = NULL)
+ SymbolVendor*
+ GetSymbolVendor(bool can_create = true, lldb_private::Stream *feedback_strm = NULL) override
{
// Scope for locker
if (m_symfile_ap.get() || can_create == false)
@@ -259,7 +255,6 @@
PluginManager::UnregisterPlugin (CreateInstance);
}
-
lldb_private::ConstString
SymbolFileDWARFDebugMap::GetPluginNameStatic()
{
@@ -279,7 +274,6 @@
return new SymbolFileDWARFDebugMap (obj_file);
}
-
SymbolFileDWARFDebugMap::SymbolFileDWARFDebugMap (ObjectFile* ofile) :
SymbolFile(ofile),
m_flags(),
@@ -290,7 +284,6 @@
{
}
-
SymbolFileDWARFDebugMap::~SymbolFileDWARFDebugMap()
{
}
@@ -508,7 +501,6 @@
return NULL;
}
-
bool
SymbolFileDWARFDebugMap::GetFileSpecForSO (uint32_t oso_idx, FileSpec &file_spec)
{
@@ -523,8 +515,6 @@
return false;
}
-
-
ObjectFile *
SymbolFileDWARFDebugMap::GetObjectFileByOSOIndex (uint32_t oso_idx)
{
@@ -552,7 +542,6 @@
return NULL;
}
-
uint32_t
SymbolFileDWARFDebugMap::GetCompUnitInfoIndex (const CompileUnitInfo *comp_unit_info)
{
@@ -628,7 +617,6 @@
return m_compile_unit_infos.size();
}
-
CompUnitSP
SymbolFileDWARFDebugMap::ParseCompileUnitAtIndex(uint32_t cu_idx)
{
@@ -679,7 +667,6 @@
return NULL;
}
-
size_t
SymbolFileDWARFDebugMap::GetCompUnitInfosForModule (const lldb_private::Module *module, std::vector<CompileUnitInfo *>& cu_infos)
{
@@ -746,7 +733,6 @@
return 0;
}
-
size_t
SymbolFileDWARFDebugMap::ParseTypes (const SymbolContext& sc)
{
@@ -756,7 +742,6 @@
return 0;
}
-
size_t
SymbolFileDWARFDebugMap::ParseVariablesForContext (const SymbolContext& sc)
{
@@ -766,8 +751,6 @@
return 0;
}
-
-
Type*
SymbolFileDWARFDebugMap::ResolveTypeUID(lldb::user_id_t type_uid)
{
@@ -838,7 +821,6 @@
return resolved_flags;
}
-
uint32_t
SymbolFileDWARFDebugMap::ResolveSymbolContext (const FileSpec& file_spec, uint32_t line, bool check_inlines, uint32_t resolve_scope, SymbolContextList& sc_list)
{
@@ -949,7 +931,6 @@
return variables.GetSize() - original_size;
}
-
uint32_t
SymbolFileDWARFDebugMap::FindGlobalVariables (const RegularExpression& regex, bool append, uint32_t max_matches, VariableList& variables)
{
@@ -991,7 +972,6 @@
return variables.GetSize() - original_size;
}
-
int
SymbolFileDWARFDebugMap::SymbolContainsSymbolWithIndex (uint32_t *symbol_idx_ptr, const CompileUnitInfo *comp_unit_info)
{
@@ -1006,7 +986,6 @@
return 1;
}
-
int
SymbolFileDWARFDebugMap::SymbolContainsSymbolWithID (user_id_t *symbol_idx_ptr, const CompileUnitInfo *comp_unit_info)
{
@@ -1021,7 +1000,6 @@
return 1;
}
-
SymbolFileDWARFDebugMap::CompileUnitInfo*
SymbolFileDWARFDebugMap::GetCompileUnitInfoForSymbolWithIndex (uint32_t symbol_idx, uint32_t *oso_idx_ptr)
{
@@ -1070,7 +1048,6 @@
return comp_unit_info;
}
-
static void
RemoveFunctionsWithModuleNotEqualTo (const ModuleSP &module_sp, SymbolContextList &sc_list, uint32_t start_idx)
{
@@ -1128,7 +1105,6 @@
return sc_list.GetSize() - initial_size;
}
-
uint32_t
SymbolFileDWARFDebugMap::FindFunctions (const RegularExpression& regex, bool include_inlines, bool append, SymbolContextList& sc_list)
{
@@ -1163,8 +1139,7 @@
Timer scoped_timer (__PRETTY_FUNCTION__,
"SymbolFileDWARFDebugMap::GetTypes (type_mask = 0x%8.8x)",
type_mask);
-
-
+
uint32_t initial_size = type_list.GetSize();
SymbolFileDWARF *oso_dwarf = NULL;
if (sc_scope)
@@ -1190,7 +1165,6 @@
return type_list.GetSize() - initial_size;
}
-
TypeSP
SymbolFileDWARFDebugMap::FindDefinitionTypeForDWARFDeclContext (const DWARFDeclContext &die_decl_ctx)
{
@@ -1202,8 +1176,6 @@
return type_sp;
}
-
-
bool
SymbolFileDWARFDebugMap::Supports_DW_AT_APPLE_objc_complete_type (SymbolFileDWARF *skip_dwarf_oso)
{
@@ -1414,7 +1386,6 @@
return NULL;
}
-
void
SymbolFileDWARFDebugMap::SetCompileUnit (SymbolFileDWARF *oso_dwarf, const CompUnitSP &cu_sp)
{
@@ -1589,4 +1560,3 @@
}
return num_line_entries_added;
}
-