Refactor Symbol visitor code.
Type visitor code had already been refactored previously to
decouple the visitor and the visitor callback interface. This
was necessary for having the flexibility to visit in different
ways (for example, dumping to yaml, reading from yaml, dumping
to ScopedPrinter, etc).
This patch merely implements the same visitation pattern for
symbol records that has already been implemented for type records.
llvm-svn: 283609
diff --git a/llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp b/llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp
index 69438b3..db39dae 100644
--- a/llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp
+++ b/llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp
@@ -598,11 +598,15 @@
ListScope SS(P, "Symbols");
codeview::CVSymbolDumper SD(P, Dumper, nullptr, false);
bool HadError = false;
- for (const auto &S : ModS.symbols(&HadError)) {
- DictScope DD(P, "");
-
- if (opts::raw::DumpModuleSyms)
- SD.dump(S);
+ for (auto S : ModS.symbols(&HadError)) {
+ DictScope LL(P, "");
+ if (opts::raw::DumpModuleSyms) {
+ if (auto EC = SD.dump(S)) {
+ llvm::consumeError(std::move(EC));
+ HadError = true;
+ break;
+ }
+ }
if (opts::raw::DumpSymRecordBytes)
P.printBinaryBlock("Bytes", S.content());
}
@@ -811,7 +815,10 @@
for (auto S : Publics->getSymbols(&HadError)) {
DictScope DD(P, "");
- SD.dump(S);
+ if (auto EC = SD.dump(S)) {
+ HadError = true;
+ break;
+ }
if (opts::raw::DumpSymRecordBytes)
P.printBinaryBlock("Bytes", S.content());
}